Commit Graph

74 Commits

Author SHA1 Message Date
Cristian Scheid 74849c99e3 fix(team-manager): ensure team resources are only retrived for members
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
2026-06-15 14:12:58 -03:00
Stephan Orbaugh e9d61ebb42 Merge pull request #60655 from nextcloud/chore-psalm-forbid-iconv
chore(psalm): forbid iconv
2026-06-09 17:23:00 +02:00
Côme Chilliet a62bff17f2 fix: Fix suppressing ImpureStaticProperty and suppress it in a few places
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-06-02 09:46:18 +02:00
Côme Chilliet 8b5bc09cbe feat: Add a psalm plugin to forbid static properties and variables
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-06-02 09:46:16 +02:00
Christoph Wurst f2285bb3fc chore(psalm): forbid iconv
iconv transliteration is locale- and config-dependent; use
UnicodeString::ascii() from symfony/string instead.

Assisted-by: Claude:claude-sonnet-4-6
Signed-off-by: Christoph Wurst <1374172+ChristophWurst@users.noreply.github.com>
2026-06-01 12:52:33 +02:00
Micke Nordin ea9bbe64c1 chore: require ext-sodium
Promote ext-sodium from recommended to required so RFC 9421 Ed25519
signing/verifying can rely on libsodium unconditionally. Add the
matching openssl + sodium psalm stubs.

Signed-off-by: Micke Nordin <kano@sunet.se>
2026-05-27 11:03:55 +02:00
Carl Schwan ff07c99e0a Merge pull request #60137 from nextcloud/carl/commnent-event
fix: Dispatch old comment events
2026-05-05 14:30:25 +02:00
Carl Schwan e6a3b689ae fix(tests): Adapt tests for comments
And make sure these are now covered by psalm

Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-05-05 12:50:59 +02:00
Ferdinand Thiessen f6a37dc608 refactor(appstore): split controllers and use proper root
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-05-05 10:41:04 +02:00
provokateurin 42eebfb03c feat(psalm): Enable PHPUnit plugin
Signed-off-by: provokateurin <kate@provokateurin.de>
2026-04-30 12:35:37 +02:00
Ferdinand Thiessen be2ac0bd86 Merge pull request #59932 from nextcloud/carl/copySkeleton
refactor: Move copy skeleton step to a file listener
2026-04-29 23:15:38 +02:00
Ferdinand Thiessen f659e1edb4 chore: ignore unused issue handler suppression due to psalm bug
Otherwise it complains `UndefinedFunction` is not used, but it is.
Ref: https://github.com/vimeo/psalm/issues/11824

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-04-28 21:29:28 +02:00
Ferdinand Thiessen 7055e9ce1d chore: update psalm to v6
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-04-28 21:29:27 +02:00
Carl Schwan bb4c55c125 refactor: Move copy skeleton step to a file listener
Instead of having all user providers call OC_Util::copySkeleton

Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-04-27 15:37:02 +02:00
Ferdinand Thiessen e0c1b74419 test: resolve PHPUnit deprecation warning about addMethods
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-04-01 01:12:52 +02:00
Julien Veyssier da455ee86e feat(profile-picker): move the profile picker to the profile app, remove the user_picker app
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2026-02-23 14:40:50 +01:00
Julien Veyssier 530a0bbbef feat(user-picker): add app to psalm config, fix unit tests
Signed-off-by: Julien Veyssier <julien-nc@posteo.net>
2026-02-20 10:16:34 +01:00
provokateurin 1ed7a0ef98 fix(TransferOwnershipService): Remove groupfolders size
Signed-off-by: provokateurin <kate@provokateurin.de>
2026-02-19 08:38:04 +01:00
Carl Schwan 11cf69d8ba fix(psalm): Fix static analysis issues in apps/*/tests
There are still 1200 more to fix before we can enable static analysis
for the tests.

Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-01-16 12:00:51 +01:00
Carl Schwan a430702caa refactor(psalm): Enable psalm for comments unit tests
This is the first step to enable psalm for our test suite to find issues
also there.

At the moment, this already found some completely broken and unused
method in TestCase and prepare the way for making ICommentsManager work
with snowflake ids by using string instead of int for the ids
consistently.

Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-01-07 13:21:33 +01:00
Joas Schilling 967a181403 ci(psalm): Add a checker against logical operators
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-11-07 12:07:25 +01:00
Benjamin Gaussorgues 3aa0c23e40 Merge pull request #54543 from nextcloud/preview-db-rework 2025-10-08 16:39:23 +02:00
provokateurin 4b90a2c730 build(psalm): Raise PHP version to 8.2
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-10-06 18:01:51 +02:00
Carl Schwan 324b54b863 refactor(preview): Cleanup the implementation of the new preview backend
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
2025-10-06 13:37:15 +02:00
Daniel Kesselberg 28dc3e2d85 chore: move smb package to 3rdparty
- Automated updates
- Easier maintenance
- Not having another copy of the streams packages

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2025-07-31 15:19:07 +02:00
Edward Ly 86533681e8 fix(psalm): suppress UndefinedClass error for OCA\ContextChat\Public\ContentManager
Signed-off-by: Edward Ly <contact@edward.ly>
2025-07-15 08:16:25 -07:00
Jana Peper 603522a59c test: fix tests
Signed-off-by: Jana Peper <jana.peper@nextcloud.com>
2025-07-03 10:25:19 +02:00
Ferdinand Thiessen 2986fead40 chore: ignore 3rdparty while psalm linting
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-05-15 18:38:38 +02:00
provokateurin 0f2f4aab5c feat(psalm): Mark all usage of deprecated code as error
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-05-15 11:48:40 +02:00
Julius Knorr 3fc9a99521 perf: Add config options to trigger individual and sample profiling using excimer
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-04-22 08:57:02 +02:00
Ferdinand Thiessen 4a64cf54ba ci: test that all apps are enabled for psalm
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-07 14:40:37 +02:00
Ferdinand Thiessen c0212af7fa chore: lint files_reminders using psalm
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-04-07 10:56:16 +02:00
provokateurin 6fd17994fb fix(psalm): Enable findUnusedBaselineEntry
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-23 09:14:38 +02:00
Ferdinand Thiessen 2ec68b1eb9 refactor(Log): Use new in initializer instead of constructor body
PHP 8.1 allows us to now move the `new` into the initializer,
this makes the code a bit nicer (and 3 lines shorter).

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-08-17 18:38:28 +02:00
Robin Appelman 5490b12feb chore: add psalm false positive to psalm.xml
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-08-07 19:41:44 +02:00
provokateurin a94249d1d5 build(psalm): Enforce named attribute arguments
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-07-27 22:36:18 +02:00
Côme Chilliet 19bc3ed1e3 chore(webhooks): Rename webhooks application to webhook_listeners
There is already a webhooks application in the appstore

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-06-11 14:10:29 +02:00
Andy Scherzinger 1df96b0417 chore: Add SPDX header
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
2024-05-10 11:07:50 +02:00
Côme Chilliet 9092dcfd41 chore: Fix psalm to use correct php version depending on branch
Needs to be adapted on each branch to reflect the used PHP version and
 help with baseline updating.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-04-22 10:46:02 +02:00
Julius Härtl c7813bfdaf feat: Implement team provider api
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2024-03-05 08:13:58 +01:00
Côme Chilliet 05de5e27eb chore(psalm): Include cron.php into psalm checked files
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-02-08 13:58:49 +01:00
Joas Schilling 00acf1bae1 feat(CI): Add a stub for SensitiveParameter, so Psalm is not failing on Doctrine/DBAL
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-10-06 15:29:24 +02:00
Maxence Lange 8b9e7e235d ocm controller
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-09-20 08:23:45 -01:00
Alexander Piskun 01a11641f4 new name of AppEcosystem is AppAPI
Signed-off-by: Alexander Piskun <bigcat88@icloud.com>
2023-09-06 16:53:53 +03:00
Andrey Borysenko d3583d3f30 Fix psalm ci (stub). Wrap server container with try-catch
Signed-off-by: Andrey Borysenko <andrey18106x@gmail.com>
2023-08-02 17:40:58 +03:00
jld3103 cd91b77193 psalm: Enable more/less specific errors
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-07-03 18:09:27 +02:00
Maxence Lange d2efd0e03c displayname on federated shares
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2023-06-28 09:28:03 -01:00
jld3103 9fddbeaa54 Use psalm 5
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-05-02 13:24:30 +02:00
Joas Schilling 8e529df6ae Merge pull request #37505 from nextcloud/fix/recommended-psalm-options
Set recommended psalm options
2023-04-03 09:54:13 +02:00
jld3103 fa53c7c5a7 Set recommended psalm options
Signed-off-by: jld3103 <jld3103yt@gmail.com>
2023-03-31 09:15:03 +02:00