a459b9cc1f
refactor(server): Register alias when needed
...
And remove useless service registration
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-06-10 23:22:24 +02:00
405d250aef
test: Add missing calls to the parent setUp method
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-06-10 18:07:52 +02:00
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
afe61fe63d
Merge pull request #60286 from nextcloud/fix/noid/appstore-fetcher-generic-file-exception
...
fix(AppStore/Fetcher): catch GenericFileException when reading cache file in Fetcher
2026-05-20 02:51:28 +02:00
c4356e1b25
fix(appstore): address review comments on GenericFileException handling
...
- Attempt delete before logging the warning, so the warning only fires
when we know recovery will succeed
- Log an error (not silently return) when delete itself fails
- Use catch (\Exception) without variable (PHP 8)
- Replace willReturnArgument(1) with explicit willReturn(true) in test
- Add blank lines between logical blocks in test for readability
Signed-off-by: Anna Larch <anna@nextcloud.com >
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-05-19 16:52:52 +02:00
5113b18739
fix(appstore): catch GenericFileException when reading cache file in Fetcher
...
When the appstore cache file exists but getContent() throws a
GenericFileException (I/O error or OS-level permission failure), explicitly
delete the file and recreate it before writing fresh data — mirroring the
NotFoundException recovery path. If deletion itself fails, return [] cleanly.
Previously, the unhandled exception caused the entire apps settings page to
crash. The new test covers both the recovery path and deletion failure.
Signed-off-by: Anna Larch <anna@nextcloud.com >
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-05-19 16:34:06 +02:00
2b2b9840b8
test(appstore): add test cases for appinfo.xml
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-05-12 23:11:24 +02:00
e3783b88e6
fix(AppManager): properly type AppInfo type based on XSD
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-05-12 22:52:32 +02:00
5b756ad8bc
refactor: split appstore from settings
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-05-05 10:41:04 +02:00
e5b1799079
chore: add missing Override attribute to test files
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:28 +02:00
45bae0ea48
fix(openmetrics): Allow openmetrics in info.xml
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2026-01-24 13:11:18 +01:00
1447f182d2
Merge pull request #55405 from nextcloud/carl/cleanup-some-tests
...
refactor: Cleanup some unit tests
2025-10-01 15:02:00 +02:00
60c2875670
refactor: Cleanup some unit tests
...
- use declare(strict_types=1)
- use strong typing
- Remove some weird things in ControllerTest
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-10-01 10:11:27 +02:00
31481701f3
fix(appstore): Make appstore timeout configurable
...
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de >
2025-09-30 13:00:06 +02:00
660f3f6fd1
refactor: use logical && || instead of weak and or operators
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-09-27 23:02:18 +02:00
ae4d38eb63
fix: Allow hyphen in appid
...
It’s rare but exists for some apps not in the appstore.
Also added unit tests for cleanAppId and fixed small issues with it.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-09-16 17:59:30 +02:00
f5111c0961
chore(tests): Do not mock DependencyAnalyzer in AppManagerTest
...
Not ideal to have coupled tests like that but it’s the easiest path
forward to make sure the tests still covers the same usecase and avoid
code duplication.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-08-18 17:09:40 +02:00
12edd2b23a
fix: Deduplicate code by using DependencyAnalyzer in the AppManager
...
Was a bit more complicated than expected because of a dependency loop,
the L10N factory uses the app manager, thus the AppManager cannot depend
on I10N directly or indirectly in its constructor.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-08-18 17:09:40 +02:00
3cea218750
chore(tests): Use valid application names for tests
...
Dash is not allowed in appid, underscore is.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-08-18 17:09:40 +02:00
0ef58c96ab
refactor(Memcache\Factory): move prefix generation to the factory class
...
This removes a circular dependency between AppConfig and cache factory.
When a cache in the app config is used.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-08-18 13:24:18 +02:00
1f5e232314
chore: Move info parsing related method from OC_App to InfoParser
...
Also fix the tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-07-08 15:57:05 +02:00
aa15f9d16d
chore: run rector
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-07-01 22:45:52 +02:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
d8fc08d718
feat(lexicon): fix tests
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2025-06-24 12:10:57 -01:00
29e39c0a2e
chore: run rector on tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-06-12 18:31:58 +02:00
a2fdeccc31
chore(tests): Adapt AppManager test to the use of searchValues
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-06-05 17:58:54 +02:00
9422b6d6d0
test: adjust library tests for PHPunit deprecations
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-05-28 11:20:15 +02:00
720ab52e07
test: Fix tests/lib/App*
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2025-05-15 08:21:24 +02:00
f758f565d4
fix: Replace getInstalledApps calls with getEnabledApps
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-02-13 10:19:20 +01:00
a3685551f7
fix: Replace isInstalled calls with isEnabledForAnyone or isEnabledForUser
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-02-13 10:19:19 +01:00
31664b3edd
fix: Correctly return app id and app version for core styles and images
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-01-24 13:08:31 +01:00
158299b3d7
fix(profile): make sure the app cannot be disabled as it was in core
...
Signed-off-by: skjnldsv <skjnldsv@protonmail.com >
2024-11-14 10:25:10 +01:00
220bd3422f
fix(appinfo): Make sure screenshot, author and category are always arrays
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2024-10-28 08:46:31 +01:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-19 14:21:20 +02:00
49dd79eabb
refactor: Add void return type to PHPUnit test methods
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2024-09-15 22:32:31 +02:00
7ed583cb8e
chore: Migrate cleanAppId and getAppPath calls to IAppManager from OC_App
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-09-13 10:08:43 +02:00
38e0a89972
fix: Add whiteboard to education and public sector bundle
...
Signed-off-by: Julius Knorr <jus@bitgrid.net >
2024-09-12 09:13:42 +02:00
70ed08daf1
refactor(AppManager): Deprecated default apps handling
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-09 11:04:36 +02:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2024-08-25 19:34:58 +02:00
c221090c86
fix: unify bundle naming
...
Signed-off-by: Jérôme Herbinet <33763786+Jerome-Herbinet@users.noreply.github.com >
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-08-06 11:14:07 +02:00
e42bceac9f
feat: hide caldav server settings if no app uses the caldav backend
...
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud >
2024-07-16 09:18:33 +02:00
1f7e2ba599
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-13 17:41:36 +02:00
ac1d868d18
fix: Lazy load IURLGenerator from AppManager to avoid installation crash
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-04-22 15:50:06 +02:00
a0be3ffdf2
fix: Fix tests following OC_App migrations to IAppManager
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-04-22 12:21:55 +02:00
bae133bf4f
fix(AppDiscoverFetcher): Do not remove entries as expired that have no expiry date
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-03-19 09:36:06 +01:00
af49278c5f
test: Update test for PublicSectorBundle
...
Signed-off-by: Christopher Ng <chrng8@gmail.com >
2024-03-12 10:47:12 -07:00
c8d7a5acaa
fix(AppManager): Allow to query dark **or** bright icon
...
The navigation needs the bright icon, while the notifications and activity need a dark icon.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-03-08 09:51:03 +01:00
876e2d6198
feat(AppManager): Provide getAppIcon function
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-03-07 22:40:31 +01:00
e13fb468cf
fix: Fetch custom app store url without internet connection
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2024-03-04 12:47:14 +01:00
57a30e9bbe
fix(appstore): Only send subscription keys to valid appstores
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2024-01-15 15:39:45 +01:00
Carl Schwan
provokateurin
Côme Chilliet
Anna
Ferdinand Thiessen
Joas Schilling
Joas Schilling
Carl Schwan
Marcel Müller
Robin Appelman
Maxence Lange
skjnldsv
Christoph Wurst
Julius Knorr
Daniel Kesselberg
Jérôme Herbinet
Richard Steinmetz
Andy Scherzinger
Christopher Ng