1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
c4356e1b25
fix(appstore): address review comments on GenericFileException handling
...
- Attempt delete before logging the warning, so the warning only fires
when we know recovery will succeed
- Log an error (not silently return) when delete itself fails
- Use catch (\Exception) without variable (PHP 8)
- Replace willReturnArgument(1) with explicit willReturn(true) in test
- Add blank lines between logical blocks in test for readability
Signed-off-by: Anna Larch <anna@nextcloud.com >
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-05-19 16:52:52 +02:00
5113b18739
fix(appstore): catch GenericFileException when reading cache file in Fetcher
...
When the appstore cache file exists but getContent() throws a
GenericFileException (I/O error or OS-level permission failure), explicitly
delete the file and recreate it before writing fresh data — mirroring the
NotFoundException recovery path. If deletion itself fails, return [] cleanly.
Previously, the unhandled exception caused the entire apps settings page to
crash. The new test covers both the recovery path and deletion failure.
Signed-off-by: Anna Larch <anna@nextcloud.com >
AI-Assisted-By: Claude Sonnet 4.6 <noreply@anthropic.com >
2026-05-19 16:34:06 +02:00
e5b1799079
chore: add missing Override attribute to test files
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:28 +02:00
1447f182d2
Merge pull request #55405 from nextcloud/carl/cleanup-some-tests
...
refactor: Cleanup some unit tests
2025-10-01 15:02:00 +02:00
60c2875670
refactor: Cleanup some unit tests
...
- use declare(strict_types=1)
- use strong typing
- Remove some weird things in ControllerTest
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-10-01 10:11:27 +02:00
31481701f3
fix(appstore): Make appstore timeout configurable
...
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de >
2025-09-30 13:00:06 +02:00
aa15f9d16d
chore: run rector
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-07-01 22:45:52 +02:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
720ab52e07
test: Fix tests/lib/App*
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2025-05-15 08:21:24 +02:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-19 14:21:20 +02:00
49dd79eabb
refactor: Add void return type to PHPUnit test methods
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2024-09-15 22:32:31 +02:00
1f7e2ba599
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-13 17:41:36 +02:00
bae133bf4f
fix(AppDiscoverFetcher): Do not remove entries as expired that have no expiry date
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-03-19 09:36:06 +01:00
e13fb468cf
fix: Fetch custom app store url without internet connection
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2024-03-04 12:47:14 +01:00
57a30e9bbe
fix(appstore): Only send subscription keys to valid appstores
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2024-01-15 15:39:45 +01:00
8d5165e8dc
Adapt tests to config value typing
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-04-05 17:42:14 +02:00
c7e1c36362
Remove at matcher uses in tests/lib
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-06-16 17:43:17 +02:00
21f96308c4
Overwrite the channel
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2022-03-10 16:16:30 +01:00
f24e8212c3
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2021-10-21 09:27:12 +02:00
1f76423500
Send the subscription key to the appstore requests
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com >
2021-10-14 14:48:45 +02:00
1a6bac5874
Allow to whitelist apps from the apsptore
...
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com >
2021-10-13 11:13:33 +02:00
df47445c01
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2021-04-27 14:34:32 +02:00
4512c73293
Only retry fetching app store data once every 5 minutes in case it fails
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2020-10-16 14:32:58 +02:00
d9015a8c94
Format code to a single space around binary operators
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-10-05 20:25:24 +02:00
234b510652
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2020-08-12 13:55:19 +02:00
b6d5979d0a
Increase timeout of the appstore requests
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2020-06-12 13:01:06 +02:00
8123737a40
Revert "Compress the appstore requests by default"
...
This reverts commit 6ffde128adhey@morrisjobke.de >
2020-05-20 13:37:28 +02:00
6ffde128ad
Compress the appstore requests by default
...
In test it reduced the transfered data from 5 MB to 2 MB. This should reduce the load on the appstore significantly.
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2020-05-20 09:51:07 +02:00
3e0d8df036
Cache appstore requests for 60 instead of 5 minutes
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2020-05-20 09:51:06 +02:00
a7c8d26d31
Add visibility to all properties and move static keyword
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-10 16:48:31 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-10 14:19:56 +02:00
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-10 10:35:09 +02:00
afbd9c4e6e
Unify function spacing to PSR2 recommendation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-09 13:54:22 +02:00
2fbad1ed72
Fix (array) indent style to always use one tab
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-09 10:16:08 +02:00
b80ebc9674
Use the short array syntax, everywhere
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-03-26 16:34:56 +01:00
2ee65f177e
Use the shorter phpunit syntax for mocked return values
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-03-25 22:21:27 +01:00
2f89f5fd13
AppFetcher: Distinguish between fileName and endpointName
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com >
2020-01-09 17:29:00 +01:00
f0bef8881d
Restore old behavior allowing to set custom appstore
...
Signed-off-by: Georg Ehrke <developer@georgehrke.com >
2019-12-22 15:06:31 +01:00
3a7cf40aaa
Mode to modern phpunit
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-11-27 15:27:18 +01:00
c007ca624f
Make phpunit8 compatible
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-11-27 13:34:41 +01:00
769cb629ae
allow enforcing apps to ignore the max version
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-03-20 15:16:11 +01:00
362e6b2903
Fix tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-05-14 13:30:22 +02:00
ac939e8fd4
Fix version comparison with minor and patch level requirements
...
If an app requires a specific minor or path level server version,
the version_compare prevented the installation as only the major
version had been compared and that checks obviously returns `false`.
Now the full version is used for comparison, making it possible to
release apps for a specific minor or patch level version of Nextcloud.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2018-04-11 10:08:23 +02:00
6bbda28881
Fix tests
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-11-17 20:41:58 +01:00
48a9a4bd81
Merge pull request #4825 from nextcloud/add-timeout-appstore
...
Add timeout for requests to appstore
2017-05-12 12:37:18 +02:00
e6a0ad4701
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2017-05-12 10:02:15 +02:00
adad4281af
Fix failed assertions
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2017-05-12 09:58:18 +02:00
538d32fe87
Automatic injection into the Fetchers
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2017-05-10 09:56:38 +02:00
ae7c1504a9
Fix test
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2017-05-02 11:38:21 +02:00
Côme Chilliet
Anna Larch
Ferdinand Thiessen
Joas Schilling
Carl Schwan
Marcel Müller
Robin Appelman
Joas Schilling
provokateurin
Christoph Wurst
Andy Scherzinger
Julius Härtl
John Molakvoæ
Morris Jobke
Georg Ehrke
Roeland Jago Douma
Lukas Reschke