80ec3b1b0a
fix(MailPlugin): Stop applying the offset twice and the limit per wide/exact
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-06-01 14:24:01 +02:00
5c21fb5062
perf(MailPlugin): Optimize checking group memberships
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-06-01 14:22:45 +02:00
d92aac8f7d
fix(MailPlugin): Use correct type for exact id match
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-06-01 14:22:45 +02:00
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
e5b1799079
chore: add missing Override attribute to test files
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:28 +02:00
663018455e
refactor: Apply rector changes
...
Signed-off-by: GitHub <noreply@github.com >
2026-03-01 14:43:11 +00:00
9dc1d6372f
fix(IContainer): Fix parameter and return types
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-02-16 10:45:13 +01:00
c96ece0bcb
refactor: Add more typing
...
- repairs job
- database
- redis
And remove Helpertest which was unused outside of some tests.
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:55:39 +01:00
ad65bcb653
test(UserPlugin): Rewrite unit tests as integration tests
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-01-21 14:29:58 +01:00
a45f4b0cdc
fix: Fix setting name inconsistency between backend and frontend
...
Signed-off-by: Julius Knorr <jus@bitgrid.net >
2025-12-12 13:08:34 +01:00
40246d9a19
fix(sharing): Add isTrustedServer flag to lookup results
...
When `show_federated_shares_to_trusted_servers_as_internal` is enabled,
lookup server results were being filtered out because they lacked the
`isTrustedServer` flag. This adds the flag to lookup results by:
- Injecting TrustedServers service into LookupPlugin
- Adding `server` and `isTrustedServer` fields to each lookup result
- Updating tests to reflect new structure
This ensures lookup results from trusted servers appear in internal
sharing while non-trusted servers are correctly filtered out.
Signed-off-by: nfebe <fenn25.fn@gmail.com >
2025-11-24 23:32:40 +01:00
503a65ddd0
refactor: Run rector
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-11-18 17:45:54 +01:00
c40fcba5a4
fix: Fix user collaborators returned when searching for mail collaborators
...
The MailPlugin collaborator returned results for both user and mail
collaborators, but it was registered only for mail collaborators. While
it might make sense to move the user results to the UserPlugin instead
that change would be more complex and riskier, so for now the MailPlugin
is now registered for both user and mail collaborators and the results
are limited only to the registered type.
As the plugins are registered only with their class and then resolved
when needed using dependency injection it is not possible (as far as I
know) to provide an explicit parameter in the constructor to
differentiate whether the MailPlugin should return user or mail
collaborators. To overcome this two subclasses are introduced,
MailByMailPlugin and UserByMailPlugin, which just hardcode in their
constructor the collaborator type that their parent MailPlugin must use,
and those subclasses are the ones registered instead of the MailPlugin
(which still contains all the logic).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com >
2025-11-11 01:20:17 +01:00
2c841b2337
test: Rename data providers to match the name of their tests
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com >
2025-11-11 00:54:39 +01:00
74fd144003
test: Replace magic value with named constant of share type
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com >
2025-11-11 00:54:39 +01:00
a0e8d943f1
test: Rename parameters to show that they are expected values
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com >
2025-11-11 00:54:38 +01:00
45f2683a73
test: Fix parameter documentation
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com >
2025-11-11 00:54:38 +01:00
c9bb6eedc6
fix: Include email when searching share suggestions
...
Signed-off-by: nfebe <fenn25.fn@gmail.com >
2025-10-09 06:53:51 +01:00
c1d9e22c51
fix(sharing): Adapt share suggestions to match trusted servers configs
...
When `show_federated_shares_to_trusted_servers_as_internal` is enabled
but `show_federated_shares_as_internal` is not, filter federated share
suggestions to only include trusted servers. Previously, searching for
an email address would suggest non-trusted federated servers.
Resolved : #54511
Signed-off-by: nfebe <fenn25.fn@gmail.com >
2025-10-09 06:53:46 +01:00
83a691709c
refactor: use IEmailValidator.isValid instead of IMailer.validateEmailAddress
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2025-10-04 21:54:22 +02:00
5e9af71509
fix(tests): Fix UserPluginTest methods expectation
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-09-27 13:47:40 +02:00
ac61839d1e
fix(tests): Fix PHPUnit deprecation warnings in tests
...
Turn data providers into static methods, mostly.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-09-27 13:05:32 +02:00
66eb021ece
refactor: remove duplicated types and add return types
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-07-23 15:59:26 +02:00
aa15f9d16d
chore: run rector
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-07-01 22:45:52 +02:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
29e39c0a2e
chore: run rector on tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-06-12 18:31:58 +02:00
3e7db013c1
test: Fix non-static data providers
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2025-05-15 08:25:01 +02:00
c24f5fb256
test: Finish migrating tests/Core/ to PHPUnit 10 compatible code
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2025-05-02 16:47:42 +02:00
46f531adec
test: Adapt tests to properly use valid email addresses
...
Signed-off-by: Julius Knorr <jus@bitgrid.net >
2025-03-26 11:51:52 +01:00
00d08a4f69
fix(lookup-server): disable lookup server for non-global scale setups
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-03-11 14:26:47 +01:00
34251c4375
fix(lookup-server): do not query data by default
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-03-11 14:26:47 +01:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-19 14:21:20 +02:00
49dd79eabb
refactor: Add void return type to PHPUnit test methods
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2024-09-15 22:32:31 +02:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2024-08-25 19:34:58 +02:00
280d70a5f4
fix(federation): Fix missing protocol on CloudID remote
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2024-06-27 11:26:08 +02:00
1f7e2ba599
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-13 17:41:36 +02:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2023-11-23 10:36:13 +01:00
8d5165e8dc
Adapt tests to config value typing
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-04-05 17:42:14 +02:00
f5c361cf44
composer run cs:fix
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-01-20 11:45:08 +01:00
1626a56dda
adjusts tests for CloudIdManager
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2022-08-31 15:47:00 +02:00
347ca20f4e
Rename setting name to reduce its length
...
Signed-off-by: Louis Chemineau <louis@chmn.me >
2022-06-27 11:04:17 +02:00
c7e1c36362
Remove at matcher uses in tests/lib
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-06-16 17:43:17 +02:00
cd95fce105
Merge pull request #31932 from nextcloud/feat/ignore_second_dn
...
Add settings to ignore second display name in search
2022-04-13 09:52:38 +02:00
37f1c8640e
Add settings to ignore second display name in search
...
Signed-off-by: Louis Chemineau <louis@chmn.me >
2022-04-12 17:27:59 +02:00
10eafd70c8
confirm user is internal to globalscale
...
Signed-off-by: Maxence Lange <maxence@artificial-owl.com >
2022-04-12 09:11:05 -01:00
7ecb65f725
Add check before sending email that email address is valid
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2022-01-11 20:59:44 +01:00
2fe8042fff
Add integration tests for email completion
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2021-12-08 09:08:54 +01:00
7179002600
Allow to get a local cloud id without going through the contacts manager
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2021-07-14 16:08:05 +02:00
1c0d975654
Make dav respect disallowing sharing with groups
...
Closes #25390
Signed-off-by: Thomas Citharel <tcit@tcit.fr >
2021-05-26 11:19:59 +02:00
df47445c01
Fix unit tests
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2021-04-27 14:34:32 +02:00
provokateurin
Côme Chilliet
Ferdinand Thiessen
nextcloud-command
Carl Schwan
Julius Knorr
nfebe
Daniel Calviño Sánchez
Daniel Kesselberg
Robin Appelman
Joas Schilling
Christoph Wurst
Andy Scherzinger
Louis Chemineau
Vincent Petry
Maxence Lange
Carl Schwan
Thomas Citharel