0fee41df7c
perf: Test chunking with a lower amount of entries
...
Use a lower array_chunk values when running the code in the tests for
the comment manager.
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-06-10 11:49:29 +02:00
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
9680004b58
chore: Remove almost all uses of deprecated IServerContainer in lib/private
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-05-11 16:22:22 +02:00
e5b1799079
chore: add missing Override attribute to test files
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:28 +02:00
fe89541be3
fix(comments): Correctly treat end of message as end of code block/inline
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2026-03-17 15:34:47 +01:00
11959a1359
fix(comments): Don't return mentions in markdown code (by default)
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2026-03-16 11:49:07 +01:00
f12cecb684
feat(rector): Enable SafeDeclareStrictTypesRector
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-02-09 10:59:31 +01:00
a430702caa
refactor(psalm): Enable psalm for comments unit tests
...
This is the first step to enable psalm for our test suite to find issues
also there.
At the moment, this already found some completely broken and unused
method in TestCase and prepare the way for making ICommentsManager work
with snowflake ids by using string instead of int for the ids
consistently.
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-01-07 13:21:33 +01:00
d6d6747a73
refactor: apply rector rules for PHPUnit 10
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-10-27 21:56:04 +01:00
102c778228
fix(comments): Fix missing return type on new method
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2025-08-28 08:58:52 +02:00
fa5548a1f3
perf(comments): Add a way to get comments for multiple objects at the same time
...
Signed-off-by: Carl Schwan <carl.schwan@nextclound.com >
2025-08-21 11:18:57 +02:00
088d6843b7
fix(comments): Adjust interface with implementation
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2025-07-10 22:03:21 +02:00
aa15f9d16d
chore: run rector
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-07-01 22:45:52 +02:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
29e39c0a2e
chore: run rector on tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-06-12 18:31:58 +02:00
0d79156bb2
test: Speed up comments test
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2025-05-21 07:53:23 +02:00
3e7db013c1
test: Fix non-static data providers
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2025-05-15 08:25:01 +02:00
7304756e03
test: Sort the reactions before comparing
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2025-05-14 11:42:52 +02:00
d46d2d1acf
test: Fix coding standards
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2025-05-05 10:09:22 +02:00
10424f248b
test(comments): Make Comments test result output properly readable
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2025-05-05 09:38:02 +02:00
e2cd436205
test: Improve comments manager test output in case of failure
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2025-04-09 13:49:16 +02:00
2ef74b9860
Merge pull request #47329 from nextcloud/feat/add-datetime-qbmapper-support
...
feat(AppFramework): Add full support for date / time / datetime columns
2024-10-18 19:05:08 +02:00
882f91605b
fix(comments): Add test for email mention
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2024-10-18 07:39:41 +02:00
db94e10af0
fix: Prevent breaking change in IQueryBuilder
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-10-17 18:31:44 +02:00
ee02e3246d
feat(AppFramework): Add full support for date / time / datetime columns
...
This adds support for all Doctrine supported types, for the column types only the immutable variants needed to be added.
But especially those types are the important ones, as our **Entity** class works by detecting changes through setters.
Meaning if it is mutable, changes like `$entity->date->modfiy()` can not be detected, so the immutable types make more sense here.
Similar the parameter types needed to be added.
`Enity` and `QBMapper` needed to be adjusted so they support (auto map) those types, required when insert or update an entity.
Also added more tests, especially to make sure the mapper really serializes the values correctly.
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de >
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com >
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-10-17 18:31:42 +02:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-19 14:21:20 +02:00
49dd79eabb
refactor: Add void return type to PHPUnit test methods
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2024-09-15 22:32:31 +02:00
6c36c54dc6
feat(db): switch from settype to casts
...
Signed-off-by: Anna Larch <anna@nextcloud.com >
2024-09-15 19:26:58 +02:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2024-08-25 19:34:58 +02:00
9713dd3fa9
chore: Move comments event handler to use proper event dispatcher
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2024-06-26 18:13:07 +02:00
1f7e2ba599
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-13 17:41:36 +02:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-04-02 14:16:21 +02:00
6910832170
Refactor OC\Server::getCommentsManager
...
Signed-off-by: Andrew Summers <18727110+summersab@users.noreply.github.com >
2024-03-15 13:14:06 +01:00
eb5832b8fa
refactor: depricate getNumberOfUnreadCommentsForFolder and redo it's implementation based on getNumberOfUnreadCommentsForObjects
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-03-07 19:19:07 +01:00
e5b0c06b24
feat(comments): Allow mentions of federated users, groups and teams in the future
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2024-02-27 17:11:23 +01:00
6056928dc6
feat(comments): Add a meta data column for comments
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2023-12-14 14:32:00 +01:00
5ed6722dd2
Cover expire_date with unit tests
...
Signed-off-by: Vitor Mattos <vitor@php.rio >
2023-04-26 13:21:08 -03:00
e9295f739e
Split the comments ids by chunks
...
Split the comments ids by chunks to prevent error with Oracle database
that can't do a query with more than 1000 parameters.
https://github.com/nextcloud/spreed/issues/8287
Signed-off-by: Vitor Mattos <vitor@php.rio >
2023-03-01 13:08:17 -03:00
f5c361cf44
composer run cs:fix
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-01-20 11:45:08 +01:00
7a0648757a
Delete comments that expired now
...
Signed-off-by: Vitor Mattos <vitor@php.rio >
2022-07-25 11:30:20 -03:00
d722a0c12a
Adjust fake manager
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2022-07-01 16:38:58 +02:00
198224bf7a
Allow to expire comments of multiple objects with one call
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2022-07-01 15:59:29 +02:00
3be1217c04
Follow the most common pattern used in project
...
```
git grep strval|wc -l
32
git grep "(string)"|wc -l
481
```
Signed-off-by: Vitor Mattos <vitor@php.rio >
2022-06-20 11:46:13 -03:00
c59b0c2ff7
Add comments expire date
...
https://github.com/nextcloud/spreed/pull/7327
Signed-off-by: Vitor Mattos <vitor@php.rio >
2022-06-15 11:58:29 -03:00
902476fa20
Extract the EmojiService from user status and add an OCP interface
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2022-04-28 07:09:44 -03:00
367be7c55f
Allow reactions also with other combined emojis
...
Honerful copying the EmojiService from UserStatus for now
I think this should be put into a decent place and then reused,
but I couldn't find somethin short term before beta1
Signed-off-by: Joas Schilling <coding@schilljs.com >
2022-03-24 15:13:09 +01:00
8ec7c5c8ae
Update ICommentsManager with reaction methods
...
Fix psalm errors
Reorder methods and remove return null
Use best pattern on docblock
Goals: update https://github.com/ChristophWurst/nextcloud_composer/ with reaction methods.
The script
https://github.com/ChristophWurst/nextcloud_composer/blob/master/build.sh
only get lib/public classes
Signed-off-by: Vitor Mattos <vitor@php.rio >
2022-02-03 12:52:18 -03:00
e8c66d0f89
Merge pull request #30794 from nextcloud/techdebt/noid/allow-to-get-comments-with-verb
...
Allow to get comments with a given set of verbs
2022-01-28 16:41:42 +01:00
429380337f
Fix fake manager
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2022-01-21 14:02:34 +01:00
7bb01b6ccc
Refactor and fixes on tests
...
Signed-off-by: Vitor Mattos <vitor@php.rio >
2022-01-21 08:40:29 -03:00
Carl Schwan
Côme Chilliet
Ferdinand Thiessen
Joas Schilling
provokateurin
Carl Schwan
Robin Appelman
Christoph Wurst
Anna Larch
Daniel Kesselberg
Julius Härtl
Andy Scherzinger
Andrew Summers
Vitor Mattos
Joas Schilling