Commit Graph

88512 Commits

Author SHA1 Message Date
Côme Chilliet b37044d484 chore: Fix psalm issues following strong typing of IUser
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-06-11 09:45:32 +02:00
Côme Chilliet a8f21da1f7 fix: Fix data directory permission check and its test
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-06-11 09:45:32 +02:00
Côme Chilliet 9fe62b6338 chore(tests): Speed up TARTest by compressing a smaller folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2026-06-11 09:45:32 +02:00
Côme Chilliet 3101e9db61 chore: Enable sqlite CI testing again
It was restricted to a single test by mistake in 4b015568fc

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:32 +02:00
Côme Chilliet f2c32823d4 chore(tests): Fix typo resulting in tests issue
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:32 +02:00
Côme Chilliet 2315159b15 fix(dav): Remove useless null check on displayName
There is already a fallback to uid inside User.php

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:31 +02:00
Côme Chilliet d881bca11f chore(tests): Adapt tests to IUser strict typing
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:31 +02:00
Benjamin Gaussorgues fff30212a2 chore(tests): enable setup-php failure on deps
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:31 +02:00
Côme Chilliet c7a5ca60ec chore(tests): Exclude files_external tests from default testsuite
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:31 +02:00
Côme Chilliet a51886569e chore: Pass correct type for alias in QueryBuilderTest
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:31 +02:00
Côme Chilliet 4eed4bff3a chore: Fix test in user_ldap passing wrong type
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:30 +02:00
Côme Chilliet 1b53179ba9 chore: Update guest avatar test image
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:30 +02:00
Côme Chilliet b2a69d0095 fix: Silence PHP warnings from fopen and mkdir
We are testing the result and logging our own error anyway.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:30 +02:00
Côme Chilliet 6515fa638a fix: Add explicit getToken method for PublicKeyToken entity
This allows mocking the method in tests, and makes sure typing is
 respected

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:30 +02:00
Benjamin Gaussorgues d089bc7d4c chore(users): add stricter return types to IUser
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:30 +02:00
Côme Chilliet 1f246dec14 chore(tests): Set a token string to avoid getToken returning null from tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:29 +02:00
Benjamin Gaussorgues 10e9fe13d5 chore(workflows): add APCu extension on no db tests
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:29 +02:00
Côme Chilliet ee8227762c chore: Exclude S3 groups from test:db composer command
These groups need a specific setup and are not supported by our main DB
 testing workflows.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:29 +02:00
Côme Chilliet 805902eed3 chore: Re-enable tests failing on drone
We do not use drone anymore, let’s see if we can fix these tests or if
 they should be removed.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:29 +02:00
Côme Chilliet c0a822df26 chore: Exclude skipped groups from nodb test suite
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:29 +02:00
Côme Chilliet 23e9a81477 fix(cache): Improve typing of ICache and CappedMemoryCache
For CappedMemoryCache we allow string|int to be consistent with PHP
 array keys, for ICache we strictly apply the previously stated string
 type for keys.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:28 +02:00
Côme Chilliet 5cbf113315 chore: List skipped tests in PHPUnit output
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:28 +02:00
Benjamin Gaussorgues a8fb722b0e chore: add strict types in IAddressBook::getKey
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:28 +02:00
Benjamin Gaussorgues a07634e383 chore(L10N): add strict types in L10N::localeExists
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:28 +02:00
Côme Chilliet c6452f01a5 chore(tests): Fix User UID mocking in TwoFactorAuth/ManagerTest.php
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:28 +02:00
Côme Chilliet b4f86c032c chore(tests): Avoid deprecation in PublicKeyTokenProvider
Also cleaned up the test a bit.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:27 +02:00
Benjamin Gaussorgues 73506e8486 chore(deprecated): remove Reflection*::setAccessible as it's noop since PHP 8.1
Method ReflectionProperty::setAccessible() is deprecated since 8.5, as it has no effect since PHP 8.1

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:27 +02:00
Benjamin Gaussorgues 83b863499a chore(deprecated): remove imagedestroy as it's noop since PHP 8.0
Function imagedestroy() is deprecated since 8.5, as it has no effect since PHP 8.0

Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2026-06-11 09:45:05 +02:00
Kate 0302d60f0c Merge pull request #61176 from nextcloud/fix/deprecated-85
fix: resolve PHP deprecation of `imagedestroy`
2026-06-11 08:14:34 +02:00
Nextcloud bot bb8bc057ac fix(l10n): Update translations from Transifex
Signed-off-by: Nextcloud bot <bot@nextcloud.com>
2026-06-11 00:23:13 +00:00
Ferdinand Thiessen 2a5fc73ca9 fix: resolve PHP deprecation of imagedestroy
> Prior to PHP 8.0.0, imagedestroy() freed any memory associated with the image resource.
> As of 8.0.0, the GD extension uses objects instead of resources, and objects cannot be explicitly closed.

With PHP 8.5 this is deprecated and causes a deprecation warning!

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-06-11 00:59:15 +02:00
Ferdinand Thiessen ab96b85ac6 test(systemtags): migrate from Cypress to PlayWright
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2026-06-11 00:56:46 +02:00
SebastianKrupinski 507e6208ca fix: use card interface instead of object
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
2026-06-10 18:05:10 -04:00
Carl Schwan a459b9cc1f refactor(server): Register alias when needed
And remove useless service registration

Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-06-10 23:22:24 +02:00
Benjamin Gaussorgues 2b7415ef4d Merge pull request #60960 from nextcloud/carl/querybuilder-magic-number
refactor: Use new IQueryBuilder::MAX_IN_PARAMETERS
2026-06-10 23:09:30 +02:00
dependabot[bot] 6f63154e67 build(deps): Bump shell-quote and concurrently
Bumps [shell-quote](https://github.com/ljharb/shell-quote) to 1.8.4 and updates ancestor dependency [concurrently](https://github.com/open-cli-tools/concurrently). These dependencies need to be updated together.


Updates `shell-quote` from 1.8.3 to 1.8.4
- [Changelog](https://github.com/ljharb/shell-quote/blob/main/CHANGELOG.md)
- [Commits](https://github.com/ljharb/shell-quote/compare/v1.8.3...v1.8.4)

Updates `concurrently` from 9.2.1 to 10.0.3
- [Release notes](https://github.com/open-cli-tools/concurrently/releases)
- [Commits](https://github.com/open-cli-tools/concurrently/compare/v9.2.1...v10.0.3)

---
updated-dependencies:
- dependency-name: shell-quote
  dependency-version: 1.8.4
  dependency-type: indirect
- dependency-name: concurrently
  dependency-version: 10.0.3
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <support@github.com>
2026-06-10 20:31:21 +00:00
Kate 8948e923e8 Merge pull request #61169 from nextcloud/test/parent-setup
test: Add missing calls to the parent setUp method
2026-06-10 22:12:55 +02:00
Robin Appelman bae156db12 fix: pass parent id to correctParentStorageMtime when known
Signed-off-by: Robin Appelman <robin@icewind.nl>
2026-06-10 18:24:52 +02:00
provokateurin 405d250aef test: Add missing calls to the parent setUp method
Signed-off-by: provokateurin <kate@provokateurin.de>
2026-06-10 18:07:52 +02:00
Louis 8fc2e1c2b3 Merge pull request #61153 from nextcloud/test/migrate-files-regression-playwright
test(files): migrate recent-view and regression specs from Cypress to…
2026-06-10 17:56:13 +02:00
Louis 954fc50274 Merge pull request #61152 from nextcloud/test/migrate-files-actions-playwright
test(files): migrate files actions e2e from Cypress to Playwright
2026-06-10 17:45:27 +02:00
Carl Schwan 6fc428a512 Merge pull request #61145 from nextcloud/test/migrate-favorites-playwright
test(files): migrate favorites e2e from Cypress to Playwright
2026-06-10 17:38:04 +02:00
Stephan Orbaugh 1cf3e362b2 Merge pull request #40407 from haslersn/revert-pr-12573
Revert "Do not do redirect handling when loggin out"
2026-06-10 17:33:10 +02:00
Louis 250635a9a8 Merge pull request #61150 from nextcloud/carl/speedup-tests
Speedup tests execution
2026-06-10 17:23:13 +02:00
Joas Schilling 3b89bf256e Merge pull request #61149 from nextcloud/dependabot/composer/symfony/dom-crawler-7.4.12
build(deps): bump symfony/dom-crawler from 6.4.32 to 7.4.12
2026-06-10 17:17:46 +02:00
Peter R. 20c9360c58 Merge pull request #61109 from nextcloud/fix/waffle-current-app-icon-light-bg
fix(core): keep app menu settings icon legible on light backgrounds
2026-06-10 17:14:33 +02:00
Carl Schwan c02a231e7f perf(CheckSetupController): Remove BackupStaticProperties
It's so slow 25s per test cases

Signed-off-by: Carl Schwan <carlschwan@kde.org>
2026-06-10 16:36:06 +02:00
Cristian Scheid 3592f83218 Merge pull request #60844 from nextcloud/fix/noid/files-join-ext-cache-select-fields
feat(file-search): add property to SearchQuery and check select fields to decide wheter to join extended cache
2026-06-10 16:26:55 +02:00
Ferdinand Thiessen 9848f9e65a Merge pull request #61143 from nextcloud/ci/playwright
docs(tests): Add some general documentation for PlayWright
2026-06-10 16:11:36 +02:00
Joas Schilling 92ad5b1081 build(deps): bump symfony/dom-crawler from 6.4.32 to 7.4.12
Signed-off-by: Joas Schilling <coding@schilljs.com>
2026-06-10 15:57:02 +02:00