averello/nextcloud-server-mirror
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-03-04 18:28:08 +01:00
Code Issues Packages Projects Releases Wiki Activity
85,952 Commits 712 Branches 1,186 Tags
jtr/refactor-setup-AbstractDatabase
Commit Graph

16667 Commits

Author SHA1 Message Date
Josh
edbb1e2821 chore(Setup/AbstractDB): fixup for cs and psalm 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2026-02-18 22:32:10 -05:00
Josh
46b6185202 refactor(setup/AbstractDB): add logging and docs to runMigrations 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2026-02-18 22:04:40 -05:00
Josh
d3ce30b46a feat(setup/AbstractDB): add param debug logging to connect() 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2026-02-18 16:56:01 -05:00
Josh
c2067e1889 refactor(setup/AbstractDB): extract port/socket handling logic 
Also:

- add some helpful inline comments
- simplify primary/replica param merging (same outcome)

Signed-off-by: Josh <josh.t.richards@gmail.com>
 2026-02-18 16:46:55 -05:00
Josh
1d33bbbda7 refactor(setup/AbstractDB): split initialize() logic up into helpers 
- Improved readability
- Easier child class customization

Also added for certain config keys: a couple clarifying comments and additional error checking

Signed-off-by: Josh <josh.t.richards@gmail.com>
 2026-02-18 11:26:27 -05:00
Josh
55268455a6 refactor(setup/AbstractDB): early return + override comment in validateDatabaseName() 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2026-02-18 10:23:04 -05:00
Josh
a5c4640be7 chore(setup/PostgreSQL): switch from $dbprettyname to getDisplayName 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2026-02-18 10:08:17 -05:00
Josh
63e1a49c0a chore(setup/Sqlite): switch from $dbprettyname to getDisplayName 
And canonicalize "SQLite" properly

Signed-off-by: Josh <josh.t.richards@gmail.com>
 2026-02-18 10:06:45 -05:00
Josh
f9ae23b064 chore(setup/OCI): switch from $dbprettyname to getDisplayName 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2026-02-18 10:04:48 -05:00
Josh
b0294cf397 chore(setup/MySQL): switch from $dbprettyname to getDisplayName 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2026-02-18 10:03:22 -05:00
Josh
41c9b48346 refactor(setup/AbstractDB): eliminate magic property $this->dbprettyname 
- Makes the undefined property explicit and required (less psalm baseline noise)
- Forces child classes to implement it
- Better type safety

Signed-off-by: Josh <josh.t.richards@gmail.com>
 2026-02-18 10:00:18 -05:00
Josh
28449695f7 refactor(setup/OCI): override override validateDatabaseName() to skip dot check 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2026-02-18 09:35:31 -05:00
Josh
57e54fd867 refactor(setup/AbstractDB): Extract validation methods 
- Child classes can override specific validation rules more selectively (e.g. OCI override becomes simpler to avoid the dot check)
- Improved code readability

Signed-off-by: Josh <josh.t.richards@gmail.com>
 2026-02-18 09:28:11 -05:00
Josh
5aba60adab fix(setup/AbstractDB): handle missing dbname in dots check 
Also:

- Switch to more modern str_contains()
- Tidy up code formatting a bit

Signed-off-by: Josh <josh.t.richards@gmail.com>
 2026-02-18 09:20:24 -05:00
Ferdinand Thiessen
88bb82ccfe fix(cache): filter out invalid entries in OC\Files\Cache\Wrapper\CacheWrapper::getFolderContentsById 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2026-02-17 17:20:46 +01:00
Ferdinand Thiessen
560df4a73c fix(cache): filter out invalid entries in OC\Files\Cache\Wrapper\CacheWrapper::getFolderContentsById 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>

[skip ci]
 2026-02-17 17:17:02 +01:00
Kate
e9bba6a610 Merge pull request #58286 from nextcloud/fix/groupfolders-phpstan 
Fix a bunch of typing issues to make PHPStan level 10 happy on groupfolders
 2026-02-17 13:30:46 +01:00
Ferdinand Thiessen
b0e99d0293 Merge pull request #58327 from nextcloud/feat/1698/recent-files-include-recently-uploaded 
feat: add upload_time support to file search and recent files
 2026-02-17 11:48:12 +01:00
provokateurin
4eada2d804 refactor(Files): Modernize Wrapper 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2026-02-17 06:43:16 +01:00
provokateurin
5f4a5d8c67 refactor(Files): Remove deprecated streamCopy method 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2026-02-17 06:43:16 +01:00
provokateurin
c953ad9bcd fix(Storage): Use correct return types for getMetaData and getDirectoryContent 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2026-02-17 06:43:16 +01:00
provokateurin
2d486c5629 fix(IGroupManager): Use correct return type for displayNamesInGroup 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2026-02-17 06:43:16 +01:00
provokateurin
e454cc6765 refactor(settings): Modernize authorized group classes 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2026-02-17 06:43:16 +01:00
provokateurin
9dc1d6372f fix(IContainer): Fix parameter and return types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2026-02-16 10:45:13 +01:00
Cristian Scheid
e964351389 feat: add upload_time support to file search and recent files 
Signed-off-by: Cristian Scheid <cristianscheid@gmail.com>
 2026-02-13 14:38:51 -03:00
Carl Schwan
2391d58eb0 Merge pull request #58107 from nextcloud/local-preview-mkdir-exists 
fix: don't try to create preview folder if it already exists
 2026-02-13 15:10:24 +01:00
Kate
b80816dfb7 Merge pull request #58098 from nextcloud/fix/appframework/types-phpstan 
fix(AppFramework): Adjust types so PHPStan understands them
 2026-02-12 14:00:47 +01:00
Kate
4d6959da27 Merge pull request #58261 from nextcloud/fix/simplecontainer/get-return-type 2026-02-12 10:56:53 +01:00
Carl Schwan
d35773b99a Merge pull request #57891 from nextcloud/carl/getDirectoryContent-mimetypefilter 
perf: Allow filtering the directory content by mimetype
 2026-02-12 01:22:10 +01:00
Carl Schwan
3da621d7fb Merge pull request #58230 from nextcloud/carl/fix-appdata-scanning 
fix(preview): Fix files:app-data-scan for previews
 2026-02-12 00:57:28 +01:00
Carl Schwan
edd37d349b perf(file-cache): Add mimetype filter on getFolderContents 
Signed-off-by: Carl Schwan <carlschwan@kde.org>
 2026-02-12 00:36:18 +01:00
Carl Schwan
9741f5f17d perf: Allow filtering the directory content by mimetype 
Signed-off-by: Carl Schwan <carlschwan@kde.org>
 2026-02-12 00:35:48 +01:00
Carl Schwan
3d18cd7cc5 fix(preview): Fix files:app-data-scan for previews 
And add unit tests for both migrated files and non-migrated files

Signed-off-by: Carl Schwan <carlschwan@kde.org>
 2026-02-12 00:26:20 +01:00
Carl Schwan
4722f56778 fix(preview): Handle unique constraints 
Signed-off-by: Carl Schwan <carlschwan@kde.org>
 2026-02-11 19:56:11 +01:00
provokateurin
5c47ce9b40 fix(SimpleContainer): Adjust return type for PHPStan 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2026-02-11 11:42:37 +01:00
provokateurin
e8d4d435ed fix(IRegistrationContext): Use SimpleContainer in registerService factory 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2026-02-11 11:42:37 +01:00
provokateurin
83fbc64c99 fix(IResult): Use more accurate conditional return type for fetchAll 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2026-02-11 08:50:13 +01:00
grnd-alt
bc5771b0ff fix: correctly quote tablenames for truncating with oracle 
Signed-off-by: grnd-alt <git@belakkaf.net>
 2026-02-10 22:48:02 +01:00
provokateurin
fe9e43c165 feat(preview): Expire previews 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2026-02-10 15:35:38 +01:00
Andy Scherzinger
7da7f50203 Merge pull request #58209 from nextcloud/carl/local-preview-fix 
fix(preview): Fix scanning preview
 2026-02-10 12:38:58 +01:00
Carl Schwan
543b46f3aa fix(preview): Fix scanning preview 
Make sure we set the mimetype string representation and not int
representation.

Signed-off-by: Carl Schwan <carlschwan@kde.org>
 2026-02-09 22:49:59 +01:00
Anna Larch
99a1150ec2 fix(snowflake): cast lastId to int 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2026-02-09 21:36:20 +01:00
Andy Scherzinger
39ff32a33b Merge pull request #58134 from nextcloud/carl/lock-propagator-order 
fix(propagator): Improve lock behavior of propagator
 2026-02-09 16:04:38 +01:00
provokateurin
97c09753c3 fix(AppFramework): Adjust types so PHPStan understands them 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2026-02-09 14:08:42 +01:00
Carl Schwan
95b3bd98d9 fix(propagator): Lock rows also in propagateChange 
Signed-off-by: Carl Schwan <carlschwan@kde.org>
 2026-02-09 12:11:21 +01:00
Carl Schwan
f3778bc9c7 fix(propagator): Improve lock behavior of propagator 
Fix possible dead locks when running the propagator caused by two
requests updating the same amount rows in transactions.

- Lock rows always in the same deterministic order by sorting the
  path_hash first

- On all database outside of sqlite, also do first a SELECT FOR UPDATE
  to lock all the rows used in batch UPDATE calls, afterward to decrease
  the risk of two requests trying to lock the same rows

Signed-off-by: Carl Schwan <carlschwan@kde.org>
 2026-02-09 12:10:56 +01:00
provokateurin
f12cecb684 feat(rector): Enable SafeDeclareStrictTypesRector 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2026-02-09 10:59:31 +01:00
Robin Appelman
6c9418880f Merge pull request #57757 from nextcloud/getowner-no-mountpoints 
fix: don't include the mountpoints when getting fileinfo for getOwner
 2026-02-06 17:22:51 +01:00
Robin Appelman
c801d63e5a fix: don't include the mountpoints when getting fileinfo for getOwner 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2026-02-06 15:19:30 +01:00
Carl Schwan
e56e42e7e7 refactor(navigation-manager): Cleanup implementation and add type hinting 
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com>
 2026-02-06 13:55:40 +01:00