16160c9019
fix(encryption): Fix endpoint /ajax/userSetRecovery to support boolean
...
Frontend is sending a boolean but backend was still expecting a string.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-02 15:28:53 +02:00
9c92cc1617
chore: Suppress last known impure static properties
...
We will keep these legacy ones for now. We can search for the
ImpureStaticProperty suppression and add special treatement for them in
the frankenphp PR if needed.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-02 09:46:20 +02:00
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
d8e8703796
chore: add missing Override attribute to app code
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:28 +02:00
fab9046ac9
fix(encryption): limit oprhaned keys scan to one user
...
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com >
2026-04-21 12:13:22 +02:00
9b504039f4
fix: cache validation of system keys
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-03-26 21:12:05 +01:00
5c935429ef
fix: Remove a static var usage in encryption application
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-03-23 16:48:31 +01:00
e4244c5fc8
fix(encryption): Improve type strictness on decryption check
...
Otherwise decrypting a falsy value like '0' would be seen as a
decryption failure.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-02-23 14:49:03 +01:00
f12cecb684
feat(rector): Enable SafeDeclareStrictTypesRector
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-02-09 10:59:31 +01:00
ae73f7aaf5
refactor(setup-manager): Use ISetupManager instead of SetupManager
...
Keep using the OC API in the mount manager and OC_Utils, but the rest is
now using the public API.
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-01-27 15:19:19 +01:00
108858daef
refactor(encryption): migrate to Vue 3 and Typescript and script setup
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-01-13 22:49:18 +01:00
fbff470d4c
Merge pull request #56419 from nextcloud/fix/provide-non-interactive-mode-to-run-encryption
...
fix: support -n option to encrypt-all command to allow to run in non-interactive mode
2025-11-27 11:46:05 +01:00
26e2ff9dca
fix: removed the -n option from options, added the check and made default answer to both questions true to support -n run directly
...
Signed-off-by: yemkareems <yemkareems@gmail.com >
2025-11-19 15:52:47 +05:30
d420b3f157
fix: added the interactive condition to the password question and in non-interactive mode sent the password directly
...
Signed-off-by: yemkareems <yemkareems@gmail.com >
2025-11-14 16:05:14 +05:30
e7d02a6e5f
Merge pull request #56189 from nextcloud/fix/do-not-test-encryption-on-grant
...
fix(encryption): Add the script to test encryption status only on logged in pages
2025-11-13 16:54:05 +01:00
71688e3b8e
Merge pull request #56167 from nextcloud/fix/fix-encryption-with-user-keys
...
fix(encryption): Fix user key support with basic auth
2025-11-13 11:51:59 +01:00
928a45c677
fix(encryption): Fix user key support with basic auth
...
When using basic authentication the user is not logged in yet when
KeyManager constructor gets called, so we need to delay the check for
the loggedin user uid.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-11-10 18:11:01 +01:00
f1cdf6885e
feat: add occ command to scan and selete orphaned keys
...
Signed-off-by: Hamza <hamzamahjoubi221@gmail.com >
2025-11-04 16:56:35 +01:00
ca8b04f331
fix(encryption): Add the script to test encryption status only on logged in pages
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-11-04 14:52:58 +01:00
a3442be054
refactor: fix psalm issues from encryption commands
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-10-01 16:07:41 +02:00
d59338b377
refactor: Apply rector Nextcloud 26 set
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2025-09-28 11:45:52 +02:00
7cc3c1f669
fix(encryption): do not setup filesystem without permissions
...
If the current request does not have permissions for the filesystem we
must not try to setup the filesystem.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-09-20 22:23:12 +02:00
8330f149b0
chore(encryption): Remove unused attribute $uid in KeyManager::getFileKey
...
It’s a private API in the application, no need to keep an unused
attribute.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-09-09 11:46:28 +02:00
bfcb2690f4
chore: Improve wording of logged error in apps/encryption/lib/KeyManager.php
...
Co-authored-by: Louis <louis@chmn.me >
Signed-off-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com >
2025-09-09 11:46:19 +02:00
bc5e29f9f2
fix(tests): Fix type issues and other problems with encryption tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-09-09 11:46:18 +02:00
94254db001
chore(encryption): Cleanup typing in EncryptAll/DecryptAll
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-09-09 11:46:18 +02:00
b74c7538ac
fix(encryption): Do not depend upon user in session unless really necessary
...
Should fix a bunch of stuff when encryption listener is triggered by events from occ commands or background jobs
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-09-09 11:46:17 +02:00
f95fef9938
chore(encryption): Adapt tests to code changes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-08-04 11:53:19 +02:00
d711d68701
fix(encryption): Ignore shared files in encrypt-all command
...
Copying and renaming a share will not encrypt it anyway. It will get
encrypted when the owner’s files get encrypted.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-08-04 10:42:04 +02:00
5bd626bd40
chore: Fix all method calls with too many arguments
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2025-07-22 12:34:49 +02:00
4427050f84
fix(encryption): Correctly handle file opening and copying failures
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-07-03 15:19:34 +02:00
1285ebc3cf
fix(encryption): Catch exceptions in encrypt-all command and continue
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-07-03 15:19:34 +02:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
f6365e76a1
fix(encryption): Do not register user key related event listeners
...
when master key is enabled.
Also added a safeguard in PassphraseService.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-06-16 15:52:41 +02:00
b0b8159d6a
fix: throw a better error if we can't get the encrypted header size
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-05-09 22:33:45 +02:00
a3c2600386
fix(encryption): init keys also when logged in using cookie auth
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-04-02 00:06:10 +02:00
313d2219fd
fix(encryption): Listen for user login and logout to set encryption key
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-03-06 17:22:51 +01:00
e8426996f5
fix(psalm): Fix some newly detected issues
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-21 12:37:59 +02:00
381077028a
refactor(apps): Use constructor property promotion when possible
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-21 12:37:59 +02:00
f3aa004b1c
refactor(encryption): Migrate away from Hooks to typed events
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de >
Co-authored-by: Louis <louis@chmn.me >
Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com >
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-10-15 18:33:06 +02:00
1580c8612b
chore(apps): Apply new rector configuration to autouse classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-10-15 10:40:25 +02:00
51d9d63a01
chore: Use more gender neutral language
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-14 13:59:24 +02:00
1a4978c4ea
chore: Apply rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-09-20 17:51:00 +02:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-19 14:21:20 +02:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2024-08-25 19:34:58 +02:00
6b795da540
Uses early returns.
...
To improve code readability.
Signed-off-by: Faraz Samapoor <fsa@adlas.at >
2024-08-16 09:33:16 +02:00
fc8b886295
Refactors encryption app commands.
...
To improve code readability.
Signed-off-by: Faraz Samapoor <fsa@adlas.at >
2024-08-16 09:33:16 +02:00
4016aace04
refactor(encryption): Replace security annotations with respective attributes
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-07-27 21:32:47 +02:00
39fd19f1d6
refactor(encryption): Migrate app.php to Application.php
...
Signed-off-by: Louis Chemineau <louis@chmn.me >
2024-07-01 13:45:09 +02:00
885604ce2d
fix: add default value for new flag $useDecryptAll on getFileKey
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-06-06 10:23:03 +02:00
Côme Chilliet
Ferdinand Thiessen
Hamza
Robin Appelman
provokateurin
Carl Schwan
Stephan Orbaugh
yemkareems
Côme Chilliet
Carl Schwan
Daniel Kesselberg
Faraz Samapoor
Louis Chemineau