Carl Schwan
5d0d0c17e5
chore(rector): Run rector on apps, core and tests directory
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:23:23 +01:00
SebastianKrupinski
e2c4db1541
fix: generate favourite icon without imagick svg support
...
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com >
2026-01-26 13:57:22 -05:00
Ferdinand Thiessen
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
provokateurin
085d4c9364
refactor(OpenAPI): Adjust scopes to match previous behavior
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2025-01-06 14:30:40 +01:00
provokateurin
381077028a
refactor(apps): Use constructor property promotion when possible
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-21 12:37:59 +02:00
provokateurin
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-19 14:21:20 +02:00
provokateurin
79d9f2ebf6
refactor(theming): Replace security annotations with respective attributes
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-07-27 22:40:06 +02:00
Andy Scherzinger
cc1686dba9
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-31 10:38:47 +02:00
Joas Schilling
2fccd090b3
fix(manifest): Check if app exists instead of accessing null as an array
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2024-01-17 09:25:44 +01:00
Joas Schilling
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2023-11-23 10:36:13 +01:00
jld3103
b58ef2c0b1
theming: Add OpenAPI spec
...
Signed-off-by: jld3103 <jld3103yt@gmail.com >
2023-07-10 17:25:58 +02:00
Simon L
734b8c26db
generate user themed favicon and touchicon
...
Signed-off-by: Simon L <szaimen@e.mail.de >
2023-06-16 00:24:27 +02:00
Simon L
04b236e320
generate user themed icons
...
Signed-off-by: Simon L <szaimen@e.mail.de >
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com >
Co-Authored-By: Côme Chilliet <91878298+come-nc@users.noreply.github.com >
2022-11-18 15:03:41 +01:00
Carl Schwan
7dddbd0c35
Improve caching policy
...
* Cache css with version in url. This makes most js and css requests to
be cached by the browser
* Force caching previews, the etag is in the url so that if the propfind
gives a new etag, we will refresh it otherwise it's no use to try to
fetch the new etag and do tons of DB queries
Tested with firefox and 'debug' => false (important so that the js/css
urls are generated with ?v= parameter)
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2022-02-16 11:35:57 +01:00
Carl Schwan
760db78dba
Add better error handling
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2022-01-27 17:03:09 +01:00
Carl Schwan
f778cbe7b9
Fix registerEventListener issues
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2022-01-27 11:12:45 +01:00
Carl Schwan
e3a12b3482
Fix psalm issues in theming app
...
After this change, we are down to only one psalm warning for this app
and related to the Application.php. This also make composer
psam:update-baseline not silently ignore new errors.
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2022-01-26 14:26:58 +01:00
John Molakvoæ (skjnldsv)
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com >
2021-06-04 22:02:41 +02:00
Christoph Wurst
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-29 11:57:22 +02:00
Christoph Wurst
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-10 14:19:56 +02:00
Christoph Wurst
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2019-12-05 15:38:45 +01:00
Roeland Jago Douma
68748d4f85
Some php-cs fixes
...
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-11-22 20:52:10 +01:00
Michael Weimann
38ea5d14b3
Disables SVG favicon uploads when imagemagick is missing.
...
Signed-off-by: Michael Weimann <mail@michael-weimann.eu >
2018-09-05 20:50:21 +02:00
Morris Jobke
8f6acbff62
Merge pull request #9258 from nextcloud/theming-logo-png
...
Convert theming app logo to PNG to show it properly in emails
2018-06-15 17:02:14 +02:00
Roeland Jago Douma
e4db293cc1
Fix possible test timing issues in IconController
...
Since the response now handles the caching. We need to provide a default
ITimeFactory mock. Else you might have failing tests.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-13 22:54:08 +02:00
Julius Härtl
5b0ce806a3
Minor fixes and cleanup
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-06-06 13:15:52 +02:00
Roeland Jago Douma
e5cc8be9d5
Fix usage
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2018-06-04 08:48:54 +02:00
Julius Härtl
272b392cac
Move to more generic image handling and add extra images
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-04-19 20:14:38 +02:00
Morris Jobke
0eebff152a
Update license headers
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2017-11-06 16:56:19 +01:00
Julius Härtl
489131333a
Inject FileAccessHelper for proper testing
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2017-05-18 10:45:42 +02:00
Julius Härtl
edb5502b9d
Add proper Content-Type to icons
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2017-05-17 10:11:29 +02:00
Julius Härtl
1157f413c9
Fallback to default favicon
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2017-05-17 10:11:29 +02:00
Joas Schilling
8c703c954d
Fix theming tests
...
Trying to configure method "shouldReplaceIcons" which cannot be configured
because it does not exist, has not been specified, is final, or is static
Signed-off-by: Joas Schilling <coding@schilljs.com >
2017-04-20 13:10:34 +02:00
Morris Jobke
5b4adf66e5
Move OC_Defaults to OCP\Defaults
...
* currently there are two ways to access default values:
OCP\Defaults or OC_Defaults (which is extended by
OCA\Theming\ThemingDefaults)
* our code used a mixture of both of them, which made
it hard to work on theme values
* this extended the public interface with the missing
methods and uses them everywhere to only rely on the
public interface
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2017-04-09 21:43:01 -05:00
Julius Haertl
5fbadee95f
Check if image files for theming are empty
...
Signed-off-by: Julius Haertl <jus@bitgrid.net >
2016-12-09 12:54:03 +01:00
Julius Haertl
d409fe1c52
Error handling and tests if file was not found
...
Signed-off-by: Julius Haertl <jus@bitgrid.net >
2016-11-18 10:23:25 +01:00
Julius Haertl
78de213b85
Sanitize input and small fixes
...
Signed-off-by: Julius Haertl <jus@bitgrid.net >
2016-11-18 10:23:25 +01:00
Julius Haertl
3a400f92d1
Replace null return with NotFoundException
...
Signed-off-by: Julius Haertl <jus@bitgrid.net >
2016-11-18 10:23:25 +01:00
Julius Haertl
2e8dd21815
Improve caching
...
Signed-off-by: Julius Haertl <jus@bitgrid.net >
2016-11-18 10:23:24 +01:00
Julius Haertl
492d0b9f9b
Caching for icon files using AppData
...
Signed-off-by: Julius Haertl <jus@bitgrid.net >
2016-11-18 10:23:24 +01:00
Julius Haertl
9e28a3ba12
Theming: Code cleanup and cache buster for mime icons
...
Signed-off-by: Julius Haertl <jus@bitgrid.net >
2016-11-18 10:23:24 +01:00
Julius Haertl
237034818d
Check if dynamic icons can be used
...
Signed-off-by: Julius Haertl <jus@bitgrid.net >
2016-11-18 10:23:24 +01:00
Julius Haertl
af8976ab03
Add IconBuilder class to encapsulate icon generation
...
Signed-off-by: Julius Haertl <jus@bitgrid.net >
2016-11-18 10:23:24 +01:00
Julius Haertl
b466628bfd
Improve unit tests for image generation
...
Signed-off-by: Julius Haertl <jus@bitgrid.net >
2016-11-18 10:23:23 +01:00
Julius Haertl
ac7f852ed9
Theming: Add IconController tests
...
Signed-off-by: Julius Haertl <jus@bitgrid.net >
2016-11-18 10:23:23 +01:00
Julius Haertl
4945592a86
Fix IconController after rebase
...
Signed-off-by: Julius Haertl <jus@bitgrid.net >
2016-11-18 10:23:23 +01:00
Julius Haertl
6c7ebb1204
Theming: Add icon caching
...
Signed-off-by: Julius Haertl <jus@bitgrid.net >
2016-11-18 10:23:23 +01:00
Julius Haertl
c7adcb85ae
Theming: Fix default parameters in icon routes
...
Signed-off-by: Julius Haertl <jus@bitgrid.net >
2016-11-18 10:23:23 +01:00
Julius Haertl
64510bd87a
Theming: Add PHPdoc and icon fallback to theming logo
...
Signed-off-by: Julius Haertl <jus@bitgrid.net >
2016-11-18 10:23:22 +01:00
Julius Haertl
2d65b8c600
Theming: Add favicon-touch and fix icon creation with non svg images
...
Signed-off-by: Julius Haertl <jus@bitgrid.net >
2016-11-18 10:23:22 +01:00