967d8de792
perf(user_ldap): chunk oracle queries for lower bind cost
...
Oracle's OCI8 driver binds each named parameter individually via
OCIBindByName, making queries with 65 000 parameters dramatically
slower than on MySQL or PostgreSQL — slow enough to time out in CI
and degrade production LDAP syncs on large installations.
Lower maxSlices to 5 for Oracle (5 000 params/query) via a match
expression alongside the existing SQLite special-case. SQLite and
all other databases are unchanged.
Assisted-by: ClaudeCode:claude-sonnet-4-6
Signed-off-by: Anna Larch <anna@nextcloud.com >
2026-06-04 10:33:42 +02:00
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
c1dd559965
fix: Use strict array comparisons in user_ldap
...
Otherwise there are issues with string values looking like numbers.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-01-13 11:46:57 +01:00
4d47fdaa85
chore: Run rector with new rules for fetch
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-11-18 17:45:57 +01:00
49f1c3f00e
refactor(LDAP): switch from prepares statement to query builder
...
- has the advantage that queries will be reported in the query.log when
configured
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2025-10-17 11:09:31 +02:00
155b75027c
feat: locally cache frequently requested LDAP mapping data
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2025-10-17 11:09:31 +02:00
381077028a
refactor(apps): Use constructor property promotion when possible
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-21 12:37:59 +02:00
c254855222
chore(db): Correctly apply query types
...
fix: psalm
fix: error
fix: add batch
fix: fatal error
fix: add batch
chore: add batch
chore: add batch
fix: psalm
fix: typo
fix: psalm
fix: return bool
fix: revert Manager
2024-10-17 09:21:07 +02:00
1580c8612b
chore(apps): Apply new rector configuration to autouse classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-10-15 10:40:25 +02:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2024-08-25 19:34:58 +02:00
829f2b9bc7
fix(db): Promote the use of getDatabaseProvider to reduce the impage of removed upstream platforms
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2024-07-19 11:21:14 +02:00
8d8891c5bc
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-30 15:49:33 +02:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-04-02 14:16:21 +02:00
c0ce272e9c
chore: Migrate away from OC::$server->getLogger
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-02-13 17:32:30 +01:00
a372564850
Fix psalm spotted errors with new requirements
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-01-02 15:02:28 +01:00
1b12a08ec2
Fix user_ldap tests
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2022-10-20 12:09:06 +02:00
6c7ba01dfe
Adapt max length limit in AbstactMapping to match database
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-03-30 14:43:09 +00:00
475a859aae
Merge pull request #31421 from nextcloud/fix/user_ldap-fix-ldap-connection-resets
...
user_ldap fix ldap connection resets
2022-03-17 09:13:44 +01:00
ccab35f23f
Fix similar potential problems with fetchOne loops
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-03-08 12:10:52 +01:00
fb63484ced
Improve typing in user_ldap to detect problems early
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-03-03 11:12:09 +01:00
9f2db6e65d
Fix ldap:update-uuid
...
Generators cannot be iterated with while or returned by an other
generator, using foreach instead.
And a few other problems.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-02-10 10:15:00 +01:00
45d4c0bf66
add occ command to update UUIDs (incomplete)
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2022-02-10 10:14:59 +01:00
2e869fd215
Merge pull request #29523 from nextcloud/fix/support-ldap-long-dns
2021-12-09 17:18:43 +01:00
df25a6de31
Make sure that hash function returns a string
...
The documentation says it can return false, and even if that is highly
unlikely for sha256, better safe than sorry.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2021-11-23 09:20:30 +01:00
d4c49a3a60
Put back length check to have a clear error
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2021-11-23 09:20:29 +01:00
31a503b387
Change column names to ldap_dn and ldap_dn_hash and add migration
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2021-11-23 09:19:50 +01:00
662e3240b0
Support LDAP dns longer than 255 characters
...
Adds an ldap_full_dn column to store the dn, and only store a sha256
hash in the ldap_dn which is shorter and can be indexed without
trouble.
Migration still needs to be implemented.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2021-11-23 09:19:49 +01:00
51ea7dc020
Make sure mapping cache is cleared when deleting a user
...
This avoids phantom remnants staying after user deletion
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2021-11-22 14:49:34 +01:00
215aef3cbd
Update php licenses
...
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com >
2021-06-04 22:02:41 +02:00
21ca5d4514
silence psalm false positive
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2021-01-13 11:54:29 +01:00
45e3261ad5
respect DB limits limit per statement and query
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2021-01-11 13:43:34 +01:00
8b64e92b92
Bump doctrine/dbal from 2.12.0 to 3.0.0
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2021-01-08 11:45:19 +01:00
dc89447f13
Revert "(LDAP) respect DB limits of arguments in an IN statement"
2021-01-08 10:44:32 +01:00
6eca8d6ae1
respect DB limits of arguments in a IN list
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2021-01-07 20:16:40 +01:00
2a054e6c04
Update the license headers for Nextcloud 20
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-08-24 14:54:25 +02:00
0ab6ee40de
be more clear about the condition
...
Co-authored-by: Christoph Wurst <ChristophWurst@users.noreply.github.com >
2020-06-16 10:55:51 +02:00
0cf57d1ed4
getXbyY can still return false, e.g. when using ldap write support
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2020-06-15 21:48:27 +02:00
4babdc082b
formatting
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2020-04-23 21:34:05 +02:00
32000dd1af
read records from DB for lists at once, not one by one.
...
Keep a runtime cache of dn-id-mapping
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2020-04-17 12:39:54 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-10 14:19:56 +02:00
36b3bc8148
Use php keywords in lowercase
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-09 14:04:56 +02:00
85e369cddb
Fix multiline comments
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-08 22:24:54 +02:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-03-31 14:52:54 +02:00
b80ebc9674
Use the short array syntax, everywhere
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-03-26 16:34:56 +01:00
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2019-12-05 15:38:45 +01:00
bb352fb667
Use the defined func()->count() instead of manual counting
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2018-11-08 15:44:45 +01:00
b458ed9c82
Properly escape column name in "createFunction" call
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2018-10-16 15:24:02 +02:00
8fe914f07e
LDAP backend to emit announce and revoke signals on mapping changes
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2018-04-05 12:38:39 +02:00
59c05d5447
move LDAP user attributes "sync" to background (except for ajax jobs)
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2017-11-09 11:10:56 +01:00
497ee3e3e6
Add repair steps
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2017-02-17 18:45:33 +01:00
Anna Larch
Côme Chilliet
Carl Schwan
Arthur Schiwon
provokateurin
Git'Fellow
Daniel Kesselberg
Joas Schilling
Andy Scherzinger
Carl Schwan
Côme Chilliet
John Molakvoæ
John Molakvoæ (skjnldsv)
Christoph Wurst
Roeland Jago Douma
Morris Jobke