e0ba4d71b6
chore: add missing Override attribute to OC
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:27 +02:00
ac9da6eaa0
perf: only load possible results in UserMountCache::getMountForPath
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-04-24 18:17:43 +02:00
41e6124dcc
perf: only load a single mount at a time when checking for share conflicts
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-04-24 18:17:43 +02:00
aedc57afe7
fix: add optional user param to IUserMountCache::removeMount
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-04-24 18:17:41 +02:00
0da86facc5
fix: clear in-memory cached mounts for user when adding/removing mounts
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-04-24 14:39:52 +02:00
8030a14382
fix: use proper index when deleting mounts
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-04-15 16:03:30 +02:00
e958fa0113
fix: PostgreSQL transaction aborts when caching user mounts
...
Signed-off-by: ailkiv <a.ilkiv.ye@gmail.com >
2026-03-09 10:02:40 +00:00
9884dec646
fix: fix updating cached mounts with multiple entries for root id
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-03-04 18:43:55 +01:00
7b6078875b
refactor: Run rector on lib/private
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:50:18 +01:00
51a4bc519b
fix: make getMountsForFileId work with sharding again
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-01-30 09:52:18 +01:00
4a077c3454
Merge pull request #57815 from nextcloud/feat/user-mount-cache-perf
2026-01-29 16:35:54 +01:00
668ad4faac
perf(UserMountCache): Invert condition so that we avoid some SQL queries
...
getStorageId creates some SQL queries, while the other queries don't, so
compare that last.
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-01-28 23:09:08 +01:00
f71f19c0c7
feat: optimize user mount cache
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2026-01-27 16:31:32 +01:00
d71c6796ca
feat: perform share mount validation on share instead of on mount
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-01-21 16:35:53 +01:00
3a9173015c
Merge pull request #57525 from nextcloud/carl/usermountcache-loop-optimization
...
perf(UserMountCache): Optimize loop
2026-01-16 10:50:27 +01:00
94dd919b88
perf(UserMountCache): Optimize loop
...
These loops since to be called around 60 000 times in one trace I saw.
So it makes sense to use the faster foreach construct.
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-01-13 18:37:51 +01:00
9dffca2f07
fix: improve handling of unavailable storages
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-01-09 17:53:52 +01:00
e3551e576c
feat: add api for authoritative mount providers to update the user mounts
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-01-09 17:53:48 +01:00
341fd348e6
fix(UserMountCache): Add back unique index for oc_mounts and use normal insert
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2025-12-15 12:26:23 +01:00
39e2e70084
feat(mounts): optimize load of mounts by filtering on database side
...
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2025-08-26 08:55:24 +02:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
6818aa9b12
feat(UserMountCache): Emit events for added, removed and updated mounts
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2025-05-19 13:54:51 +02:00
c3f06b370c
feat: add debug logging for adding/removing items from the user mounts cache
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-04-03 17:58:46 +02:00
a1681b0756
chore(db): Apply query prepared statements
...
Fix: psalm
fix: bad file
fix: bug
chore: add batch
chore: add batch
chore: add batch
fix: psalm
2024-10-17 20:30:47 +02:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-19 14:21:20 +02:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2024-08-25 19:34:58 +02:00
eb4fb994cf
fix: ensure array returned from getMountsForFileId is continious
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-08-02 17:22:33 +02:00
0931492ff0
fix: make usermountcache compatible with sharding
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-07-17 19:16:05 +02:00
dae7c159f7
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-24 13:11:22 +02:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-04-02 14:16:21 +02:00
951c330d39
Revert "don't perform an explicit setup when using the file cache"
2024-03-07 14:38:02 +01:00
b7088e7071
Merge pull request #32163 from nextcloud/file-cache-gc-no-full-setup
...
don't perform an explicit setup when using the file cache
2024-03-07 11:09:19 +01:00
4fba4cd14c
fix: fix user folder init
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-03-06 17:52:24 +01:00
51019fda7a
fix: clearify logic around getMountsForFileId filtering
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-03-06 10:54:00 +01:00
e33b32095e
Revert "Filter mounts for file id before trying to get user information"
...
This reverts commit 1e2cf820c8robin@icewind.nl >
2024-03-06 10:54:00 +01:00
9ea3f4ab8f
perf: use lazy user in UserMountCache for getting user for cached mount
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-03-06 10:53:55 +01:00
963721330f
only get the path for the users cached mount info when we use it
...
most of the time we shouldn't need it so we can save joining on the filecache
Signed-off-by: Robin Appelman <robin@icewind.nl >
2024-02-09 09:50:43 +01:00
b942850af9
optimize UserMountCache::registerStorage
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2023-11-16 16:21:59 +01:00
7441ce2b11
enh(IMountManager): Add method to get MountPoint from CachedMountInfo
...
Signed-off-by: Jonas <jonas@freesources.org >
2023-10-23 20:50:24 +02:00
ea06cf2f39
Convert isset ternary to null coalescing operator
...
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com >
2023-09-28 17:44:19 +03:30
e7cc7653b8
Refactors "strpos" calls in lib/private to improve code readability.
...
Signed-off-by: Faraz Samapoor <fsamapoor@gmail.com >
2023-05-15 15:17:19 +03:30
f5e2b0b22f
allow storing multiple mounts for the same rootid in the mount cache
...
currently `[$userId, $rootId]` is used as the unique key for storing mounts in the mount cache,
however there are cases where the same rootid is mounted in multiple places for a user which currently leads to not all of those mounts being added to the cache.
Previously this didn't matter as the mount cache was only used to list users with access to a specific file, so a user having access to the file multiple times didn' change anything.
With 24 the mount cache is used for more cases and multiple mounts for the same id becomes relevant.
While I think there isn't a real negative effect atm besides missing the optimized path we should ensure that the mounts are properly listed
Signed-off-by: Robin Appelman <robin@icewind.nl >
2023-04-28 15:08:08 +02:00
6b0cef6b9a
Add transaction around mass mounts operations
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2023-03-07 19:58:55 +00:00
91d5f6a826
more filesystem setup performance instrumentation
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2023-02-10 11:11:13 +01:00
10767d7779
fix updating cached mounts that didn't have their mount provider set previously
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2022-08-16 13:47:41 +02:00
368f83095d
Fix typos in lib/private subdirectory
...
Found via `codespell -q 3 -S l10n -L jus ./lib/private`
Signed-off-by: luz paz <luzpaz@github.com >
2022-07-27 08:52:17 -04:00
d5c23dbb9f
Move CappedMemoryCache to OCP
...
This is an helpful helper that should be used in more place than just
server and this is already the case with groupfodlers, deck, user_oidc
and more using it, so let's make it public
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2022-07-14 15:54:31 +02:00
ec6b83cc18
Add stricter psalm type for CappedMemoryCache
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2022-05-12 15:06:18 +02:00
49e62149d8
Make the binary operation order explicit
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2022-04-21 10:47:26 +02:00
765999f454
Merge pull request #31609 from nextcloud/fix/migrate-away-from-ilogger
...
Migrate from ILogger to LoggerInterface in lib/private
2022-03-29 09:39:38 +02:00
Ferdinand Thiessen
Robin Appelman
ailkiv
Carl Schwan
Benjamin Gaussorgues
Carl Schwan
Stephan Orbaugh
provokateurin
Git'Fellow
Daniel Kesselberg
Andy Scherzinger
Côme Chilliet
Joas Schilling
John Molakvoæ
Jonas
Hamid Dehnavi
Faraz Samapoor
Joas Schilling
luz paz
Carl Schwan
Côme Chilliet