e6b5f763a4
perf: Avoid sorting an already sorted array
...
Improve performance a bit as this is in the hotpath and take ~2s in
prod.
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-06-23 13:11:42 +02:00
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
fbf84e6473
chore: Replace MoveableMount usage with IMovableMount
...
The former is private API while the IMovableMount is public.
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-04-24 10:14:37 +02:00
83956e9f04
Merge pull request #58854 from nextcloud/jtr/refactor-View-getLocalFile
...
refactor(view): `getLocalFile` path handling
2026-03-12 10:05:19 +01:00
0a7420d0a4
chore(View): fixup for php-cs
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-03-10 21:40:44 -04:00
14e837ce11
refactor(View): add typing to getAbsolutePath and clarify contract
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-03-10 19:42:16 -04:00
af78da59bc
refactor(View): improve readability of getLocalFile and resolvePath
...
Signed-off-by: Josh <josh.t.richards@gmail.com >
2026-03-10 19:21:47 -04:00
b0240a43af
chore: Remove other useless assignment of 'path' key for FileInfo
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-03-10 15:12:06 +01:00
347d786a14
chore: Remove useless assignement
...
Because of the order we merged PRs, this line was not removed while the
value is not used anymore, let’s cleanup.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-03-10 15:09:54 +01:00
7fa44717e0
refactor(share): Remove some deprecated method usages
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-03-10 11:39:57 +01:00
8aedcb4a82
Merge pull request #58652 from nextcloud/automated/noid/rector-changes
...
Apply rector changes
2026-03-05 16:03:50 +01:00
8431abff32
fix: check source and target when emitting copy event
...
Signed-off-by: Salvatore Martire <4652631+salmart-dev@users.noreply.github.com >
2026-03-02 13:15:11 +01:00
663018455e
refactor: Apply rector changes
...
Signed-off-by: GitHub <noreply@github.com >
2026-03-01 14:43:11 +00:00
5f4a5d8c67
refactor(Files): Remove deprecated streamCopy method
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-02-17 06:43:16 +01:00
9741f5f17d
perf: Allow filtering the directory content by mimetype
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-02-12 00:35:48 +01:00
6c9418880f
Merge pull request #57757 from nextcloud/getowner-no-mountpoints
...
fix: don't include the mountpoints when getting fileinfo for getOwner
2026-02-06 17:22:51 +01:00
c801d63e5a
fix: don't include the mountpoints when getting fileinfo for getOwner
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2026-02-06 15:19:30 +01:00
3979c493f9
refactor: Apply second batch of comments
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:52:51 +01:00
7b6078875b
refactor: Run rector on lib/private
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:50:18 +01:00
7f71b46942
Merge pull request #57882 from nextcloud/useStrictComparisonOperator
2026-01-29 09:20:18 +01:00
080335009b
refactor: use strict comparison operator
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com >
2026-01-28 21:11:47 +01:00
d7fa94b90b
fix(View): Handle ICacheEntry returned by FileInfo->getData()
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-01-28 15:33:46 +01:00
27339601f6
perf(View): Optimize getDirectoryContent hot-loop
...
Signed-off-by: Carl Schwan <carlschwan@kde.org >
2026-01-14 18:03:51 +01:00
cc7655136c
refactor(share): Remove code related to science mesh integration
...
The app was not updated for the past 2 years.
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-12-03 14:11:58 +01:00
f453411d59
fix: Log missing nodes of shares at debug level
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-12-02 09:33:07 +01:00
8d64e076ee
fix: Fix orphan shares blocking moving other shares
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-12-01 09:43:39 +01:00
73c6b17fae
fix(View): Normalize path in getAbsolutePath
...
This allow to match files more consistently in HookConnector::getNodeForPath
Signed-off-by: Louis Chmn <louis@chmn.me >
2025-11-25 19:30:53 +01:00
f450cda3aa
chore: Explicitely mark \OC\Files\View as internal
...
It's in OC and should not be used at all. Marking it as internal will
at least prevent new code to use it.
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-10-06 15:49:55 +02:00
5987584b90
perf: use more optimized node-by-id logic in View::getPath
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-08-13 19:42:42 +02:00
c952570e67
fix(node): emit hooks on Node::copy()
...
When calling `Files\Node\Node::copy()`, `Files\View::copy()` gets called,
but `Files\View::fakeRoot` is empty so the hooks are not emitted if no
path is given to `Files\View::shouldEmitHooks()`.
This results in node-related events like `NodeCopiedEvent` not being
fired when copying files via `Files\Node\Node::copy()`.
`Files\View::shouldEmitHooks()` is given a path as parameter in almost
all places except when called from the `copy()` function. This commit
changes it and passes the copy target path.
Fixes : nextcloud/collectives#1756
Signed-off-by: Jonas <jonas@freesources.org >
2025-05-27 12:14:14 +02:00
01db539d0a
chore: move streamCopy implementation from OC_Helper to OCP\Files
...
The function was already there but called the legacy version.
So moved the implementation and migrated all usages of it.
Sadly the interface was slightly different so adjusted it to be
compatible with both legacy and the OCP one.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-05-16 13:03:05 +02:00
cd75876c1e
fix: create mountpoint folder even if the user has a quota of 0
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-05-08 15:15:36 +02:00
c1dbc27fd6
fix: don't construct storage when checking if a sub-mount is applicable
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-04-08 18:21:41 +02:00
3391279068
fix: No IFactory in constructor
...
Signed-off-by: Marcel Müller <marcel-mueller@gmx.de >
2025-03-05 11:04:55 +01:00
0522b0373e
fix(files): Don't do session related work in the constructor of the View
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2025-03-05 09:06:16 +01:00
9e1ae74a1c
fix: make locked exception path relative to the view
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-02-11 14:38:27 +01:00
b48ee2e924
fix: Harden files scanner for invalid null access
...
Co-authored-by: Ferdinand Thiessen <opensource@fthiessen.de >
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com >
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-01-28 20:08:46 +01:00
757076af29
fix: explicitly ignore nested mounts when transfering ownership
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-01-06 14:45:35 +01:00
d6418fcd99
fix: translate mount move error messages
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-01-03 15:36:38 +01:00
16d0363937
fix: improve checks for moving shares/storages into other mounts
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-01-03 15:36:32 +01:00
4bc0b58c59
fix(View): Catch exceptions when executing mkdir for non-existent parents
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-12-16 16:00:35 +01:00
199b0bd4d9
fix(files): Correctly copy the cache information on copy operations
...
Needed to copy the `encrypted` flag of encrypted files when those files are two level down in a moved folder.
Signed-off-by: Louis Chemineau <louis@chmn.me >
2024-12-03 17:04:44 +01:00
dc13f9cc1e
fix(Files): Handle getOwner() returning false
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-17 10:10:50 +02:00
8ca6fcace7
fix(Storage): Document getOwner() can return false
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-17 10:10:50 +02:00
0308001118
fix(files): Check if the target path is a descendant of the shared folder path
...
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com >
fix: tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com >
fix: fix tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com >
fix: add tests
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com >
fix: tests
2024-09-05 23:54:01 +02:00
09fef8f0ec
Merge pull request #47417 from nextcloud/fix/files/create-mountpoint-parents
2024-09-04 20:00:24 +02:00
bfb5835750
Merge pull request #47546 from nextcloud/fix/files-view-error-messages
...
fix: Adjust filename validation messages
2024-08-29 23:28:50 +02:00
08836696e2
fix: Allow read-only filename validation to allow reading files
...
Needed to read files with the "Windows compatibility" feature.
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-08-28 17:22:20 +02:00
81c6c24cd5
fix: Adjust filename validation messages
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-08-27 23:12:24 +02:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2024-08-25 19:34:58 +02:00
Carl Schwan
Côme Chilliet
Carl Schwan
Josh
Côme Chilliet
Salvatore Martire
nextcloud-command
provokateurin
Robin Appelman
Carl Schwan
Benjamin Gaussorgues
Git'Fellow
Louis Chmn
Jonas
Ferdinand Thiessen
Marcel Müller
Joas Schilling
Kate
Andy Scherzinger
Daniel Kesselberg