df2368896f
docs(taskprocessing): document lockTask semantic change
...
Per review feedback: note in the lockTask docblock that the guard changed from
`status != RUNNING` to `status = SCHEDULED`, and that callers must now treat a
0 return as "the task is no longer claimable" rather than assuming success.
Signed-off-by: Yoan Bozhilov <bygadd@gmail.com >
Assisted-by: Claude Code:claude-opus-4-8
2026-06-15 16:37:34 +02:00
022531b997
fix(taskprocessing): guard lockTask on scheduled, record started_at, Oracle fallback
...
Address review feedback (@marcelklehr, Copilot):
- lockTask claims only SCHEDULED tasks (was status != RUNNING) and stamps
started_at in the same atomic UPDATE, so a finished task cannot be re-claimed
and the external-provider claim path records started_at as well.
- claimWithBoundedRetry re-reads after lockTask instead of a follow-up UPDATE.
- Oracle joins SQLite on the bounded-retry fallback: Oracle cannot combine a
row-limiting clause with FOR UPDATE (ORA-02014), which failed the claim tests
on Oracle CI.
- Reword the worker docblock/comments to "prefer oldest available" (parallel
SKIP LOCKED does not guarantee a strict global order).
- Add a regression test that lockTask does not resurrect a finished task.
Signed-off-by: Yoan Bozhilov <bygadd@gmail.com >
Assisted-by: Claude Code:claude-opus-4-8
2026-06-15 16:37:34 +02:00
66826df860
fix: Address review comments
...
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com >
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2026-06-15 16:37:34 +02:00
0799454a1f
fix(taskprocessing): claim tasks atomically with SKIP LOCKED + composite index
...
Replace the worker retry/ignore-list claim-loop with a single atomic
SELECT ... FOR UPDATE SKIP LOCKED claim (SQLite bounded-retry fallback),
preserving the no-duplicate guarantee while removing the thundering-herd
contention that throttled backlog draining. Add a (status,type,last_updated)
index via the table-creating migration + db:add-missing-indices listener.
Signed-off-by: Yoan Bozhilov <bygadd@gmail.com >
Assisted-by: Claude Code:claude-opus-4-8
2026-06-15 16:37:34 +02:00
ddf914231b
feat(task-streaming): add preferStreaming boolean attribute to taskprocessing tasks. pass it to ISynchronousProgressiveProvider::process
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2026-06-10 14:52:56 +02:00
0d90f4272a
chore: Remove types from const properties
...
Support was added in PHP 8.3 and we need to support 8.2
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-02 09:46:16 +02:00
b44f6a2957
fix: Remove static vars in TaskProcessing, TextProcessing, TextToImage
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-02 09:46:16 +02:00
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
e0ba4d71b6
chore: add missing Override attribute to OC
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:27 +02:00
f573285040
feat(taskprocessing): Add queue_stats API endpoint for external autoscalers
...
Signed-off-by: Oleksander Piskun <oleksandr2088@icloud.com >
2026-03-30 12:03:19 +00:00
b4f7fe2cb6
feat(taskprocessing): add a boolean 'includeWatermark' to taskprocessing tasks and pass it to ISynchronousWatermarkingProvider::process
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2025-11-27 11:32:08 +01:00
d04d575ed3
Merge branch 'master' into feat/taskprocessing/user-facing-error-message
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2025-10-30 10:13:39 +01:00
6a1501a7d6
fix: address review comments
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2025-10-20 15:59:25 +02:00
044e92bf4e
feat(TaskProcessing): Introduce ITriggerableProvider
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
# Conflicts:
# lib/private/TaskProcessing/Db/TaskMapper.php
2025-10-20 15:59:25 +02:00
7373f11af6
feat(TaskProcessing): user-facing error messages
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2025-10-14 16:53:41 +02:00
16da8bbc8a
fix(TaskProcessingApiController): Implement getNextScheduledTasks for next_batch endpoint
...
in order to avoid hitting the DB with multiple 1 row requests
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2025-10-14 11:50:29 +02:00
e2c65b2493
feat(taskprocessing): fix mistake
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2025-08-07 15:12:22 +02:00
222b19b805
feat(taskprocessing): rename cleanup column to allow_cleanup
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2025-08-07 15:12:22 +02:00
19801f7ec4
feat(taskprocessing): move cleanup method to private taskprocessing manager, use it in the cleanup bg job and implement a cleanup command
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2025-08-07 15:12:21 +02:00
8c52b6c0fe
feat(taskprocessing): add cleanup flag to tasks to decide if they should be cleaned up automatically
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2025-08-07 15:12:21 +02:00
2c65d0c0d1
fix(QBMapper): Fix findEntities() return type to be list<T>
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-11-06 16:31:39 +01:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-19 14:21:20 +02:00
c004f5376f
fix(taskprocessing): build autoloader files and fix psalm issue
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2024-07-23 17:12:38 +02:00
df11aa9efc
feat(taskprocessing): add appId filter to taskprocessing occ commands
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2024-07-23 17:12:38 +02:00
c120a64ba2
feat(taskprocessing): add occ commands to list tasks and compute stats
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2024-07-23 17:12:38 +02:00
df086a8c20
feat(taskprocessing): add start, stop and schedule time to tasks
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2024-07-23 17:12:38 +02:00
fffc784769
feat(taskprocessing): add support for webhooks (http or AppAPI) in the task processing API
...
Signed-off-by: Julien Veyssier <julien-nc@posteo.net >
2024-07-22 11:34:29 +02:00
eeb6ddb176
fix(db): Deprecate IExpressionBuilder::or() and IExpressionBuilder::and() without parameters
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2024-07-19 11:21:16 +02:00
f5ff8136ac
feat(TaskProcessingApi): Add endpoint for getting the next task
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-07-01 17:11:12 +02:00
dae7c159f7
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-24 13:11:22 +02:00
6c4992de54
fix: expose lastUpdated in OCS API
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2024-05-15 09:30:05 +02:00
a8afa7f23d
fix(OCS-API): Add endpoint to list user tasks
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2024-05-14 11:38:41 +02:00
f2ab6cb0a9
fix: fix psalm issues
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2024-05-14 11:38:41 +02:00
4a3b9b826e
refactor: identifier is now customId/custom_id
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2024-05-14 11:38:41 +02:00
2c878099f1
fix: address review comments
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2024-05-14 11:38:40 +02:00
b150d779f3
refactor: rename getTaskType to getTaskTypeId
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2024-05-14 11:38:40 +02:00
7a947980db
fix: Fix psalm issues
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2024-05-14 11:38:39 +02:00
4b2acee64b
test: Add OldTasksShouldBeCleanedUp test
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2024-05-14 11:38:39 +02:00
00894e2420
feat: first pass at TaskProcessing API
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2024-05-14 11:38:39 +02:00
Yoan Bozhilov
Marcel Klehr
Julien Veyssier
Côme Chilliet
Ferdinand Thiessen
Oleksander Piskun
provokateurin
Joas Schilling
Andy Scherzinger