80ec3b1b0a
fix(MailPlugin): Stop applying the offset twice and the limit per wide/exact
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-06-01 14:24:01 +02:00
5c21fb5062
perf(MailPlugin): Optimize checking group memberships
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-06-01 14:22:45 +02:00
d92aac8f7d
fix(MailPlugin): Use correct type for exact id match
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2026-06-01 14:22:45 +02:00
e5b1799079
chore: add missing Override attribute to test files
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2026-04-28 21:29:28 +02:00
663018455e
refactor: Apply rector changes
...
Signed-off-by: GitHub <noreply@github.com >
2026-03-01 14:43:11 +00:00
c96ece0bcb
refactor: Add more typing
...
- repairs job
- database
- redis
And remove Helpertest which was unused outside of some tests.
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:55:39 +01:00
503a65ddd0
refactor: Run rector
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-11-18 17:45:54 +01:00
c40fcba5a4
fix: Fix user collaborators returned when searching for mail collaborators
...
The MailPlugin collaborator returned results for both user and mail
collaborators, but it was registered only for mail collaborators. While
it might make sense to move the user results to the UserPlugin instead
that change would be more complex and riskier, so for now the MailPlugin
is now registered for both user and mail collaborators and the results
are limited only to the registered type.
As the plugins are registered only with their class and then resolved
when needed using dependency injection it is not possible (as far as I
know) to provide an explicit parameter in the constructor to
differentiate whether the MailPlugin should return user or mail
collaborators. To overcome this two subclasses are introduced,
MailByMailPlugin and UserByMailPlugin, which just hardcode in their
constructor the collaborator type that their parent MailPlugin must use,
and those subclasses are the ones registered instead of the MailPlugin
(which still contains all the logic).
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com >
2025-11-11 01:20:17 +01:00
2c841b2337
test: Rename data providers to match the name of their tests
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com >
2025-11-11 00:54:39 +01:00
74fd144003
test: Replace magic value with named constant of share type
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com >
2025-11-11 00:54:39 +01:00
a0e8d943f1
test: Rename parameters to show that they are expected values
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com >
2025-11-11 00:54:38 +01:00
45f2683a73
test: Fix parameter documentation
...
Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com >
2025-11-11 00:54:38 +01:00
83a691709c
refactor: use IEmailValidator.isValid instead of IMailer.validateEmailAddress
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2025-10-04 21:54:22 +02:00
66eb021ece
refactor: remove duplicated types and add return types
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2025-07-23 15:59:26 +02:00
aa15f9d16d
chore: run rector
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-07-01 22:45:52 +02:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
29e39c0a2e
chore: run rector on tests
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2025-06-12 18:31:58 +02:00
3e7db013c1
test: Fix non-static data providers
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2025-05-15 08:25:01 +02:00
46f531adec
test: Adapt tests to properly use valid email addresses
...
Signed-off-by: Julius Knorr <jus@bitgrid.net >
2025-03-26 11:51:52 +01:00
49dd79eabb
refactor: Add void return type to PHPUnit test methods
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2024-09-15 22:32:31 +02:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2024-08-25 19:34:58 +02:00
1f7e2ba599
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-13 17:41:36 +02:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2023-11-23 10:36:13 +01:00
1626a56dda
adjusts tests for CloudIdManager
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2022-08-31 15:47:00 +02:00
7ecb65f725
Add check before sending email that email address is valid
...
Signed-off-by: Carl Schwan <carl@carlschwan.eu >
2022-01-11 20:59:44 +01:00
2fe8042fff
Add integration tests for email completion
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2021-12-08 09:08:54 +01:00
7179002600
Allow to get a local cloud id without going through the contacts manager
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2021-07-14 16:08:05 +02:00
236aa194e2
Restrict autocompletion also based on the phonebook known users
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2021-03-10 17:19:55 +01:00
131fcac91e
Show unique displayname context in the sharing input
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2020-12-14 11:14:59 +01:00
16a78f535a
set the display name of federated sharees from addressbook
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2020-11-24 11:30:11 +01:00
d9015a8c94
Format code to a single space around binary operators
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-10-05 20:25:24 +02:00
234b510652
Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2020-08-12 13:55:19 +02:00
89ed2c37bf
Update share type constant usage
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2020-06-24 16:49:16 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-10 14:19:56 +02:00
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-10 10:35:09 +02:00
afbd9c4e6e
Unify function spacing to PSR2 recommendation
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-09 13:54:22 +02:00
41b5e5923a
Use exactly one empty line after the namespace declaration
...
For PSR2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-09 11:48:10 +02:00
2fbad1ed72
Fix (array) indent style to always use one tab
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-09 10:16:08 +02:00
3a7cf40aaa
Mode to modern phpunit
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-11-27 15:27:18 +01:00
c007ca624f
Make phpunit8 compatible
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-11-27 13:34:41 +01:00
a0d759b324
Add uuid/name entry to Remote/MailPlugin tests
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2018-10-30 10:19:36 +01:00
882096653e
Fix calculation if there are more results
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2018-03-08 16:22:16 +01:00
3d7ae4aa97
Add tests for finding own email and user results pagination
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2018-03-08 13:26:26 +01:00
b30e035e25
Better result handling of email search
...
1. Local users should not be returned when searching for empty string
2. The limit of the response should be respected
Signed-off-by: Joas Schilling <coding@schilljs.com >
2018-02-20 17:38:32 +01:00
e8a4f83000
Fix and tests for MailPlugin
...
Signed-off-by: Tobia De Koninck <tobia@ledfan.be >
2017-12-16 08:46:03 +01:00
3db3e65121
add tests for Lookup Plugin
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2017-09-26 23:10:25 +02:00
3d1d03a511
split off getEmail tests
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2017-09-26 23:10:24 +02:00
provokateurin
Ferdinand Thiessen
nextcloud-command
Carl Schwan
Daniel Calviño Sánchez
Daniel Kesselberg
Robin Appelman
Joas Schilling
Julius Knorr
Christoph Wurst
Andy Scherzinger
Carl Schwan
Arthur Schiwon
Morris Jobke
Roeland Jago Douma
Tobia De Koninck