87 Commits

Author SHA1 Message Date
Joas Schilling
5612714ec3 fix(maintenance): Show a success message on data-fingerprint command
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-12-02 08:19:15 +00:00
Hamza Mahjoubi
ae2417af01 fix: optimise getWrongShareOwnership query
Signed-off-by: Hamza Mahjoubi <hamzamahjoubi221@gmail.com>
2024-08-28 14:16:55 +00:00
Joas Schilling
aa5f037af7 chore: apply changes from Nextcloud coding standards 1.1.1
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
2023-11-23 10:36:13 +01:00
Simon L
3f6caa46f3 document error
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-11-17 15:22:53 +01:00
Joas Schilling
6f39d82031 fix(install): Make installing more verbose
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-11-03 15:44:46 +01:00
Faraz Samapoor
d60bedfeee Moves single constructor parameters to new lines.
Based on:
https://github.com/nextcloud/server/pull/38764#discussion_r1227630895

Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 12:55:22 +02:00
Faraz Samapoor
ec63264153 Uses PHP8's constructor property promotion in core/Command/Maintenance classes.
Signed-off-by: Faraz Samapoor <fsa@adlas.at>
2023-06-19 12:55:22 +02:00
Robin Appelman
cd3e7fd1b0 list supported databases when provided db isn't supported
Signed-off-by: Robin Appelman <robin@icewind.nl>
2023-05-04 14:43:48 +02:00
Joas Schilling
e0251ea24e Fail the repair command when an error happened
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-02-23 16:57:52 +01:00
Côme Chilliet
3f231d68d7 Merge pull request #36271 from nextcloud/fix/fix-codestyle
Fix codestyle using codesniffer
2023-01-20 15:26:17 +01:00
Côme Chilliet
f5c361cf44 composer run cs:fix
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2023-01-20 11:45:08 +01:00
Christoph Wurst
a8bad3a98f fix(occ): Fix comment formatting of maintenance:repair command
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-20 10:00:41 +01:00
Christoph Wurst
2e66acfab8 fix(PHP8.2): Fix deprecated string interpolation syntax
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2023-01-19 13:10:02 +01:00
Alex Harpin
644df591b1 Rename canInstallExists method and add new method for removal
Rename canInstallExists to shouldRemoveCanInstallFile to cover removal of this file for non-git channels and logging any failure to remove it.

Add new method to detect if this file exists during web based installation.

Signed-off-by: Alex Harpin <development@landsofshadow.co.uk>
2023-01-10 11:59:06 +00:00
Alex Harpin
d5b52ddd21 Log a warning to CLI install command if CAN_INSTALL is not removed
Log a warning for the CLI install command if the CAN_INSTALL file still exists at the end of the installation.  This matches the warning logged by the web installer.

Signed-off-by: Alex Harpin <development@landsofshadow.co.uk>
2023-01-10 11:59:06 +00:00
Robin Appelman
7dc8e6a014 fix repairing non user shares when repairing all shares
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-08 17:13:52 +01:00
Robin Appelman
b66779711f split repairing into two stages to prevent long open transaction
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-08 17:13:44 +01:00
Robin Appelman
8012c85d3e update shares directly in db
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-08 17:13:41 +01:00
Vincent Petry
1be1c23c05 More verbose output for repair share ownership cmd
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
2022-11-08 17:13:37 +01:00
Robin Appelman
3d68a526e7 move share owner repair to occ command
Signed-off-by: Robin Appelman <robin@icewind.nl>
2022-11-08 17:13:33 +01:00
Louis
e4d3344076 Merge pull request #32859 from nextcloud/bug/31973/array-key-might-be-empty
Fix Uninitialized string offset 0 at GenerateMimetypeFileBuilder.php#39
2022-10-11 11:15:05 +02:00
Côme Chilliet
9a29025534 Parameter of RepairAdvanceEvent is actually an increment, not a step id
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:26:31 +02:00
Côme Chilliet
652ab6da3f Surround cli output with appropriate xml tags
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:18:53 +02:00
Côme Chilliet
a2a7150d6d Migrate Repair events to OCP\EventDispatcher\Event
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:15:48 +02:00
Côme Chilliet
4f260dce6e Moving to string key for arguments of GenericEvent in Repair
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-08-25 16:13:46 +02:00
Carl Schwan
458c2fa297 Remove OCP\App and OCP\BackgroundJob
Both deprecated since NC 23

IAppManager is the replacement for OCP\App unfortunately it can't be
dependency injected in classes used by the installed otherwise the
database connection is initialised too early

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-08-01 09:46:40 +02:00
Daniel Kesselberg
6f3ab2fc9b Fix Uninitialized string offset 0 at GenerateMimetypeFileBuilder.php#39
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2022-06-28 15:45:41 +02:00
Carl Schwan
b70c6a128f Update core to PHP 7.4 standard
- Typed properties
- Port to LoggerInterface

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2022-05-20 22:18:06 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +02:00
Joas Schilling
df47445c01 Fix unit tests
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-04-27 14:34:32 +02:00
Robin Appelman
9135a42781 make repair errors more visible
Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-03-18 08:45:16 +01:00
Morris Jobke
d0ac76a77c Add more previous exceptions to database setup code
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-07 21:04:11 +01:00
Christoph Wurst
f1921364d6 Print an exception trace for setup exceptions
Right now any setup error will just result in the exception message
being printed. In some cases this doesn't give any insights into what
went wrong. This adds some dedicated logic to print the exception trace
and any previous exceptions to the CLI.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2021-01-07 20:11:25 +01:00
Christoph Wurst
d89a75be0b Update all license headers for Nextcloud 21
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +01:00
Christoph Wurst
2a054e6c04 Update the license headers for Nextcloud 20
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +02:00
Joas Schilling
b09620651c Don't use deprecated getIniWrapper() anymore
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-08-20 16:35:38 +02:00
Joas Schilling
ab21d69903 Add return value to all commands
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-06-26 14:54:51 +02:00
Joas Schilling
5f88380c44 Remove db prefix option from cli install command
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-05-26 14:10:39 +02:00
Joas Schilling
9c025134b3 Fix syntax
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-05-06 10:54:36 +02:00
Christoph Wurst
cb057829f7 Update license headers for 19
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-29 11:57:22 +02:00
Christoph Wurst
28f8eb5dba Add visibility to all constants
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 16:54:27 +02:00
Christoph Wurst
caff1023ea Format control structures, classes, methods and function
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
Christoph Wurst
afbd9c4e6e Unify function spacing to PSR2 recommendation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
Christoph Wurst
41b5e5923a Use exactly one empty line after the namespace declaration
For PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 11:48:10 +02:00
Joas Schilling
0317c5b5c8 Correctly append the port to the host so it's written to the config correctly
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-02-05 13:58:37 +01:00
Christoph Wurst
5bf3d1bb38 Update license headers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +01:00
Roeland Jago Douma
68748d4f85 Some php-cs fixes
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-22 20:52:10 +01:00
Xheni Myrtaj
d8707c6945 Add function parameter typehint
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
2019-05-29 23:16:06 +02:00
Xheni Myrtaj
d227f4d34c Do not fail integrity check if mimetype list is changed
Signed-off-by: Xheni Myrtaj <myrtajxheni@gmail.com>
2019-05-29 22:43:23 +02:00
Temtaime
887c208f23 Fix #15042 2019-04-18 15:28:00 +03:00