5492 Commits

Author SHA1 Message Date
Joas Schilling
c93d057233 fix(l10n): Fix language selection
Signed-off-by: Joas Schilling <coding@schilljs.com>
2026-01-15 07:46:42 +01:00
Joas Schilling
098fa0709b ci: Update testing certificates that expired after 10 years
Signed-off-by: Joas Schilling <coding@schilljs.com>
2025-08-25 17:33:32 +00:00
Maxence Lange
a8280bcada fix(federation): allows equal signs in federation id
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
2025-06-01 14:06:35 +02:00
Christoph Wurst
829ca3df55 fix(session): Only mark sessions of permanent tokens as app passwords
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2025-04-09 07:48:30 +02:00
Andy Scherzinger
7848ef4983 Merge pull request #51329 from nextcloud/backport/51130/stable28
[stable28] fix: Do not build encrypted password if there is none
2025-03-28 15:17:33 +01:00
Ferdinand Thiessen
d3802120ca fix(lookup-server): disable lookup server for non-global scale setups
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-12 11:48:08 +01:00
Ferdinand Thiessen
e7793a3ea9 fix(lookup-server): do not query data by default
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-03-12 10:01:52 +00:00
Julius Knorr
55846e332a fix: Do not build encrypted password if there is none
Signed-off-by: Julius Knorr <jus@bitgrid.net>
2025-03-07 15:53:07 +00:00
provokateurin
62fb78acc9 refactor(TempManager): Simplify and unify implementations and remove legacy behavior
Signed-off-by: provokateurin <kate@provokateurin.de>
2025-03-04 07:51:30 +01:00
Robin Appelman
f1581f3767 chore: fix tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 15:42:14 +01:00
Robin Appelman
f344c69b82 fix: improve checks for moving shares/storages into other mounts
Signed-off-by: Robin Appelman <robin@icewind.nl>
2025-02-05 15:07:22 +01:00
Ferdinand Thiessen
043841a54d fix(sharing): Move permission validation to share manager
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2025-01-31 19:14:45 +01:00
Côme Chilliet
4c10a793d9 chore: Remove syntax incompatible with PHP 8.0
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-20 06:15:32 +00:00
Côme Chilliet
3f695c6209 fix: Use getRelativePath method to check if node is inside folder
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-20 06:15:32 +00:00
Côme Chilliet
30fdc6c114 fix: Fix promotion of reshares from subsubfolders
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-20 06:15:32 +00:00
Côme Chilliet
8bc34e99f6 fix(tests): Fix share tests to test new reshare promotion system
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-20 06:15:32 +00:00
Côme Chilliet
257b516f4e fix: Tidy up code for reshare deletion
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-20 06:15:32 +00:00
Luka Trovic
7a3a779426 fix: delete re-shares when deleting the parent share
Note: Removed part about fix command from original PR

Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
(cherry picked from commit 42181c2f49)
2024-12-20 06:15:32 +00:00
Côme Chilliet
b061273135 fix(tests): Adapt ManagerTest to change in Exception class used
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-12-12 20:14:19 +00:00
Robin Appelman
c81392cec7 fix: fix mimetype not being updated when changing file extention on object store
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-12-11 09:02:00 +00:00
Christoph Wurst
a925e0b2b0 fix(migration): Decrypt ownCloud secrets v2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2024-11-28 09:45:30 +01:00
georglauterbach
d4ee439d37 fix: do not query CNAME if A succeeded already
Signed-off-by: georglauterbach <44545919+georglauterbach@users.noreply.github.com>
2024-11-28 08:05:44 +01:00
Richard Steinmetz
1b0926ee76 Merge pull request #49096 from nextcloud/backport/48933/stable28
[stable28] Clear pending two factor tokens also from configuration
2024-11-13 10:46:59 +01:00
Josh Richards
0f27494a68 Clean-up some remaining readdir calls with undesirable false evaluation potential
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>

[skip ci]
2024-11-12 13:08:18 +00:00
Daniel Calviño Sánchez
b39c5d8393 fix: Handle exception when clearing previously removed two factor tokens
If a token was already removed from the database but not from the
configuration clearing the tokens will try to remove it again from the
database, which caused a DoesNotExistException to be thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 10:48:33 +00:00
Daniel Calviño Sánchez
56fc4341fb fix: Clear pending two factor tokens also from configuration
Otherwise as the tokens were removed from the database but not from the
configuration the next time that the tokens were cleared the previous
tokens were still got from the configuration, and trying to remove them
again from the database ended in a DoesNotExistException being thrown.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
2024-11-05 10:48:33 +00:00
Louis
64583a0f86 Merge pull request #48985 from nextcloud/backport/47986/stable28
[stable28] perf(ObjectStoreStorage): Improve (slow) move on same object bucket
2024-10-31 15:57:22 +01:00
Côme Chilliet
ab611a279a fix(tests): Fix most obvious errors in ObjectStore tests
Some are still failing

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-31 14:41:19 +01:00
Christoph Fiehe
dec5a5fe9b perf(ObjectStoreStorage): Improve (slow) move on same object bucket
This commit fixes the issue #47856. When you upload a file into a group folder and when you use a single S3 bucket as primary storage, the final move operation hangs for a long time. In the background, Nextcloud initiates a copy-delete sequence from the bucket into the bucket, with causes a lot unnecessary overhead. Nextcloud thinks that the file must be imported to another storage and does not recognize that everything is done on the same object bucket. In that case, the import step can be completely skipped, which saves time, network bandwidth and reduces the load on the object storage.

The behavior improves a lot with https://github.com/nextcloud/server/pull/46013. However, there are still some put messages that are being sent to the object storage when you use an object storage as primary storage and upload files into a group folder.

Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com>
Signed-off-by: Christoph Fiehe <c.fiehe@eurodata.de>
2024-10-29 15:53:48 +00:00
Robin Appelman
accf707659 test: add test for nested jail cross-storage move
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-10-29 10:36:33 +00:00
yemkareems
a3abe2c4e1 fix: crypto added manually as expected
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 18:48:14 +05:30
yemkareems
e253479d83 fix: crypto type made not nullable and tests run using ICrypto
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 12:34:36 +00:00
yemkareems
be581d7ce8 fix: encrypt and store password, decrypt and retrieve the same
Signed-off-by: yemkareems <yemkareems@gmail.com>
2024-10-28 12:34:36 +00:00
Joas Schilling
24f8fd333e Merge pull request #48762 from nextcloud/backport/48539/stable28
[stable28] fix(message): Fix logic of Mail test
2024-10-17 21:34:24 +02:00
Ferdinand Thiessen
86ed7aada1 Merge pull request #48739 from nextcloud/backport/48673/stable28
[stable28] fix(share): Return empty string if no label is set
2024-10-17 19:49:26 +02:00
Ferdinand Thiessen
788233c3d7 fix(share): Return empty string if no label is set
* Resolves: https://github.com/nextcloud/server/issues/48629

While the database supports NULL, the typing has always said it only returns *string*.
So to not break any apps that might trust the typings we should return `''` if the database is set to `NULL`.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-17 18:47:56 +02:00
provokateurin
c42ec8d0d2 fix(UserTrait): Fix backend initialization
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-10-17 17:59:20 +02:00
Joas Schilling
d518cedafd fix(message): Fix logic of Mail test
Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-10-17 12:44:43 +00:00
Ferdinand Thiessen
229deb0497 fix: Make user removal more resilient
Currently there is a problem if an exception is thrown in `User::delete`,
because at that point the user is already removed from the backend,
but not all data is deleted.

There is no way to recover from this state, as the user is gone no information is available anymore.
This means the data is still available on the server but can not removed by any API anymore.

The solution here is to first set a flag and backup the user home,
this can be used to recover failed user deletions in a way the delete can be re-tried.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
2024-10-15 16:43:19 +02:00
Louis Chemineau
2a27a4129c fix(tests): UserManager constructor arguments
After https://github.com/nextcloud/server/pull/48283

Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-10-08 18:14:26 +02:00
Côme Chilliet
ec0ff3d5dd fix(tests): Fix Folder tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2024-10-08 18:14:26 +02:00
Robin Appelman
b8464efa69 test: put parent items into cache in tests
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-10-08 18:14:26 +02:00
Robin Appelman
f1df40f718 test: fix incorrect ltrim usage in test
Signed-off-by: Robin Appelman <robin@icewind.nl>
2024-10-08 18:14:26 +02:00
Richard Steinmetz
8752c3de79 fix: gracefully parse non-standard trusted certificates
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
2024-09-30 09:17:25 +02:00
Louis Chemineau
483eaa7e72 fix(users): Don't crash if disabled user is missing in the database
Signed-off-by: Louis Chemineau <louis@chmn.me>
2024-09-23 16:59:58 +02:00
Robin Appelman
6baa60a5dd Merge pull request #48099 from nextcloud/backport/46140/stable28
[stable28] fix(config): Add missing handling for `envCache` in `getKeys()`
2024-09-23 07:27:44 +02:00
Josh Richards
cf752657ee fix(config): add envCache tests for getKeys()
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
2024-09-16 14:56:12 +00:00
provokateurin
1b5a56df48 fix(Entity): Fix magic setter call for custom strong typed setters
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-16 13:52:41 +00:00
Joas Schilling
25d70bf77f fix(config): Throw PreconditionException always when it didn't match
Previously even when the precondition did not match, the call "passed"
when the after value was the expected one. This however can lead to
race conditions, duplicate code excutions and other things.

Signed-off-by: Joas Schilling <coding@schilljs.com>
2024-09-13 11:41:53 +00:00
provokateurin
e77ac5c8e1 fix(files): Create non-existent parents of mountpoints
Signed-off-by: provokateurin <kate@provokateurin.de>
2024-09-04 18:01:36 +00:00