averello/nextcloud-server-mirror
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-03-04 18:28:08 +01:00
Code Issues Packages Projects Releases Wiki Activity
59,544 Commits 712 Branches 1,186 Tags
1f42657bb9ea76353fbc02ee100cff5755b6384d
Commit Graph

98 Commits

Author SHA1 Message Date
Julius Härtl
b235a854d3 Always list the class of an object first 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-08-05 17:36:15 +02:00
Julius Härtl
950de74d1d Set a maximum level of encoding nested arguments of exception traces 
This will make sure that nested objects or arrays do not cause exceeding
the maximum nesting level of functions when parsing arguments of an
exception trace

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-08-05 17:35:52 +02:00
Lukas Reschke
b3ddc09895 Sanitize more functions from the encryption app 
Signed-off-by: Lukas Reschke <lukas@statuscode.ch>
 2021-07-21 11:18:35 +02:00
Daniel Kesselberg
74fa8f3f84 Mask password for Redis and RedisCluster on connection failure 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2021-07-19 19:52:25 +02:00
Chih-Hsuan Yen
16c4991db6 Correctly skip suppressed errors in PHP 8.0 
Applies the suggested transformation mentioned in
https://www.php.net/manual/en/migration80.incompatible.php,

> The @ operator will no longer silence fatal errors (E_ERROR,
> E_CORE_ERROR, E_COMPILE_ERROR, E_USER_ERROR, E_RECOVERABLE_ERROR,
> E_PARSE). Error handlers that expect error_reporting to be 0 when
> @ is used, should be adjusted to use a mask check instead

The new code still works on PHP 7, as error_reporting() already
returns 0 when diagnostics are suppressed.

This fixes https://github.com/nextcloud/server/issues/25807 in PHP 8.0.
For PHP 7.x, https://github.com/nextcloud/server/pull/22243 suppresses
the E_NOTICE message from the second session_start() call with the error
suppression operator @, and thus those E_NOTICE messages are still
logged in PHP 8.0.

See also https://github.com/nextcloud/server/issues/25806

Signed-off-by: Chih-Hsuan Yen <yan12125@gmail.com>
 2021-07-13 13:23:03 +08:00
Gary Kim
b78f3a57d1 Migrate HintException to OCP 
Signed-off-by: Gary Kim <gary@garykim.dev>
 2021-06-30 15:28:02 -04:00
Pytal
9ed379da22 Merge pull request #27635 from nextcloud/fix/datetime-constants 
Fix usage of DateTime constants
 2021-06-23 09:56:28 -07:00
Christoph Wurst
770881d5d6 Move DateTime::ATOM to DateTimeInterface::ATOM 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-06-23 15:28:07 +02:00
blizzz
ee7a484284 Merge pull request #26346 from J0WI/clean-auth-regex 
Cleaner removePassword regex
 2021-06-23 11:20:19 +02:00
Julius Härtl
e536b7bbcc Move exception logging to separate field 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2021-06-10 07:35:51 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
Joas Schilling
21ed3419f3 Log deprecation only as debug 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-04-26 16:19:03 +02:00
Joas Schilling
8d9e5e0b91 Respect the error level when logging 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-04-26 14:18:18 +02:00
J0WI
5f468c0248 Cleaner removePassword regex 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2021-03-27 18:42:58 +01:00
Christoph Wurst
d45692ee96 Migrate custom loggers to PSR 
This will help phase out the deprecated ILogger interface.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2021-02-11 16:16:34 +01:00
Joas Schilling
847aa08ebd Don't log keys on checkSignature 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2021-01-18 16:09:06 +01:00
Morris Jobke
59ae722087 Fix warning in PHP 8 about optional parameter before mandatory one 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2021-01-07 12:43:56 +01:00
Roeland Jago Douma
179de95f81 Avoid huge exception argument logging 
In some cases it might happen that you have an argument that deep down
somewhere has an array with a lot of entries (think thousands). Now
before we would just happily print them all. Which would fill the log.

Now it will just print the first 5. And add a line that there are N
more.

If you are on debug level we will still print them all.

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2020-12-29 10:50:53 +01:00
Christoph Wurst
d89a75be0b Update all license headers for Nextcloud 21 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-12-16 18:48:22 +01:00
Vincent Petry
9b3361ce87 Don't log params of imagecreatefromstring 
To prevent flooding the log with actual image data.

Signed-off-by: Vincent Petry <vincent@nextcloud.com>
 2020-12-04 09:30:20 +01:00
Christoph Wurst
d9015a8c94 Format code to a single space around binary operators 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-10-05 20:25:24 +02:00
Julius Härtl
b0699d4126 Generate exception to log on php errors 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2020-09-29 08:54:53 +02:00
Christoph Wurst
2a054e6c04 Update the license headers for Nextcloud 20 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-08-24 14:54:25 +02:00
Christoph Wurst
ab303dddcd Make the PSR-3 adapter exception-aware 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-07-14 09:38:51 +02:00
Morris Jobke
065ef14cb0 Move OC_Mount_Config to proper classname and remove OC::$CLASSPATH usage in files_external 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2020-07-10 00:02:59 +02:00
J0WI
6ca1599ea4 Fix chmod on file descriptor 
Signed-off-by: J0WI <J0WI@users.noreply.github.com>
 2020-07-03 20:53:58 +02:00
Joas Schilling
a7f26cfe28 Don't log Keys 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2020-06-19 13:44:27 +02:00
Christoph Wurst
cb057829f7 Update license headers for 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-29 11:57:22 +02:00
Christoph Wurst
28f8eb5dba Add visibility to all constants 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:54:27 +02:00
Christoph Wurst
caff1023ea Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Christoph Wurst
14c996d982 Use elseif instead of else if 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 10:35:09 +02:00
Christoph Wurst
41b5e5923a Use exactly one empty line after the namespace declaration 
For PSR2

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 11:48:10 +02:00
Christoph Wurst
547ba642c6 Merge pull request #18200 from nextcloud/enhancement/psr-logger 
Add a PSR-3 logger adapter and make it injectable
 2020-04-08 11:49:56 +02:00
Christoph Wurst
1a9330cd69 Update the license headers for Nextcloud 19 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-31 14:52:54 +02:00
Christoph Wurst
463b388589 Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports 
Remove unused imports
 2020-03-27 17:14:08 +01:00
Christoph Wurst
b80ebc9674 Use the short array syntax, everywhere 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-26 16:34:56 +01:00
Christoph Wurst
1b4380aae8 Add a PSR-3 logger adapter and make it injectable 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-26 10:52:10 +01:00
Christoph Wurst
74936c49ea Remove unused imports 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 22:08:08 +01:00
Arthur Schiwon
e008444887 always require a message paramter for data logging 
also ensure it plays well with current log reader

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2020-01-28 13:00:13 +01:00
Christoph Wurst
1b46621cd3 Update license headers for 18 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-20 09:23:25 +01:00
Christoph Wurst
5bf3d1bb38 Update license headers 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2019-12-05 15:38:45 +01:00
Roeland Jago Douma
f2ef35dbf1 Fix logger test 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-27 13:34:42 +01:00
Roeland Jago Douma
bfaca7fc78 Sensitive values handling 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-27 13:34:41 +01:00
Roeland Jago Douma
68748d4f85 Some php-cs fixes 
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-22 20:52:10 +01:00
Julius Härtl
29a6f2d830 Do not escape slashes in log json 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2019-10-07 13:39:40 +02:00
Julius Härtl
2efb9a7d90 Make sure SystemConfig class can be injected and syslog_tag is fetched properly 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2019-08-13 16:26:18 +02:00
Julius Härtl
07bbec3355 Move log detail aggregation to separate class and reuse it in syslog/systemd logger 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2019-07-17 08:45:55 +02:00
Joas Schilling
a79da346b6 fix class might be undefined 
Co-Authored-By: blizzz <blizzz@arthur-schiwon.de>

Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2019-05-08 10:04:19 +02:00
Arthur Schiwon
d6d1666600 remove args from logging of common-spelled methods dependent on class 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2019-05-07 00:19:48 +02:00
Arthur Schiwon
4ad8d0c0d8 remove setup args from logging 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2019-05-06 23:59:45 +02:00