847aa08ebd
Don't log keys on checkSignature
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2021-01-18 16:09:06 +01:00
59ae722087
Fix warning in PHP 8 about optional parameter before mandatory one
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2021-01-07 12:43:56 +01:00
179de95f81
Avoid huge exception argument logging
...
In some cases it might happen that you have an argument that deep down
somewhere has an array with a lot of entries (think thousands). Now
before we would just happily print them all. Which would fill the log.
Now it will just print the first 5. And add a line that there are N
more.
If you are on debug level we will still print them all.
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2020-12-29 10:50:53 +01:00
d89a75be0b
Update all license headers for Nextcloud 21
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-12-16 18:48:22 +01:00
9b3361ce87
Don't log params of imagecreatefromstring
...
To prevent flooding the log with actual image data.
Signed-off-by: Vincent Petry <vincent@nextcloud.com >
2020-12-04 09:30:20 +01:00
d9015a8c94
Format code to a single space around binary operators
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-10-05 20:25:24 +02:00
b0699d4126
Generate exception to log on php errors
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2020-09-29 08:54:53 +02:00
2a054e6c04
Update the license headers for Nextcloud 20
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-08-24 14:54:25 +02:00
ab303dddcd
Make the PSR-3 adapter exception-aware
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-07-14 09:38:51 +02:00
065ef14cb0
Move OC_Mount_Config to proper classname and remove OC::$CLASSPATH usage in files_external
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2020-07-10 00:02:59 +02:00
6ca1599ea4
Fix chmod on file descriptor
...
Signed-off-by: J0WI <J0WI@users.noreply.github.com >
2020-07-03 20:53:58 +02:00
a7f26cfe28
Don't log Keys
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2020-06-19 13:44:27 +02:00
cb057829f7
Update license headers for 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-29 11:57:22 +02:00
28f8eb5dba
Add visibility to all constants
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-10 16:54:27 +02:00
caff1023ea
Format control structures, classes, methods and function
...
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.
This also removes and empty lines from method/function bodies at the
beginning and end.
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-10 14:19:56 +02:00
14c996d982
Use elseif instead of else if
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-10 10:35:09 +02:00
41b5e5923a
Use exactly one empty line after the namespace declaration
...
For PSR2
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-04-09 11:48:10 +02:00
547ba642c6
Merge pull request #18200 from nextcloud/enhancement/psr-logger
...
Add a PSR-3 logger adapter and make it injectable
2020-04-08 11:49:56 +02:00
1a9330cd69
Update the license headers for Nextcloud 19
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-03-31 14:52:54 +02:00
463b388589
Merge pull request #20170 from nextcloud/techdebt/remove-unused-imports
...
Remove unused imports
2020-03-27 17:14:08 +01:00
b80ebc9674
Use the short array syntax, everywhere
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-03-26 16:34:56 +01:00
1b4380aae8
Add a PSR-3 logger adapter and make it injectable
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-03-26 10:52:10 +01:00
74936c49ea
Remove unused imports
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2020-03-25 22:08:08 +01:00
e008444887
always require a message paramter for data logging
...
also ensure it plays well with current log reader
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2020-01-28 13:00:13 +01:00
1b46621cd3
Update license headers for 18
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2019-12-20 09:23:25 +01:00
5bf3d1bb38
Update license headers
...
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at >
2019-12-05 15:38:45 +01:00
f2ef35dbf1
Fix logger test
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-11-27 13:34:42 +01:00
bfaca7fc78
Sensitive values handling
...
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-11-27 13:34:41 +01:00
68748d4f85
Some php-cs fixes
...
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl >
2019-11-22 20:52:10 +01:00
29a6f2d830
Do not escape slashes in log json
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2019-10-07 13:39:40 +02:00
2efb9a7d90
Make sure SystemConfig class can be injected and syslog_tag is fetched properly
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2019-08-13 16:26:18 +02:00
07bbec3355
Move log detail aggregation to separate class and reuse it in syslog/systemd logger
...
Signed-off-by: Julius Härtl <jus@bitgrid.net >
2019-07-17 08:45:55 +02:00
a79da346b6
fix class might be undefined
...
Co-Authored-By: blizzz <blizzz@arthur-schiwon.de >
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2019-05-08 10:04:19 +02:00
d6d1666600
remove args from logging of common-spelled methods dependent on class
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2019-05-07 00:19:48 +02:00
4ad8d0c0d8
remove setup args from logging
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2019-05-06 23:59:45 +02:00
e8739e1392
Remove sensitive SMB arguments from exception log
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2019-03-12 15:51:38 +01:00
d8e041a5a2
Don't log parameters on user creation in case of error/exception
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2019-01-10 10:46:58 +01:00
d17856a1e9
Make logfile's mode configurable.
...
The file logger currently resets the mode of the logfile to 0640.
When the webserver is running as a different user than the cron job
(but both are in the same group) the files mode has to be 0660. The
current implementation breaks logging for the user that is not the
owner of the logfile.
This patch introduces a new config option 'logfilemode' that expects
an octal value (defaults to 0640). Unless the value is lower or equal
than 0 the logfiles mode will be resetted to this value.
Signed-off-by: Roland Tapken <roland@bitarbeiter.net >
2018-10-02 18:27:06 +02:00
b788f0a456
Make sure error_log() always receives a string
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
2018-07-23 16:30:38 +02:00
99c00972a0
make exception serializer a bit more robust
...
Signed-off-by: Robin Appelman <robin@icewind.nl >
2018-07-18 16:56:34 +02:00
a11d198a06
Sanitize parameters in createSessionToken() while logging
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2018-07-11 14:26:57 +02:00
10b8a4a8b1
Revert "Fix undeclared method warning in phan"
...
This reverts commit f3093b2401hey@morrisjobke.de >
2018-07-03 17:46:11 +02:00
f3093b2401
Fix undeclared method warning in phan
...
Signed-off-by: Morris Jobke <hey@morrisjobke.de >
2018-07-02 15:38:49 +02:00
72340b2230
Added Systemd.log documentation to config.sample.php
...
Changed name of default system (not systemd) logger from ownCloud to Nextcloud, to be consistent
Fixed license per https://github.com/nextcloud/server/pull/9760#discussion_r195026784
Pulled upstream updates
Signed-off-by: Johannes Ernst <jernst@indiecomputing.com >
2018-06-29 10:37:46 +02:00
0a65e62f29
Added a logger for systemd/journald
...
Added a unit test
Signed-off-by: Johannes Ernst <jernst@indiecomputing.com >
2018-06-29 10:37:45 +02:00
aff5fe68b3
use SystemConfig, less dependencies, and not publicly needed
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2018-04-26 23:54:11 +02:00
b841a477c6
log to $datadir/audit.log by default and add rotation
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2018-04-26 12:10:53 +02:00
5751788282
add missing php doc and type hints
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2018-04-26 12:10:53 +02:00
a21a5bc4ec
improve Syslog a little
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2018-04-26 12:10:53 +02:00
0e6a317516
revert Log's dependency to SystemConfig to work during Installation
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2018-04-26 12:10:53 +02:00
Joas Schilling
Morris Jobke
Roeland Jago Douma
Christoph Wurst
Vincent Petry
Julius Härtl
J0WI
Christoph Wurst
Arthur Schiwon
Joas Schilling
Roland Tapken
Robin Appelman
Johannes Ernst