averello/nextcloud-server-mirror
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-02-27 18:37:17 +01:00
Code Issues Packages Projects Releases Wiki Activity
77,189 Commits 689 Branches 1,186 Tags
606241caebda2e01702c0d08adbc35ace8d01f13
Commit Graph

43 Commits

Author SHA1 Message Date
Julius Knorr
606241caeb chore(legacy): Introduce public version ct plass and drop version methods from OC_Util 
Signed-off-by: Julius Knorr <jus@bitgrid.net>
 2024-09-20 14:53:34 +02:00
Christoph Wurst
49dd79eabb refactor: Add void return type to PHPUnit test methods 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-09-15 22:32:31 +02:00
Daniel Kesselberg
af6de04e9e style: update codestyle for coding-standard 1.2.3 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-08-25 19:34:58 +02:00
Ferdinand Thiessen
0563757ea4 fix(SetupCheck): Properly check public access to data directory 
When checking for public (web) access to the data directory the status is not enough
as you might have a webserver that forwards to e.g. a login page.
So instead check that the content of the file matches.

For this the `.ncdata` file (renamed from `.ocdata`¹) has minimal text content
to allow checking.

¹The file was renamed from the legacy `.ocdata`, there is a repair step to remove the old one.

Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-08-08 22:08:42 +02:00
Ferdinand Thiessen
f4ede27cdb refactor: Remove deprecated Util function for filename validation to FilenameValidator 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-07-16 12:49:10 +02:00
Ferdinand Thiessen
1a27314530 fix(Mailer): Allow to enforce strict email format 
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
 2024-05-31 14:18:06 +02:00
Andy Scherzinger
1f7e2ba599 chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-05-13 17:41:36 +02:00
John Molakvoæ
58d516b509 Make sure common and main core scripts are loaded first 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2022-03-04 10:22:56 +01:00
Louis Chemineau
25ade6218a Streamline reseting of private static properties 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-01-11 10:29:25 +01:00
Louis Chemineau
92e60caa86 Revert "Streamline reseting of private static properties" 
This reverts commit e50121d4c0.
 2022-01-10 18:42:07 +01:00
Louis Chemineau
e50121d4c0 Streamline reseting of private static properties 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-01-10 17:34:48 +01:00
Louis Chemineau
447cd553b6 Reset $scriptDeps in tests 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-01-08 10:15:48 +01:00
Jonas Meurer
491bd6260c Sort app scripts topologically by its dependencies 
Implement a proper topological sorting algorithm. Based on the
implementation by https://github.com/marcj/topsort.php

Logs an error in case a circular dependency is detected.

Fixes: #30278

Signed-off-by: Jonas Meurer <jonas@freesources.org>
 2021-12-29 16:40:05 +01:00
Jonas Meurer
8dd119402a Improve unit testing for Util::addScript() and Util::getScript() 
Instead of checking for a predefined order of the scripts, test the
logic: core first, dependencies before their children, no duplicates and
all scripts still listed.

Signed-off-by: Jonas Meurer <jonas@freesources.org>
 2021-12-20 11:40:17 +01:00
John Molakvoæ (skjnldsv)
791d57051a Adapt tests 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-12-02 21:13:07 +01:00
Arthur Schiwon
d384edc9c6 add method to shorten a string to given byte size to Utils 
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
 2021-11-26 16:21:40 +01:00
Naoto Kobayashi
e9b414fbe3 OC_Util: Add fallbacks to check if current locale is UTF8 
Using escapeshellcmd to get current locale causes error
if the function is disabled.

Add fallbacks to prevent the error.

Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
 2021-11-16 00:40:52 +09:00
Naoto Kobayashi
25f15f86a9 Add check whether escapeshellcmd behaves the same as basename 
Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
 2021-11-15 18:33:50 +09:00
Naoto Kobayashi
455bff5c17 Fix missing setlocale with php 8 
When php version = 8, basename('§') does not bug even if LC_ALL is non-UTF-8 locale.
This cause OC_Util::isSetLocaleWorking() to skip setlocale("C.UTF-8").

Fix it by using escapeshellcmd instead of basename.

Signed-off-by: Naoto Kobayashi <naoto.kobayashi4c@gmail.com>
 2021-11-14 09:18:59 +09:00
Daniel Rudolf
15a445f743 Move UtilTest::testDefaultApps() to UrlGeneratorTest 
Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
 2021-07-01 16:26:55 +02:00
Daniel Rudolf
e16bf707aa Fix UtilTest::testDefaultApps() 
Oh wow... This definitly was no best practice... 😒

Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
 2021-07-01 16:00:29 +02:00
Daniel Rudolf
12059eb65b Add IUrlGenerator::linkToDefaultPageUrl() 
Replaces the deprecated \OC_Util::getDefaultPageUrl() and makes this API public.

Signed-off-by: Daniel Rudolf <github.com@daniel-rudolf.de>
 2021-06-30 16:20:57 +02:00
Robin Appelman
b1dca57a1c load share settings from the share manager in more places 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-05-12 16:11:28 +02:00
Christoph Wurst
1584c9ae9c Add visibility to all methods and position of static keyword 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 16:51:06 +02:00
Christoph Wurst
caff1023ea Format control structures, classes, methods and function 
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-10 14:19:56 +02:00
Christoph Wurst
afbd9c4e6e Unify function spacing to PSR2 recommendation 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-04-09 13:54:22 +02:00
Christoph Wurst
b80ebc9674 Use the short array syntax, everywhere 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-26 16:34:56 +01:00
Christoph Wurst
2ee65f177e Use the shorter phpunit syntax for mocked return values 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2020-03-25 22:21:27 +01:00
Roeland Jago Douma
c007ca624f Make phpunit8 compatible 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2019-11-27 13:34:41 +01:00
Roeland Jago Douma
1088068c60 Remove \OCP\Files::tmpFolder 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-03-19 10:54:39 +01:00
Morris Jobke
44289ff134 Use proper method to format absolute timestamp 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2018-03-12 15:16:52 +01:00
Roeland Jago Douma
8a41d05761 Remove deprecated \OCP\Config 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2018-01-13 14:25:04 +01:00
Morris Jobke
be4e921306 Use basename() instead of self implementation 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-11-23 12:35:47 +01:00
Morris Jobke
43e498844e Use ::class in test mocks 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-10-24 17:45:32 +02:00
Morris Jobke
c27498db71 Use IConfig instead of static OCP\Config 
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
 2017-07-27 13:43:18 +02:00
Vincent Petry
1c771c097a Use regex to detect part files 2017-04-26 16:12:48 +02:00
Felix Epp
1614b310ef Add system config htaccess.IgnoreFrontController for prettyURLs w/o mod_env 
Added the system config which sets all conditions to true that query the
FrontControllerActive mod_env variable.

Signed-off-by: Felix A. Epp <work@felixepp.de>
 2016-11-16 22:28:49 +01:00
Roeland Jago Douma
83e7cfd13a Fix more tests 
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
 2016-10-28 22:16:28 +02:00
Joas Schilling
122edcd0c1 Make sure all tests use the TestCase method to overwrite services 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2016-10-20 15:19:41 +02:00
Roeland Jago Douma
368f407698 Fix getMock UtilTest 2016-09-13 09:09:53 +02:00
Roeland Jago Douma
8d739f308b Some UtilTests require DB 
In the current setup there is no DI so no way to mock them.
 2016-07-11 21:05:39 +02:00
Morris Jobke
c2d88a08b7 Remove unneeded checks if it runs on a Windows machine 
* the setup check is still there
 2016-07-08 15:55:17 +02:00
Joas Schilling
9a4253ef7c Fix lib/ 2016-05-19 09:38:52 +02:00