averello/nextcloud-server-mirror
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-03-04 18:28:08 +01:00
Code Issues Packages Projects Releases Wiki Activity
71,567 Commits 712 Branches 1,186 Tags
8904bf645b30fbdfdcb00a2ea607d752ee69d865
Commit Graph

137 Commits

Author SHA1 Message Date
Joas Schilling
aa5f037af7 chore: apply changes from Nextcloud coding standards 1.1.1 
Signed-off-by: Joas Schilling <coding@schilljs.com>
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-11-23 10:36:13 +01:00
Robin Appelman
9bc44de95d reuse sharing disabled state when listing folder content 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-10-19 19:40:52 +02:00
Benjamin Gaussorgues
003d0dec93 Detect aborted connection in OC\Files\View and stop writing data to the output buffer 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2023-09-07 09:32:32 +02:00
Anna Larch
556f29bef5 fix: don't emit Hooks when hookpaths are empty 
Signed-off-by: Anna Larch <anna@nextcloud.com>
 2023-08-17 09:32:14 +02:00
Faraz Samapoor
e7cc7653b8 Refactors "strpos" calls in lib/private to improve code readability. 
Signed-off-by: Faraz Samapoor <fsamapoor@gmail.com>
 2023-05-15 15:17:19 +03:30
Arthur Schiwon
997efe44ff Merge pull request #37943 from nextcloud/fix/fix-getcontent-return-type 
Fix file_get_content signatures to make it clear it can return false
 2023-05-03 10:34:51 +02:00
Git'Fellow
951c5b973e Normalize logical operators 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2023-05-02 10:10:02 +02:00
Côme Chilliet
546d94c3ec Fix file_get_content signatures to make it clear it can return false 
In File::getContent, which must return a string, throw an Exception
 instead of returning false.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-27 09:56:05 +02:00
Côme Chilliet
6633b4ced6 Remove unecessary fully qualified namespaces from phpdoc 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-05 09:13:39 +02:00
Côme Chilliet
5ad045619c View needs to return an instance of OC\Files\FileInfo explicitely 
Applications are calling methods from the class which are not from the
 public interface, and which cannot be added easily to public interface
 because Node interface extends FileInfo.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:35 +02:00
Côme Chilliet
0b3dad895f More type cleanup in View and FileInfo 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:35 +02:00
Côme Chilliet
ea05544213 Fix return type of methods returning false on error 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:34 +02:00
Côme Chilliet
4393b96542 Remove unused method getLocalFolder 
It’s not used and not in any OCP interface/class.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:34 +02:00
Côme Chilliet
966a3e6963 Tidy up typing in OC\Files\View 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-04-03 10:52:33 +02:00
Julius Härtl
d515da502f fix: Use proper path for quota fetching 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2023-03-06 22:46:07 +00:00
Robin Appelman
5bcf37b7ff only fetch the data for mounts inside a folder when needed 
for most operations we don't actually care about any mounts inside a folder, only for metadata that needs to propagate across storage boundaries (size, etag, mtime) do we need all the submount info.

By only loading this data when needed we can save a bunch of storage setup in a number of cases

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2023-02-09 11:39:00 +01:00
Côme Chilliet
028c225d96 Fix psalm errors 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:32 +01:00
Côme Chilliet
ff776a90b1 Strong type filesize related methods to ease 32bits problem findings 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-02-07 11:23:28 +01:00
Côme Chilliet
f5c361cf44 composer run cs:fix 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2023-01-20 11:45:08 +01:00
Louis Chemineau
66ba90ceff Update cache when file size === 0 
The conditions were false when $result === 0.
$results here contains the number of written bits.
The correct way of checking for operation success is to check if $result === false

Signed-off-by: Louis Chemineau <louis@chmn.me>
 2022-11-23 12:43:57 +01:00
Carl Schwan
a5ea677370 Rename file1 and file2 to source and target in Storage abstraction 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-10-18 17:21:47 +02:00
blizzz
ca958de7e9 Merge pull request #33566 from nextcloud/fopen-not-found-rescan 
trigger a rescan when trying to fopen a file that exists in cache but not on disk
 2022-10-01 21:47:26 +02:00
Carl Schwan
92a5a8f075 Cleanup tags and Share component 
- Port to LoggerInterface
- Use IDBConnection and IQueryBuilder instead of raw SQL and OC_DB
- Use IEventListener instead of hooks
- Remove the now unused OC_DB and OC_DB_StatementWrapper legacy utils

Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-09-29 15:15:28 +00:00
Robin Appelman
cb51564356 trigger a rescan when trying to fopen a file that exists in cache but not on disk 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-09-29 11:17:16 +02:00
Carl Schwan
51b9847fad Merge branch 'master' into display-name-cache-public 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-08-15 15:28:30 +02:00
luz paz
368f83095d Fix typos in lib/private subdirectory 
Found via `codespell -q 3 -S l10n -L jus ./lib/private`

Signed-off-by: luz paz <luzpaz@github.com>
 2022-07-27 08:52:17 -04:00
Robin Appelman
6d6662ec68 expose displayname cache trough a public interface 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-05-18 03:47:34 +02:00
Côme Chilliet
069477e608 Migrate more classes of lib/private to LoggerInterface 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-04-26 16:52:52 +02:00
Vincent Petry
ff385dc679 Merge pull request #32082 from nextcloud/directory-content-lazy-owner 
use a lazy user for the file owner when listing a directory
 2022-04-25 11:44:44 +02:00
Robin Appelman
7a6c724a81 Use a lazy user for the file owner when listing a directory 
Only getUID and getDisplayName are called on the file owner objects anyway
and we can get this information often without DB request

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-04-22 17:02:37 +02:00
Robin Appelman
9f0ba3adc2 optimize adding submount info to directory content 
no need to loop when we can do a hashtable lookup

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-04-22 15:50:14 +02:00
Robin Appelman
5e69f98c16 sh 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-04-06 18:08:13 +02:00
Robin Appelman
151c800397 allow reusing known folder info when getting directory contents 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-04-06 14:40:34 +02:00
Côme Chilliet
140624d551 composer run cs:fix 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-04-05 16:47:13 +02:00
Côme Chilliet
d36a1a7bf6 Exit early if $storage is falsy in View::getDirectoryContent 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-04-05 13:58:49 +00:00
Côme Chilliet
916fbe81c6 Fix incorrect if conditions in View 
($something->getPermissions() && Constants::PERMISSION_READ) does not
  make sense as PERMISSION_READ contant is 1 this will always evaluate to
  true.
getPersmissions is returning an int which is a bitwise combination as
  documented in the interface, so it should be used with bit operators.

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2022-04-05 13:58:49 +00:00
Robin Appelman
ff666e648a Add dav plugin to trigger recalculating of checksums 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-03-31 07:44:13 +00:00
Robin Appelman
917c74e214 type fixes 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-03-04 16:30:16 +01:00
Robin Appelman
5c0fe93498 move teardown logic to SetupManager 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2022-03-04 16:29:50 +01:00
Vincent Petry
4903cb8db4 Merge pull request #29866 from nextcloud/isset-size 
Check if size value is set
 2022-01-17 10:59:52 +01:00
Carl Schwan
6312c0df69 Check style update 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-13 00:19:07 +01:00
Carl Schwan
aeecb72e96 Fix a few psalm issues and moved back to psalm/phar 4.18 
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
 2022-01-12 20:03:06 +01:00
acsfer
97e1855ed5 Typo 2021-11-24 11:55:06 +01:00
acsfer
0a0fd33773 Check if size value is set 
Using `isset()` as it does not return true for array keys that correspond to a `null` value, while `array_key_exists()` does.
Fix #29865
 2021-11-23 21:33:28 +01:00
John Molakvoæ
d6152bf98d Fix psalm 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
 2021-11-04 10:24:13 +01:00
John Molakvoæ
d6a26b2536 Revert "add dav plugin to trigger recalculating of checksums" 2021-11-01 11:26:17 +01:00
Robin Appelman
fd5e11a81a Add dav plugin to trigger recalculating of checksums 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2021-08-23 15:38:58 +02:00
Morris Jobke
2ae60b42ab Merge pull request #26494 from rigrig/fix-php8-deprecations 
Fix some php 8 warnings
 2021-06-07 23:30:59 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd Update php licenses 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2021-06-04 22:02:41 +02:00
Richard de Boer
7990f95558 Check whether output buffering is active before turning it off 
Before we just turned it off and @suppressed the error if ob was not active.
In PHP 8 this error is no longer suppressed, so try to not cause it at all.

Signed-off-by: Richard de Boer <git@tubul.net>
 2021-05-29 14:14:52 +02:00