averello/nextcloud-server-mirror
1
0
Fork 0
mirror of https://github.com/nextcloud/server.git synced 2026-03-04 18:28:08 +01:00
Code Issues Packages Projects Releases Wiki Activity
77,659 Commits 712 Branches 1,186 Tags
b0197c5dfcb0dac94de43bfbfa89a2889fc1e30b
Commit Graph

1281 Commits

Author SHA1 Message Date
provokateurin
e8426996f5 fix(psalm): Fix some newly detected issues 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-21 12:37:59 +02:00
provokateurin
381077028a refactor(apps): Use constructor property promotion when possible 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-21 12:37:59 +02:00
Git'Fellow
c254855222 chore(db): Correctly apply query types 
fix: psalm

fix: error

fix: add batch

fix: fatal error

fix: add batch

chore: add batch

chore: add batch

fix: psalm

fix: typo

fix: psalm

fix: return bool

fix: revert Manager
 2024-10-17 09:21:07 +02:00
yemkareems
b86dc076b5 fix: add PasswordConfirmationRequired to update and delete method 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-16 16:49:13 +02:00
yemkareems
d3f1b76ebb fix: add PasswordConfirmationRequired to create user storages endpoint 
Signed-off-by: yemkareems <yemkareems@gmail.com>
 2024-10-16 16:49:06 +02:00
Côme Chilliet
1580c8612b chore(apps): Apply new rector configuration to autouse classes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-10-15 10:40:25 +02:00
Kate
614d8c23a0 Merge pull request #48494 from nextcloud/refactor/storage/strong-param-types 2024-10-08 15:20:17 +02:00
provokateurin
54ec472d9a fix(BackgroundJobs): Adjust intervals and time sensitivities 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-08 11:26:53 +02:00
provokateurin
14e6734547 refactor(files_external): Add Storage parameter strong types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-10-07 15:00:07 +02:00
Joas Schilling
4219969c96 fix: Ensure we only pass string to writeln() 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-07 12:11:38 +02:00
Joas Schilling
c109ae9437 ci: Fix psalm by typing the QuestionHelper 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-07 12:11:27 +02:00
Robin Appelman
103b464eea fix: use nc's binary finding logic for smb 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-10-04 15:56:31 +02:00
Joas Schilling
96f77d7b99 fix(filesexternal): Remove unneeded 3rdparty library use 
Signed-off-by: Joas Schilling <coding@schilljs.com>
 2024-10-02 23:27:44 +02:00
Côme Chilliet
6ef05bafeb fix: Fix test of IConstructableStorage implentation by storage classes 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-30 11:21:42 +02:00
provokateurin
1302b48ca2 fix(files_external): Fix all IStorage return types 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-26 17:29:48 +02:00
Louis
c45ed55f95 Merge pull request #48359 from nextcloud/artonge/feat/compare_hashed_password_when_updating_global_cred_in_files_external 
fix: Use placeholder for external storage password
 2024-09-26 14:56:37 +02:00
Marcel Klehr
c8a90e941a fix(files_external): Catch correct exception 
SMB#getFileInfo used to throw an icewind/smb exception, but nowadays throws \OCP\Files\ForbiddenException. This fixes downstream methods to catch the new exception.

Signed-off-by: Marcel Klehr <mklehr@gmx.net>
 2024-09-26 09:03:08 +02:00
Louis Chemineau
20eb464835 fix: Use hashed password in files_external settings 
Signed-off-by: Louis Chemineau <louis@chmn.me>
 2024-09-25 17:50:17 +02:00
Côme Chilliet
40b404c566 Merge pull request #48111 from nextcloud/fix/move-storage-constructor-to-specific-interface 
fix: Move storage constructor to specific interface
 2024-09-23 15:57:38 +02:00
Côme Chilliet
94b0a0e863 fix: Move storage constructor to specific interface 
That allows Wrappers to use DI and not care about the constructor

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-23 09:46:44 +02:00
Côme Chilliet
1a4978c4ea chore: Apply rector configuration to apps folder 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-20 17:51:00 +02:00
provokateurin
9836e9b164 chore(deps): Update nextcloud/coding-standard to v1.3.1 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-09-19 14:21:20 +02:00
Côme Chilliet
801733e523 fix: Remove OCP\Files\Storage interface deprecated since version 9 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-09-16 18:10:48 +02:00
Christoph Wurst
614f9ec0a2 refactor: Use the elvis operator 
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
 2024-09-15 21:01:34 +02:00
Git'Fellow
07a6fd11d0 fix(files_external): Check key exists before accessing it 
Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
 2024-09-14 11:21:17 +02:00
John Molakvoæ (skjnldsv)
0f519f4856 fix(files_external): broken credentials dialog 
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
 2024-09-13 14:32:07 +00:00
Josh
2480567005 Merge pull request #47526 from nextcloud/jtr/fix-ftp-custom-port-ui 
fix(files_external): Handling in FTP UI for custom ports
 2024-09-12 09:34:47 -04:00
Josh
56c744d263 Merge pull request #47527 from nextcloud/fix-sftp-custom-port-ui 
fix(files_external): Handling in SFTP UI for custom ports
 2024-09-12 09:34:32 -04:00
Daniel Calviño Sánchez
bd4de5208d fix: Fix unmodified placeholder replacing the actual value when updating 
When updating global storages and user storages a property is not
updated by "StoragesService::updateStorage()" if the value matches the
unmodified placeholder. However, userglobal storages are not updated
through the "StoragesService"; as only the authentication mechanism is
updated it is directly done with "saveBackendOptions()" in
"IUserProvided" or "UserGlobalAuth". Due to this the unmodified
placeholder value needs to be explicitly checked in those cases and
replaced by the actual value (note that in this case it is not possible
to just skip updating a specific property).

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2024-09-04 09:46:17 +02:00
Josh Richards
2e73932c8e fix: custom port handling in UI for SFTP 
Signed-off-by: Josh Richards <josh.t.richards@gmail.com>
 2024-08-27 09:01:12 -04:00
Josh
6db4099246 fix: custom port handling in UI for FTP External Storage 
Signed-off-by: Josh <josh.t.richards@gmail.com>
 2024-08-27 08:49:24 -04:00
Daniel Kesselberg
af6de04e9e style: update codestyle for coding-standard 1.2.3 
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
 2024-08-25 19:34:58 +02:00
John Molakvoæ
d35c4eb911 Merge branch 'master' into jr-readdir-false-false 
Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
 2024-08-16 10:53:50 +02:00
provokateurin
c102b89cd5 refactor(files_external): Replace security annotations with respective attributes 
Signed-off-by: provokateurin <kate@provokateurin.de>
 2024-08-14 09:44:57 +02:00
Robin Appelman
c2b1f079b1 feat: add a specialized writeStream implementation for s3 external storage 
Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-07-24 17:37:20 +02:00
Benjamin Gaussorgues
369c552e41 Merge pull request #46073 from nextcloud/fix/save_global_credentials 2024-06-25 09:48:24 +02:00
Benjamin Gaussorgues
e93866f904 fix: allows admin to edit global credentials 
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com>
 2024-06-24 15:20:44 +02:00
Daniel Calviño Sánchez
733e3f62fd fix: Do not log an error when connecting to SFTP without a logged in user 
When connecting to a SFTP server from a SFTP storage the host key is
checked against the known host keys stored in a file in the data
directory of the logged in Nextcloud user. The path to the file is
(indirectly) got using "OC_App::getStorage", which logs an error if
called when there is no logged in user; this can happen, for example, if
the storage is used from a background job or a command.

Not being able to read or write the file just causes the host key check
to be skipped, but it has no other consequence. Moreover, even with
logged in users it is likely that the file can not be read either and
the check is also skipped, as the file needs to have been manually
created by an admin.

Due to all that now the path to the file is directly created using a
View rather than relying on "OC_App::getStorage" to prevent the unneeded
error from being logged.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
 2024-06-18 07:06:30 +02:00
Andy Scherzinger
c1555fc33e chore: Add SPDX header 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
 2024-06-06 18:05:37 +02:00
Côme Chilliet
4d060818d1 fix(files_external): Be extra safe with null handling to please psalm 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-30 09:24:00 +02:00
Côme Chilliet
3ad4bbb096 Merge pull request #44658 from nextcloud/fix/migrate-away-from-resource-type 
fix: Remove obsolete resource typing
 2024-04-16 17:13:07 +02:00
Julius Härtl
4910e7e231 fix: Pass the mountpoint target user to storages without owner 
Storages that do not have a dedicated owner (e.g. groupfolders, external
storages) currently always assume the current session user as the owner.
This leads to several issues when there is no user session but a node is
obtained through a user folder.

In order to have the correct user available we need to pass the user
that is used to setup a mountpoint along to the storage layer as we
generally assume that an owner is available for those.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-04-09 09:04:24 +01:00
Côme Chilliet
72a0da6d4e fix: Fix small psalm errors in FTP and LDAP connections 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-09 10:01:47 +02:00
Côme Chilliet
0f348516d2 fix: Remove obsolete resource typing 
In PHP>=8.1, LDAP and FTP resources are always typed objects

Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-09 10:01:47 +02:00
Côme Chilliet
81319e78bf chore: Improve phpdoc typing to silence psalm errors 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-02 14:16:21 +02:00
Côme Chilliet
ec5133b739 fix: Apply new coding standard to all files 
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
 2024-04-02 14:16:21 +02:00
Julius Härtl
e330efe5a0 fix: Implement option to temporarily set the user session 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-03-19 13:48:23 +01:00
Robin Appelman
42e14cc4c7 feat: add command to scan external storages directly 
the main use case of this over simply scanning through is the ability to provide a username and/or password for cases where login credentials are used

Signed-off-by: Robin Appelman <robin@icewind.nl>
 2024-03-06 19:11:08 +01:00
Julius Härtl
d576b8eaf9 fix: Allow to disable multipart copy on external s3 storage 
Signed-off-by: Julius Härtl <jus@bitgrid.net>
 2024-02-24 17:11:07 +01:00
Maxence Lange
2f41b9c092 mark MOUNT_TYPE_PERSONAl as deprecated 
Signed-off-by: Maxence Lange <maxence@artificial-owl.com>
 2024-02-24 11:33:44 +01:00