Commit Graph

51 Commits

Author SHA1 Message Date
Joas Schilling
bed3ffb312 feat(admin): Show an error when the admin is throttled
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-08-21 16:40:24 +02:00
Joas Schilling
ab70bbd3ff fix(db)!: Remove private legacy event because we can not keep it
Signed-off-by: Joas Schilling <coding@schilljs.com>
2023-07-24 14:51:35 +02:00
Julius Härtl
925bcebcb6 feat: Add public event for missing indices
Signed-off-by: Julius Härtl <jus@bitgrid.net>
2023-07-14 13:11:22 +02:00
Daniel Kesselberg
5a23b429dd feat: remove check for OpenSSL 1.0.1d and 1.0.2b
OpenSSL 1.0.1d: 2013-02-05
OpenSSL 1.0.2b: 2015-06-11

Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2023-06-04 18:44:47 +02:00
Simon L
e2ab9bf4af address review and fix tests
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-18 11:33:53 +02:00
Simon L
80645a591a add an admin check for db file locking
Signed-off-by: Simon L <szaimen@e.mail.de>
2023-04-17 12:51:33 +02:00
Côme Chilliet
68363f6944 Fix some more problems with tests under PHP 8.2
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-11-15 16:02:24 +01:00
szaimen
cf9b1082ed add a setup check for 64 bit
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-07-13 09:33:33 +00:00
Côme Chilliet
c0c54b20d9 Remove deprecated at() matcher from settings tests
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com>
2022-06-07 10:05:18 +02:00
szaimen
351357047a fix drone tests on master
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-03-11 20:45:26 +01:00
szaimen
3c8f8bc70a fix tests
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-03-07 18:07:45 +01:00
MichaIng
5ac91f1cb8 Add Nextcloud docs link to OPcache recommends
A link to the Nextcloud documentation is currently only shown when the OPcache module is not loaded at all. This commit moves the link to the generic text above the individual recommendations list.

Additionally remove the obsolete phpOpcacheDocumentation entry from test data arrays, which is not passed anymore by the backend.

Signed-off-by: MichaIng <micha@dietpi.com>
2022-03-03 23:00:07 +00:00
Arthur Schiwon
b28aa52b28 Setup warning for invalid LDAP user or group UUIDs.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de>
2022-02-10 10:15:01 +01:00
szaimen
fa1ee8f0c7 fix tests
Signed-off-by: szaimen <szaimen@e.mail.de>
2022-02-03 20:41:12 +01:00
MichaIng
82c1beaacb Enhance and complement OPcache setup checks
The current OPcache recommendations match the PHP defaults, but the values are much higher than required to run Nextcloud, even with a high number of installed apps. On the other hand, when other applications use the same OPcache instance, the recommended values might not be sufficient. Accurate recommendations need to take into account actual OPcache usage.

With this commit, recommendations are shown to raise the config value if more than 90% of max cache size or number of keys is used.

The checks whether the module is loaded and whether the OPcache is properly configured have been merged into a single function. This allowed to reduce the overhead of OPcache configuration checks when the module is not loaded.

A check has been added whether Nextcloud is permitted to use the OPcache API. Without this, inconsistencies during core or app upgrades may cause errors and OPcache usage cannot be determined for the new usage based checks.

OPcache usage based checks are skipped when Nextcloud is not permitted to use the API.

Signed-off-by: MichaIng <micha@dietpi.com>
2021-12-19 23:38:21 +01:00
Joas Schilling
e8f7a08e52 ArgumentCountError: Too few arguments to function OCA\Settings\Controller\CheckSetupController::__construct()
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 15:13:24 +01:00
Joas Schilling
24935666e8 PHPUnit\Framework\MockObject\DuplicateMethodException: Cannot stub or mock using a method list that contains duplicates:
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 15:13:24 +01:00
Joas Schilling
19d070850b Make sure trusted_proxies is an array
Signed-off-by: Joas Schilling <coding@schilljs.com>
2021-11-09 15:13:24 +01:00
Stefan
ea4b7bac7a Issue 16719: CheckSetupController.php: now injecting reference to ITempManager, rather than obtaining using it manually
Signed-off-by: Stefan <Stefan.Schilling@EXXETA.com>
2021-09-17 13:32:42 +02:00
John Molakvoæ (skjnldsv)
215aef3cbd Update php licenses
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-04 22:02:41 +02:00
John Molakvoæ (skjnldsv)
b228e8a361 Fix translation phpunit test
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com>
2021-06-02 18:00:45 +02:00
Roeland Jago Douma
38f761f25f Move away some ILoggers
Makes psalm happier

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2021-03-02 10:47:25 +01:00
Roeland Jago Douma
7d8e9baa77 Revert "use the configured forwarded headers for the setup check" 2021-02-13 18:03:32 +01:00
Robin Appelman
01118a2218 use the configured forwarded headers for the setup check
instead of always checking against the same header

Signed-off-by: Robin Appelman <robin@icewind.nl>
2021-02-12 14:22:27 +01:00
Morris Jobke
bffa61fc32 Add setup check to verify that the used DB version is still supported in the next major release
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2021-01-08 13:38:32 +01:00
Christoph Wurst
d89a75be0b Update all license headers for Nextcloud 21
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-12-16 18:48:22 +01:00
Joas Schilling
46b073d7ce Add a config for default region of phone numbers
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-12-07 14:19:38 +01:00
Joas Schilling
d5df033ede Create primary keys on all tables and add a command to create the afterwards
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-11-10 15:36:27 +01:00
Morris Jobke
1c496a5a35 Add a background job that checks for potential user imported SSL certificates and shows a warning in the admin settings
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-11-03 10:06:33 +01:00
nhirokinet
830348dbee Add SVG support check to setup check
Signed-off-by: nhirokinet <nhirokinet@nhiroki.net>
2020-11-02 11:29:08 +01:00
Roeland Jago Douma
0dbb99a81b Merge pull request #23161 from nextcloud/enh/noid/setup-checks2
Remove setup check for php mail
2020-10-08 22:40:37 +02:00
Christoph Wurst
d9015a8c94 Format code to a single space around binary operators
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-10-05 20:25:24 +02:00
Daniel Kesselberg
9c8e8007f9 Remove setup check for php mail
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-10-03 21:58:55 +02:00
Christoph Wurst
2a054e6c04 Update the license headers for Nextcloud 20
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-08-24 14:54:25 +02:00
Morris Jobke
9e483ea949 Fix unit tests
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-20 16:35:38 +02:00
Morris Jobke
603d7dab5e Add setup check that links to the migration documentation
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-19 15:45:45 +02:00
Morris Jobke
234b510652 Change PHPDoc type hint from PHPUnit_Framework_MockObject_MockObject to \PHPUnit\Framework\MockObject\MockObject
Signed-off-by: Morris Jobke <hey@morrisjobke.de>
2020-08-12 13:55:19 +02:00
Daniel Kesselberg
89c6a2bc1f Add setup checks for php default charset and output buffering.
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
2020-07-26 00:54:16 +02:00
Christoph Wurst
caff1023ea Format control structures, classes, methods and function
To continue this formatting madness, here's a tiny patch that adds
unified formatting for control structures like if and loops as well as
classes, their methods and anonymous functions. This basically forces
the constructs to start on the same line. This is not exactly what PSR2
wants, but I think we can have a few exceptions with "our" style. The
starting of braces on the same line is pracrically standard for our
code.

This also removes and empty lines from method/function bodies at the
beginning and end.

Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-10 14:19:56 +02:00
Christoph Wurst
44577e4345 Remove trailing and in between spaces
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 16:07:47 +02:00
Christoph Wurst
afbd9c4e6e Unify function spacing to PSR2 recommendation
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 13:54:22 +02:00
Christoph Wurst
2fbad1ed72 Fix (array) indent style to always use one tab
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-04-09 10:16:08 +02:00
Joas Schilling
720dc4e93d Add optional column oc_comments.reference_id
Signed-off-by: Joas Schilling <coding@schilljs.com>
2020-03-31 10:51:15 +02:00
Christoph Wurst
b80ebc9674 Use the short array syntax, everywhere
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-26 16:34:56 +01:00
Christoph Wurst
2ee65f177e Use the shorter phpunit syntax for mocked return values
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2020-03-25 22:21:27 +01:00
Roeland Jago Douma
b0ea022a3e Add basic reverseproxy misconfig detection to setupchecks
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2020-03-23 10:37:08 +01:00
Christoph Wurst
5bf3d1bb38 Update license headers
Signed-off-by: Christoph Wurst <christoph@winzerhof-wurst.at>
2019-12-05 15:38:45 +01:00
Roeland Jago Douma
3a7cf40aaa Mode to modern phpunit
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 15:27:18 +01:00
Roeland Jago Douma
c007ca624f Make phpunit8 compatible
Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-27 13:34:41 +01:00
Roeland Jago Douma
68748d4f85 Some php-cs fixes
* Order the imports
* No leading slash on imports
* Empty line before namespace
* One line per import
* Empty after imports
* Emmpty line at bottom of file

Signed-off-by: Roeland Jago Douma <roeland@famdouma.nl>
2019-11-22 20:52:10 +01:00