0887810eb9
fix: Use a CappedMemoryCache instead of an array to cache stuff in user_ldap
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-02 09:46:18 +02:00
18dddbc3b5
fix: Remove static var is Access class
...
It’s actually more correct to cache this per-instance.
What’s less clear is whether this can always fit in memory.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-02 09:46:18 +02:00
1ab09ec753
chore: Apply new coding standard to all files
...
The diff can be checked using: git diff --ignore-all-space --ignore-blank-lines
To see only the changes not related to blank lines.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2026-06-01 13:46:39 +02:00
580ba0c689
fix: Change the setting name
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2026-04-14 10:49:15 +02:00
63195fbf33
feat(user_ldap): Add config for partial search compatibility with ActiveDirectory
...
Signed-off-by: Marcel Klehr <mklehr@gmx.net >
2026-04-14 10:49:15 +02:00
1c01895796
fix(LDAP): use displayname from DB, before reaching out to LDAP
...
As we do it with other information of the user, we now use the known value
of a users displayname, and leave the updating to the background job. This
improves performance of user facing actions where the display name is
required and reduces queries to the LDAP server that are typically more
expensive.
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2026-03-18 11:34:35 +01:00
65e769a861
refactor: Apply comments
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:50:46 +01:00
5d0d0c17e5
chore(rector): Run rector on apps, core and tests directory
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2026-02-06 13:23:23 +01:00
2ae9626fec
refactor(user_ldap): Port most of the remaining deprecated IConfig usage
...
Signed-off-by: Carl Schwan <carl.schwan@nextcloud.com >
2025-12-11 13:27:48 +01:00
5981b7eb51
chore: apply new CSFixer rules
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
# Conflicts:
# apps/settings/lib/SetupChecks/PhpOpcacheSetup.php
2025-07-01 16:26:50 +02:00
7facae6b83
fix: remove caching in fetchListOfGroups
...
When using nested groups without a memberof overlay, then fetchListOfGroups is called from getGroupsByMember without applying the group filter.
In some setups, the "unfiltered" result is then written back to the group mapping table. That might cause random "An administrator removed you from group" activities.
I was unable to replicate it locally, but we got the feedback that the random activities stopped with the patch applied.
Ref: https://github.com/nextcloud/server/issues/42195
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2025-02-27 12:02:44 +01:00
095ab4419e
fix(l10n): Improve english source strings
...
- No leading/trailing whitespace
- Use asci single quote
Signed-off-by: Joas Schilling <coding@schilljs.com >
2025-02-26 09:54:32 +01:00
64863c9d46
chore: Apply new rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-02-13 11:46:42 +01:00
de77415c70
fix(user_ldap): Do not map groups we do not know if they match filter
...
When nesting is enabled, filterValidGroups is supposed to check for each
groups if it actually exist, because it may not be visible to
Nextcloud. So in this codepath we disable automapping of groups.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2025-01-27 14:51:51 +01:00
1580c8612b
chore(apps): Apply new rector configuration to autouse classes
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-10-15 10:40:25 +02:00
51d9d63a01
chore: Use more gender neutral language
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-10-14 13:59:24 +02:00
1a4978c4ea
chore: Apply rector configuration to apps folder
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-09-20 17:51:00 +02:00
9836e9b164
chore(deps): Update nextcloud/coding-standard to v1.3.1
...
Signed-off-by: provokateurin <kate@provokateurin.de >
2024-09-19 14:21:20 +02:00
dfa994ef28
Merge pull request #47865 from nextcloud/admin_audit/enh/move-to-event-listeners-v2
...
Move admin_audit to proper event listeners v2
2024-09-13 16:21:44 +02:00
c8fc2e8a67
fix(LDAP): check index before accessing it
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2024-09-12 11:18:18 +02:00
986a3d45f8
feat(user_ldap): Introduce user id assigned typed events for LDAP usage
...
Based on work from https://github.com/nextcloud/server/pull/32019
Signed-off-by: Thomas Citharel <tcit@tcit.fr >
2024-09-10 14:06:11 +02:00
36479df042
chore: composer run cs:fix
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-08-27 13:03:25 +02:00
fffba1c6af
fix(ldap): Fix user_ldap attribute casing to fix tests
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-08-27 10:06:45 +02:00
d2bc636a79
fix(user_ldap): Correctly cache that user exists to avoid a request on mapping new user
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-08-27 10:06:43 +02:00
4fb1d2f3e5
fix(user_ldap): Avoid extra LDAP request when mapping a user for the first time
...
Avoids using several LDAP searches to get UUID, display name and
internal name, now gets all attributes at the same time.
Also avoids extra request to build an unused user object in userExists.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-08-27 10:05:12 +02:00
af6de04e9e
style: update codestyle for coding-standard 1.2.3
...
Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de >
2024-08-25 19:34:58 +02:00
14778811b4
refactor: Use IAppConfig for setting cron type
...
Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de >
2024-06-28 18:00:39 +02:00
8d8891c5bc
chore: Add SPDX header
...
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de >
2024-05-30 15:49:33 +02:00
3ad4bbb096
Merge pull request #44658 from nextcloud/fix/migrate-away-from-resource-type
...
fix: Remove obsolete resource typing
2024-04-16 17:13:07 +02:00
6d7ff2e85a
fix: Fix typing issues related to resource migration
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-04-09 10:48:27 +02:00
0f348516d2
fix: Remove obsolete resource typing
...
In PHP>=8.1, LDAP and FTP resources are always typed objects
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-04-09 10:01:47 +02:00
55d3a2af9e
docs(LDAP): add info on stored DN form
...
Signed-off-by: Arthur Schiwon <blizzz@arthur-schiwon.de >
2024-04-05 16:47:55 +02:00
ec5133b739
fix: Apply new coding standard to all files
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-04-02 14:16:21 +02:00
2874dff773
fix(user_ldap): Early failure for empty password login attempt
...
This avoids user_ldap logging about an invalid configuration with an
empty password when the empty password actually comes from a login
attempt.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-03-06 16:47:16 +01:00
b2e9e0fa0d
chore: Replace OC::$server->getL10N by OCP\Util::getL10N in lib and some apps
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2024-02-05 11:16:04 +01:00
aa5f037af7
chore: apply changes from Nextcloud coding standards 1.1.1
...
Signed-off-by: Joas Schilling <coding@schilljs.com >
Signed-off-by: Benjamin Gaussorgues <benjamin.gaussorgues@nextcloud.com >
2023-11-23 10:36:13 +01:00
9ebcd287ef
Merge pull request #37201 from AaronDewes/fix/ldap-filter-generation
...
Fix: Escape group names for LDAP
2023-10-02 09:49:22 +02:00
d64bbc8bd3
Convert isset ternary to null coalescing operator
...
Signed-off-by: Hamid Dehnavi <hamid.dev.pro@gmail.com >
2023-09-28 12:18:41 +03:30
16908999ed
Simplify escapeFilterPart
...
Signed-off-by: Aaron Dewes <aaron.dewes@protonmail.com >
2023-08-13 15:43:04 +02:00
4a0351878c
Avoid adding (attribute=) part to filter which will confuse LDAP servers
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-06-29 10:42:59 +02:00
2e81a1d839
Merge pull request #38457 from nextcloud/fix/improve-ldap-offset-search-perf
...
Use default page size for jumping to desired offset
2023-06-22 21:46:03 +02:00
b980722e89
Fix paged search when offset is not a multiple of default page size
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-06-20 16:13:59 +02:00
b0938b9083
Refactors "strpos" calls in /apps/user_ldap to improve code readability.
...
Signed-off-by: Faraz Samapoor <f.samapoor@gmail.com >
2023-06-02 15:26:55 +03:30
b186cffdbe
Use default page size for jumping to desired offset
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-05-25 11:31:29 +02:00
b6c17c6ce7
Clear up return types
...
usersInGroup index by int for BC, searchInGroup index by uid (string).
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-04-27 12:00:45 +02:00
f3cd559c54
perform exact Ldap search as well to make sure it works for attributes without a substr matching rule
...
Signed-off-by: Julien Veyssier <eneiluj@posteo.net >
2023-04-13 19:59:17 +00:00
51705da7a4
Log a warning when a user or group is mapped with a suffix
...
Most of the time, this is the result of a misconfiguration by the admin
and is not what is expected.
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-04-04 14:08:24 +02:00
3c0b1bdc30
Remove redundant cast to string in user_ldap
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2023-01-02 15:11:13 +01:00
9e1dd52c99
Cache the fetched list of groups
...
Signed-off-by: Côme Chilliet <come.chilliet@nextcloud.com >
2022-11-17 15:12:24 +01:00
00c4c3d723
Merge pull request #30223 from nextcloud/nested_ldap_groups
...
Nested ldap groups
2022-10-20 15:03:37 +02:00
Côme Chilliet
Marcel Klehr
Arthur Schiwon
Carl Schwan
Ferdinand Thiessen
Daniel Kesselberg
Joas Schilling
provokateurin
Côme Chilliet
Carl Schwan
Andy Scherzinger
Hamid Dehnavi
Aaron Dewes
Faraz Samapoor
Julien Veyssier