Files
nextcloud-server-mirror/apps/files_sharing/tests/Controller/ExternalShareControllerTest.php
Robin Appelman 489eb418b4 refactor: always make user in external share manager explicit
relying on the session user is inconsistent as there might not be a logged in user, or the logged in user might not be the recipient of the share (reshares)

Signed-off-by: Robin Appelman <robin@icewind.nl>
2026-09-21 17:30:15 +02:00

96 lines
2.6 KiB
PHP

<?php
/**
* SPDX-FileCopyrightText: 2019-2024 Nextcloud GmbH and Nextcloud contributors
* SPDX-FileCopyrightText: 2016 ownCloud, Inc.
* SPDX-License-Identifier: AGPL-3.0-only
*/
namespace OCA\Files_Sharing\Tests\Controllers;
use OCA\Files_Sharing\Controller\ExternalSharesController;
use OCA\Files_Sharing\External\ExternalShare;
use OCA\Files_Sharing\External\Manager;
use OCP\AppFramework\Http\JSONResponse;
use OCP\BackgroundJob\IJobList;
use OCP\IRequest;
use OCP\IUser;
use OCP\IUserSession;
use PHPUnit\Framework\MockObject\MockObject;
/**
* Class ExternalShareControllerTest
*
* @package OCA\Files_Sharing\Controllers
*/
class ExternalShareControllerTest extends \Test\TestCase {
private IRequest&MockObject $request;
private Manager&MockObject $externalManager;
private IJobList&MockObject $jobList;
private IUser $user;
protected function setUp(): void {
parent::setUp();
$this->request = $this->createMock(IRequest::class);
$this->externalManager = $this->createMock(Manager::class);
$this->jobList = $this->createMock(IJobList::class);
$this->user = $this->createMock(IUser::class);
$this->user->method('getUID')->willReturn('user');
}
public function getExternalShareController(): ExternalSharesController {
$session = $this->createMock(IUserSession::class);
$session->method('getUser')
->willReturn($this->user);
return new ExternalSharesController(
'files_sharing',
$this->request,
$this->externalManager,
$this->jobList,
$session,
);
}
public function testIndex(): void {
$this->externalManager
->expects($this->once())
->method('getOpenShares')
->willReturn(['MyDummyArray']);
$this->assertEquals(new JSONResponse(['MyDummyArray']), $this->getExternalShareController()->index());
}
public function testCreate(): void {
$share = $this->createMock(ExternalShare::class);
$this->externalManager
->expects($this->once())
->method('getShare')
->with('4', $this->user)
->willReturn($share);
$this->externalManager
->expects($this->once())
->method('acceptShare')
->with($share, $this->user);
$this->jobList
->expects($this->once())
->method('add');
$this->assertEquals(new JSONResponse(), $this->getExternalShareController()->create('4'));
}
public function testDestroy(): void {
$share = $this->createMock(ExternalShare::class);
$this->externalManager
->expects($this->once())
->method('getShare')
->with('4', $this->user)
->willReturn($share);
$this->externalManager
->expects($this->once())
->method('declineShare')
->with($share, $this->user);
$this->assertEquals(new JSONResponse(), $this->getExternalShareController()->destroy('4'));
}
}