Files
nextcloud-server-mirror/apps/settings/tests/Controller/AuthSettingsControllerTest.php
2026-08-26 11:45:08 +02:00

663 lines
21 KiB
PHP

<?php
/**
* SPDX-FileCopyrightText: 2019-2024 Nextcloud GmbH and Nextcloud contributors
* SPDX-FileCopyrightText: 2016 ownCloud, Inc.
* SPDX-License-Identifier: AGPL-3.0-only
*/
namespace Test\Settings\Controller;
use OC\AppFramework\Http;
use OC\Authentication\Exceptions\ExpiredTokenException;
use OC\Authentication\Exceptions\InvalidTokenException;
use OC\Authentication\Token\IProvider;
use OC\Authentication\Token\IToken;
use OC\Authentication\Token\IWipeableToken;
use OC\Authentication\Token\PublicKeyToken;
use OC\Authentication\Token\RemoteWipe;
use OCA\Settings\Activity\Provider;
use OCA\Settings\Controller\AuthSettingsController;
use OCP\Activity\IEvent;
use OCP\Activity\IManager;
use OCP\AppFramework\Http\JSONResponse;
use OCP\AppFramework\Services\IAppConfig;
use OCP\Authentication\Exceptions\WipeTokenException;
use OCP\IConfig;
use OCP\IL10N;
use OCP\IRequest;
use OCP\ISession;
use OCP\IUserSession;
use OCP\Security\ISecureRandom;
use OCP\Session\Exceptions\SessionNotAvailableException;
use PHPUnit\Framework\MockObject\MockObject;
use Psr\Log\LoggerInterface;
use Test\TestCase;
class AuthSettingsControllerTest extends TestCase {
private IRequest&MockObject $request;
private IProvider&MockObject $tokenProvider;
private ISession&MockObject $session;
private IUserSession&MockObject $userSession;
private ISecureRandom&MockObject $secureRandom;
private IManager&MockObject $activityManager;
private IAppConfig&MockObject $appConfig;
private RemoteWipe&MockObject $remoteWipe;
private IConfig&MockObject $serverConfig;
private IL10N&MockObject $l;
private string $uid = 'jane';
private AuthSettingsController $controller;
protected function setUp(): void {
parent::setUp();
$this->request = $this->createMock(IRequest::class);
$this->tokenProvider = $this->createMock(IProvider::class);
$this->session = $this->createMock(ISession::class);
$this->userSession = $this->createMock(IUserSession::class);
$this->secureRandom = $this->createMock(ISecureRandom::class);
$this->activityManager = $this->createMock(IManager::class);
$this->appConfig = $this->createMock(IAppConfig::class);
$this->remoteWipe = $this->createMock(RemoteWipe::class);
$this->serverConfig = $this->createMock(IConfig::class);
/** @var LoggerInterface&MockObject $logger */
$logger = $this->createMock(LoggerInterface::class);
$this->l = $this->createMock(IL10N::class);
$this->controller = new AuthSettingsController(
'core',
$this->request,
$this->tokenProvider,
$this->session,
$this->secureRandom,
$this->uid,
$this->userSession,
$this->activityManager,
$this->appConfig,
$this->remoteWipe,
$logger,
$this->serverConfig,
$this->l,
);
}
public function testCreate(): void {
$name = 'Nexus 4';
$sessionToken = $this->createMock(IToken::class);
$deviceToken = $this->createMock(IToken::class);
$password = '123456';
$this->serverConfig->method('getSystemValueBool')
->with('auth_can_create_app_token', true)
->willReturn(true);
$this->session->expects($this->once())
->method('getId')
->willReturn('sessionid');
$this->tokenProvider->expects($this->once())
->method('getToken')
->with('sessionid')
->willReturn($sessionToken);
$this->tokenProvider->expects($this->once())
->method('getPassword')
->with($sessionToken, 'sessionid')
->willReturn($password);
$sessionToken->expects($this->once())
->method('getLoginName')
->willReturn('User13');
$this->secureRandom->expects($this->exactly(5))
->method('generate')
->with(5, ISecureRandom::CHAR_HUMAN_READABLE)
->willReturn('XXXXX');
$newToken = 'XXXXX-XXXXX-XXXXX-XXXXX-XXXXX';
$this->tokenProvider->expects($this->once())
->method('generateToken')
->with($newToken, $this->uid, 'User13', $password, $name, IToken::PERMANENT_TOKEN)
->willReturn($deviceToken);
$deviceToken->expects($this->once())
->method('jsonSerialize')
->willReturn(['dummy' => 'dummy', 'canDelete' => true]);
$this->mockActivityManager();
$expected = [
'token' => $newToken,
'deviceToken' => ['dummy' => 'dummy', 'canDelete' => true, 'canRename' => true],
'loginName' => 'User13',
];
$response = $this->controller->create($name);
$this->assertInstanceOf(JSONResponse::class, $response);
$this->assertEquals($expected, $response->getData());
}
public function testCreateDisabledBySystemConfig(): void {
$name = 'Nexus 4';
$this->serverConfig->method('getSystemValueBool')
->with('auth_can_create_app_token', true)
->willReturn(false);
$this->session->expects($this->once())
->method('getId')
->willReturn('sessionid');
$this->tokenProvider->expects($this->never())
->method('getToken');
$this->tokenProvider->expects($this->never())
->method('getPassword');
$this->tokenProvider->expects($this->never())
->method('generateToken');
$expected = new JSONResponse();
$expected->setStatus(Http::STATUS_SERVICE_UNAVAILABLE);
$this->assertEquals($expected, $this->controller->create($name));
}
public function testCreateSessionNotAvailable(): void {
$name = 'personal phone';
$this->session->expects($this->once())
->method('getId')
->willThrowException(new SessionNotAvailableException());
$expected = new JSONResponse();
$expected->setStatus(Http::STATUS_SERVICE_UNAVAILABLE);
$this->assertEquals($expected, $this->controller->create($name));
}
public function testCreateInvalidToken(): void {
$name = 'Company IPhone';
$this->serverConfig->method('getSystemValueBool')
->with('auth_can_create_app_token', true)
->willReturn(true);
$this->session->expects($this->once())
->method('getId')
->willReturn('sessionid');
$this->tokenProvider->expects($this->once())
->method('getToken')
->with('sessionid')
->willThrowException(new InvalidTokenException());
$expected = new JSONResponse();
$expected->setStatus(Http::STATUS_SERVICE_UNAVAILABLE);
$this->assertEquals($expected, $this->controller->create($name));
}
public function testDestroy(): void {
$tokenId = 124;
$token = $this->createMock(PublicKeyToken::class);
$this->mockGetTokenById($tokenId, $token);
$this->mockActivityManager();
$token->expects($this->exactly(2))
->method('getId')
->willReturn($tokenId);
$token->expects($this->once())
->method('getUID')
->willReturn('jane');
$this->tokenProvider->expects($this->once())
->method('invalidateTokenById')
->with($this->uid, $tokenId);
$this->assertEquals([], $this->controller->destroy($tokenId)->getData());
}
public function testDestroyExpired(): void {
$tokenId = 124;
$token = $this->createMock(PublicKeyToken::class);
$token->expects($this->exactly(2))
->method('getId')
->willReturn($tokenId);
$token->expects($this->once())
->method('getUID')
->willReturn($this->uid);
$this->tokenProvider->expects($this->once())
->method('getTokenById')
->with($this->equalTo($tokenId))
->willThrowException(new ExpiredTokenException($token));
$this->tokenProvider->expects($this->once())
->method('invalidateTokenById')
->with($this->uid, $tokenId);
$this->assertSame([], $this->controller->destroy($tokenId)->getData());
}
public function testDestroyWipePendingEmitsCancelledSubject(): void {
$tokenId = 125;
$token = $this->createMock(PublicKeyToken::class);
$token->method('getId')->willReturn($tokenId);
$token->method('getName')->willReturn('My phone');
$this->tokenProvider->expects($this->once())
->method('getTokenById')
->with($tokenId)
->willThrowException(new WipeTokenException($token));
// The token is still invalidated (the user opted into cancelling the wipe).
$this->tokenProvider->expects($this->once())
->method('invalidateTokenById')
->with($this->uid, $tokenId);
// Activity event must use the distinguishing subject.
$event = $this->createMock(IEvent::class);
$event->method('setApp')->willReturnSelf();
$event->method('setType')->willReturnSelf();
$event->method('setAffectedUser')->willReturnSelf();
$event->method('setAuthor')->willReturnSelf();
$event->method('setObject')->willReturnSelf();
$event->expects($this->once())
->method('setSubject')
->with(\OCA\Settings\Activity\Provider::APP_TOKEN_DELETED_WIPE_CANCELLED, ['name' => 'My phone'])
->willReturnSelf();
$this->activityManager->expects($this->once())
->method('generateEvent')
->willReturn($event);
$this->activityManager->expects($this->once())
->method('publish');
$this->assertEquals([], $this->controller->destroy($tokenId)->getData());
}
public function testDestroyOthersRevokesEveryTokenButTheCurrent(): void {
$currentToken = $this->mockAuthToken(10);
$otherToken = $this->mockAuthToken(11);
$appPassword = $this->mockAuthToken(12);
$this->session->method('getId')->willReturn('sessionid');
$this->tokenProvider->expects($this->once())
->method('getToken')
->with('sessionid')
->willReturn($currentToken);
$this->tokenProvider->expects($this->once())
->method('getTokenByUser')
->with($this->uid)
->willReturn([$currentToken, $otherToken, $appPassword]);
$revokedIds = [];
$this->tokenProvider->expects($this->exactly(2))
->method('invalidateTokenById')
->willReturnCallback(function (string $uid, int $id) use (&$revokedIds): void {
$this->assertSame($this->uid, $uid);
$revokedIds[] = $id;
});
$this->mockActivityManager();
$response = $this->controller->destroyOthers();
$this->assertSame([11, 12], $revokedIds, 'the current session token must not be revoked');
$this->assertSame(['revoked' => [11, 12]], $response->getData());
}
public function testDestroyOthersKeepsWipePendingTokens(): void {
$currentToken = $this->mockAuthToken(10);
$otherToken = $this->mockAuthToken(11);
$wipingToken = $this->mockAuthToken(12, IToken::WIPE_TOKEN);
$this->session->method('getId')->willReturn('sessionid');
$this->tokenProvider->method('getToken')->willReturn($currentToken);
$this->tokenProvider->method('getTokenByUser')->willReturn([$currentToken, $otherToken, $wipingToken]);
$this->tokenProvider->expects($this->once())
->method('invalidateTokenById')
->with($this->uid, 11);
$this->mockActivityManager();
$this->assertSame(['revoked' => [11]], $this->controller->destroyOthers()->getData());
}
public function testDestroyOthersPublishesOneAggregateActivity(): void {
$currentToken = $this->mockAuthToken(10);
$this->session->method('getId')->willReturn('sessionid');
$this->tokenProvider->method('getToken')->willReturn($currentToken);
$this->tokenProvider->method('getTokenByUser')
->willReturn([$currentToken, $this->mockAuthToken(11), $this->mockAuthToken(12)]);
$event = $this->createMock(IEvent::class);
$event->method('setApp')->willReturnSelf();
$event->method('setType')->willReturnSelf();
$event->method('setAffectedUser')->willReturnSelf();
$event->method('setAuthor')->willReturnSelf();
$event->expects($this->once())
->method('setSubject')
->with(Provider::APP_TOKEN_DELETED_ALL, ['count' => 2])
->willReturnSelf();
// Aggregate event, so there is no single app_token to attach.
$event->expects($this->never())
->method('setObject');
$this->activityManager->expects($this->once())
->method('generateEvent')
->willReturn($event);
$this->activityManager->expects($this->once())
->method('publish');
$this->controller->destroyOthers();
}
public function testDestroyOthersWithNothingToRevokePublishesNoActivity(): void {
$currentToken = $this->mockAuthToken(10);
$this->session->method('getId')->willReturn('sessionid');
$this->tokenProvider->method('getToken')->willReturn($currentToken);
$this->tokenProvider->method('getTokenByUser')->willReturn([$currentToken]);
$this->tokenProvider->expects($this->never())->method('invalidateTokenById');
$this->activityManager->expects($this->never())->method('publish');
$this->assertSame(['revoked' => []], $this->controller->destroyOthers()->getData());
}
public function testDestroyOthersWithAppPassword(): void {
$this->session->expects($this->once())
->method('exists')
->with('app_password')
->willReturn(true);
$this->tokenProvider->expects($this->never())->method('invalidateTokenById');
$response = $this->controller->destroyOthers();
$this->assertSame(Http::STATUS_BAD_REQUEST, $response->getStatus());
}
public function testDestroyOthersWhileImpersonating(): void {
$this->userSession->method('getImpersonatingUserID')->willReturn('admin');
$this->tokenProvider->expects($this->never())->method('invalidateTokenById');
$response = $this->controller->destroyOthers();
$this->assertSame(Http::STATUS_SERVICE_UNAVAILABLE, $response->getStatus());
}
public function testDestroyOthersSessionNotAvailable(): void {
$this->session->method('getId')
->willThrowException(new SessionNotAvailableException());
$this->tokenProvider->expects($this->never())->method('invalidateTokenById');
$response = $this->controller->destroyOthers();
$this->assertSame(Http::STATUS_SERVICE_UNAVAILABLE, $response->getStatus());
}
public function testDestroyOthersInvalidSessionToken(): void {
$this->session->method('getId')->willReturn('sessionid');
$this->tokenProvider->method('getToken')
->willThrowException(new InvalidTokenException('Token does not exist'));
$this->tokenProvider->expects($this->never())->method('invalidateTokenById');
$response = $this->controller->destroyOthers();
$this->assertSame(Http::STATUS_SERVICE_UNAVAILABLE, $response->getStatus());
}
public function testDestroyWrongUser(): void {
$tokenId = 124;
$token = $this->createMock(PublicKeyToken::class);
$this->mockGetTokenById($tokenId, $token);
$token->expects($this->once())
->method('getUID')
->willReturn('foobar');
$response = $this->controller->destroy($tokenId);
$this->assertSame([], $response->getData());
$this->assertSame(\OCP\AppFramework\Http::STATUS_NOT_FOUND, $response->getStatus());
}
public static function dataRenameToken(): array {
return [
'App password => Other token name' => ['App password', 'Other token name'],
'Other token name => App password' => ['Other token name', 'App password'],
];
}
#[\PHPUnit\Framework\Attributes\DataProvider(methodName: 'dataRenameToken')]
public function testUpdateRename(string $name, string $newName): void {
$tokenId = 42;
$token = $this->createMock(PublicKeyToken::class);
$this->mockGetTokenById($tokenId, $token);
$this->mockActivityManager();
$token->expects($this->once())
->method('getUID')
->willReturn('jane');
$token->expects($this->once())
->method('getName')
->willReturn($name);
$token->expects($this->once())
->method('getScopeAsArray')
->willReturn([IToken::SCOPE_FILESYSTEM => true]);
$token->expects($this->once())
->method('setName')
->with($this->equalTo($newName));
$this->tokenProvider->expects($this->once())
->method('updateToken')
->with($this->equalTo($token));
$this->assertSame([], $this->controller->update($tokenId, [IToken::SCOPE_FILESYSTEM => true], $newName)->getData());
}
public static function dataUpdateFilesystemScope(): array {
return [
'Grant filesystem access' => [false, true],
'Revoke filesystem access' => [true, false],
];
}
#[\PHPUnit\Framework\Attributes\DataProvider(methodName: 'dataUpdateFilesystemScope')]
public function testUpdateFilesystemScope(bool $filesystem, bool $newFilesystem): void {
$tokenId = 42;
$token = $this->createMock(PublicKeyToken::class);
$this->mockGetTokenById($tokenId, $token);
$this->mockActivityManager();
$token->expects($this->once())
->method('getUID')
->willReturn('jane');
$token->expects($this->once())
->method('getName')
->willReturn('App password');
$token->expects($this->once())
->method('getScopeAsArray')
->willReturn([IToken::SCOPE_FILESYSTEM => $filesystem]);
$token->expects($this->once())
->method('setScope')
->with($this->equalTo([IToken::SCOPE_FILESYSTEM => $newFilesystem]));
$this->tokenProvider->expects($this->once())
->method('updateToken')
->with($this->equalTo($token));
$this->assertSame([], $this->controller->update($tokenId, [IToken::SCOPE_FILESYSTEM => $newFilesystem], 'App password')->getData());
}
public function testUpdateNoChange(): void {
$tokenId = 42;
$token = $this->createMock(PublicKeyToken::class);
$this->mockGetTokenById($tokenId, $token);
$token->expects($this->once())
->method('getUID')
->willReturn('jane');
$token->expects($this->once())
->method('getName')
->willReturn('App password');
$token->expects($this->once())
->method('getScopeAsArray')
->willReturn([IToken::SCOPE_FILESYSTEM => true]);
$token->expects($this->never())
->method('setName');
$token->expects($this->never())
->method('setScope');
$this->tokenProvider->expects($this->once())
->method('updateToken')
->with($this->equalTo($token));
$this->assertSame([], $this->controller->update($tokenId, [IToken::SCOPE_FILESYSTEM => true], 'App password')->getData());
}
public function testUpdateExpired(): void {
$tokenId = 42;
$token = $this->createMock(PublicKeyToken::class);
$token->expects($this->once())
->method('getUID')
->willReturn($this->uid);
$this->tokenProvider->expects($this->once())
->method('getTokenById')
->with($this->equalTo($tokenId))
->willThrowException(new ExpiredTokenException($token));
$this->tokenProvider->expects($this->once())
->method('updateToken')
->with($this->equalTo($token));
$this->assertSame([], $this->controller->update($tokenId, [IToken::SCOPE_FILESYSTEM => true], 'App password')->getData());
}
public function testUpdateTokenWrongUser(): void {
$tokenId = 42;
$token = $this->createMock(PublicKeyToken::class);
$this->mockGetTokenById($tokenId, $token);
$token->expects($this->once())
->method('getUID')
->willReturn('foobar');
$token->expects($this->never())
->method('setScope');
$this->tokenProvider->expects($this->never())
->method('updateToken');
$response = $this->controller->update($tokenId, [IToken::SCOPE_FILESYSTEM => true], 'App password');
$this->assertSame([], $response->getData());
$this->assertSame(\OCP\AppFramework\Http::STATUS_NOT_FOUND, $response->getStatus());
}
public function testUpdateTokenNonExisting(): void {
$this->tokenProvider->expects($this->once())
->method('getTokenById')
->with($this->equalTo(42))
->willThrowException(new InvalidTokenException('Token does not exist'));
$this->tokenProvider->expects($this->never())
->method('updateToken');
$response = $this->controller->update(42, [IToken::SCOPE_FILESYSTEM => true], 'App password');
$this->assertSame([], $response->getData());
$this->assertSame(\OCP\AppFramework\Http::STATUS_NOT_FOUND, $response->getStatus());
}
private function mockAuthToken(int $id, int $type = IToken::PERMANENT_TOKEN): PublicKeyToken&MockObject {
$token = $this->createMock(PublicKeyToken::class);
$token->method('getId')->willReturn($id);
$token->method('getType')->willReturn($type);
return $token;
}
private function mockActivityManager(): void {
$this->activityManager->expects($this->once())
->method('generateEvent')
->willReturn($this->createMock(IEvent::class));
$this->activityManager->expects($this->once())
->method('publish');
}
/**
* @param int $tokenId
* @param $token
*/
private function mockGetTokenById(int $tokenId, $token): void {
$this->tokenProvider->expects($this->once())
->method('getTokenById')
->with($this->equalTo($tokenId))
->willReturn($token);
}
public function testRemoteWipeNotSuccessful(): void {
$token = $this->createMock(IToken::class);
$token->expects($this->once())
->method('getUID')
->willReturn($this->uid);
$this->mockGetTokenById(123, $token);
$this->remoteWipe->expects($this->once())
->method('markTokenForWipe')
->with($token)
->willReturn(false);
$response = $this->controller->wipe(123);
$expected = new JSONResponse([], Http::STATUS_BAD_REQUEST);
$this->assertEquals($expected, $response);
}
public function testRemoteWipeWrongUser(): void {
$token = $this->createMock(IToken::class);
$token->expects($this->once())
->method('getUID')
->willReturn('definetly-not-' . $this->uid);
$this->mockGetTokenById(123, $token);
$this->remoteWipe->expects($this->never())
->method('markTokenForWipe');
$response = $this->controller->wipe(123);
$expected = new JSONResponse([], Http::STATUS_NOT_FOUND);
$this->assertEquals($expected, $response);
}
public function testRemoteWipeSuccessful(): void {
$token = $this->createMock(IWipeableToken::class);
$token->expects($this->once())
->method('getUID')
->willReturn($this->uid);
$this->mockGetTokenById(123, $token);
$this->remoteWipe->expects($this->once())
->method('markTokenForWipe')
->with($token)
->willReturn(true);
$response = $this->controller->wipe(123);
$expected = new JSONResponse([]);
$this->assertEquals($expected, $response);
}
}