mirror of
https://github.com/nextcloud/server.git
synced 2026-11-14 06:32:09 +01:00
Git'Fellow
4920bd1725
PHP 8.3 allows class constants to declare a type. Adopt it where doing so cannot break third-party apps. Typing an inheritable constant is a hard BC break: a subclass that redeclares it untyped fails to load with "Type of C::FOO must be compatible with P::FOO of type string". Changes are therefore limited to constants that cannot be redeclared by a subclass: - private const (not inherited) - final public/protected const - constants declared in a final class or an enum Interface constants, trait constants, and public/protected constants in non-final (including abstract) classes are left untyped, as is all of lib/public (OCP) and lib/unstable (NCU). One review-requested exception: the public OBJECT_PREFIX/OBJECT_SUFFIX constants of the app-internal CalDAV import helpers (TextImporter, XmlImporter) are typed as well; these classes are not public API and have no subclasses. Only string, int and array are used. float is avoided because it would silently coerce an int literal and change === comparisons. No constant name or value is modified: every changed line adds only the type token, so runtime behaviour is unchanged. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
51 lines
1.3 KiB
PHP
51 lines
1.3 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
/**
|
|
* SPDX-FileCopyrightText: 2022 Nextcloud GmbH and Nextcloud contributors
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
namespace OC\Files\Config;
|
|
|
|
use OCP\IUser;
|
|
|
|
class LazyPathCachedMountInfo extends CachedMountInfo {
|
|
// we don't allow \ in paths so it makes a great placeholder
|
|
private const string PATH_PLACEHOLDER = '\\PLACEHOLDER\\';
|
|
|
|
/** @var callable(CachedMountInfo): string */
|
|
protected $rootInternalPathCallback;
|
|
|
|
/**
|
|
* @param IUser $user
|
|
* @param int $storageId
|
|
* @param int $rootId
|
|
* @param string $mountPoint
|
|
* @param string $mountProvider
|
|
* @param int|null $mountId
|
|
* @param callable(CachedMountInfo): string $rootInternalPathCallback
|
|
* @throws \Exception
|
|
*/
|
|
public function __construct(
|
|
IUser $user,
|
|
int $storageId,
|
|
int $rootId,
|
|
string $mountPoint,
|
|
string $mountProvider,
|
|
?int $mountId,
|
|
callable $rootInternalPathCallback,
|
|
) {
|
|
parent::__construct($user, $storageId, $rootId, $mountPoint, $mountProvider, $mountId, self::PATH_PLACEHOLDER);
|
|
$this->rootInternalPathCallback = $rootInternalPathCallback;
|
|
}
|
|
|
|
#[\Override]
|
|
public function getRootInternalPath(): string {
|
|
if ($this->rootInternalPath === self::PATH_PLACEHOLDER) {
|
|
$this->rootInternalPath = ($this->rootInternalPathCallback)($this);
|
|
}
|
|
return $this->rootInternalPath;
|
|
}
|
|
}
|