mirror of
https://github.com/nextcloud/server.git
synced 2026-10-09 21:51:10 +02:00
Git'Fellow
4920bd1725
PHP 8.3 allows class constants to declare a type. Adopt it where doing so cannot break third-party apps. Typing an inheritable constant is a hard BC break: a subclass that redeclares it untyped fails to load with "Type of C::FOO must be compatible with P::FOO of type string". Changes are therefore limited to constants that cannot be redeclared by a subclass: - private const (not inherited) - final public/protected const - constants declared in a final class or an enum Interface constants, trait constants, and public/protected constants in non-final (including abstract) classes are left untyped, as is all of lib/public (OCP) and lib/unstable (NCU). One review-requested exception: the public OBJECT_PREFIX/OBJECT_SUFFIX constants of the app-internal CalDAV import helpers (TextImporter, XmlImporter) are typed as well; these classes are not public API and have no subclasses. Only string, int and array are used. float is avoided because it would silently coerce an int literal and change === comparisons. No constant name or value is modified: every changed line adds only the type token, so runtime behaviour is unchanged. Signed-off-by: Git'Fellow <12234510+solracsf@users.noreply.github.com>
103 lines
2.4 KiB
PHP
103 lines
2.4 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
/**
|
|
* SPDX-FileCopyrightText: 2021 Nextcloud GmbH and Nextcloud contributors
|
|
* SPDX-License-Identifier: AGPL-3.0-or-later
|
|
*/
|
|
|
|
namespace OC\Security\RateLimiting\Backend;
|
|
|
|
use OCP\AppFramework\Utility\ITimeFactory;
|
|
use OCP\DB\Exception;
|
|
use OCP\DB\QueryBuilder\IQueryBuilder;
|
|
use OCP\IConfig;
|
|
use OCP\IDBConnection;
|
|
|
|
class DatabaseBackend implements IBackend {
|
|
private const string TABLE_NAME = 'ratelimit_entries';
|
|
|
|
public function __construct(
|
|
private IConfig $config,
|
|
private IDBConnection $dbConnection,
|
|
private ITimeFactory $timeFactory,
|
|
) {
|
|
}
|
|
|
|
private function hash(
|
|
string $methodIdentifier,
|
|
string $userIdentifier,
|
|
): string {
|
|
return hash('sha512', $methodIdentifier . $userIdentifier);
|
|
}
|
|
|
|
/**
|
|
* @throws Exception
|
|
*/
|
|
private function getExistingAttemptCount(
|
|
string $identifier,
|
|
): int {
|
|
$currentTime = $this->timeFactory->getDateTime();
|
|
|
|
$qb = $this->dbConnection->getQueryBuilder();
|
|
$qb->delete(self::TABLE_NAME)
|
|
->where(
|
|
$qb->expr()->lte('delete_after', $qb->createNamedParameter($currentTime, IQueryBuilder::PARAM_DATETIME_MUTABLE))
|
|
)
|
|
->executeStatement();
|
|
|
|
$qb = $this->dbConnection->getQueryBuilder();
|
|
$qb->select($qb->func()->count())
|
|
->from(self::TABLE_NAME)
|
|
->where(
|
|
$qb->expr()->eq('hash', $qb->createNamedParameter($identifier, IQueryBuilder::PARAM_STR))
|
|
);
|
|
|
|
$cursor = $qb->executeQuery();
|
|
$row = $cursor->fetchOne();
|
|
$cursor->closeCursor();
|
|
|
|
return (int)$row;
|
|
}
|
|
|
|
/**
|
|
* {@inheritDoc}
|
|
*/
|
|
#[\Override]
|
|
public function getAttempts(
|
|
string $methodIdentifier,
|
|
string $userIdentifier,
|
|
): int {
|
|
$identifier = $this->hash($methodIdentifier, $userIdentifier);
|
|
return $this->getExistingAttemptCount($identifier);
|
|
}
|
|
|
|
/**
|
|
* {@inheritDoc}
|
|
*/
|
|
#[\Override]
|
|
public function registerAttempt(
|
|
string $methodIdentifier,
|
|
string $userIdentifier,
|
|
int $period,
|
|
): void {
|
|
$identifier = $this->hash($methodIdentifier, $userIdentifier);
|
|
$deleteAfter = $this->timeFactory->getDateTime()->add(new \DateInterval("PT{$period}S"));
|
|
|
|
$qb = $this->dbConnection->getQueryBuilder();
|
|
|
|
$qb->insert(self::TABLE_NAME)
|
|
->values([
|
|
'hash' => $qb->createNamedParameter($identifier, IQueryBuilder::PARAM_STR),
|
|
'delete_after' => $qb->createNamedParameter($deleteAfter, IQueryBuilder::PARAM_DATETIME_MUTABLE),
|
|
]);
|
|
|
|
if (!$this->config->getSystemValueBool('ratelimit.protection.enabled', true)) {
|
|
return;
|
|
}
|
|
|
|
$qb->executeStatement();
|
|
}
|
|
}
|