Files
Carl Schwan 95ff61288a fix(preview): send the whole JPEG to Imaginary
Read the EXIF data through a separate stream and send the file stream
unchanged.

Assisted-by: ClaudeCode:claude-opus-5-5
Signed-off-by: Carl Schwan <carl@carlschwan.eu>
2026-11-06 15:17:41 +01:00

106 lines
3.5 KiB
PHP

<?php
declare(strict_types=1);
/**
* SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors
* SPDX-License-Identifier: AGPL-3.0-or-later
*/
namespace Test\Preview;
use OC\Preview\Imaginary;
use OCP\Files\File;
use OCP\Http\Client\IClient;
use OCP\Http\Client\IClientService;
use OCP\Http\Client\IResponse;
use PHPUnit\Framework\Attributes\TestWith;
use Psr\Http\Message\StreamInterface;
use Test\TestCase;
class ImaginaryTest extends TestCase {
private IClient $client;
#[\Override]
protected function setUp(): void {
parent::setUp();
$this->overwriteSystemConfig('preview_imaginary_url', 'http://imaginary');
$this->client = $this->createMock(IClient::class);
$clientService = $this->createMock(IClientService::class);
$clientService->method('newClient')->willReturn($this->client);
$this->overwriteService(IClientService::class, $clientService);
}
#[\Override]
protected function tearDown(): void {
$this->restoreService(IClientService::class);
parent::tearDown();
}
private function getJpeg(?int $orientation, bool $large = false): string {
$image = imagecreatetruecolor($large ? 600 : 40, $large ? 600 : 30);
if ($large) {
// Noise does not compress, the image data gets larger than the part read for the orientation
for ($x = 0; $x < 600; $x++) {
for ($y = 0; $y < 600; $y++) {
imagesetpixel($image, $x, $y, mt_rand(0, 0xffffff));
}
}
}
ob_start();
imagejpeg($image, null, 100);
$jpeg = ob_get_clean();
$segments = '';
if ($orientation !== null) {
// EXIF segment with only the orientation
$tiff = "II*\0" . pack('V', 8) . pack('v', 1) . pack('vvVvv', 0x0112, 3, 1, $orientation, 0) . pack('V', 0);
$segments .= "\xFF\xE1" . pack('n', 2 + 6 + strlen($tiff)) . "Exif\0\0" . $tiff;
}
return substr($jpeg, 0, 2) . $segments . substr($jpeg, 2);
}
#[TestWith([null, false, false])]
#[TestWith([1, false, false])]
#[TestWith([6, true, false])]
#[TestWith([null, false, true])]
#[TestWith([6, true, true])]
public function testAutorotateOnlyWhenNeeded(?int $orientation, bool $expectAutorotate, bool $large): void {
$jpeg = $this->getJpeg($orientation, $large);
$file = $this->createMock(File::class);
$file->method('getSize')->willReturn(strlen($jpeg));
$file->method('getMimeType')->willReturn('image/jpeg');
$file->method('fopen')->willReturnCallback(function () use ($jpeg) {
$stream = fopen('php://memory', 'r+');
fwrite($stream, $jpeg);
rewind($stream);
return $stream;
});
$response = $this->createMock(IResponse::class);
$response->method('getStatusCode')->willReturn(200);
$response->method('getHeader')->willReturn('');
$responseBody = fopen('php://memory', 'r+');
fwrite($responseBody, $this->getJpeg(null));
rewind($responseBody);
$response->method('getBody')->willReturn($responseBody);
$this->client->expects($this->once())
->method('post')
->willReturnCallback(function (string $url, array $options) use ($jpeg, $expectAutorotate, $response): IResponse {
$operations = array_column(json_decode($options['query']['operations'], true), 'operation');
$this->assertSame($expectAutorotate ? ['autorotate', 'fit'] : ['fit'], $operations);
// Read from the start, like the HTTP client does
$body = $options['body'];
$this->assertSame($jpeg, $body instanceof StreamInterface ? (string)$body : stream_get_contents($body, -1, 0));
return $response;
});
$preview = (new Imaginary([]))->getThumbnail($file, 256, 256);
$this->assertNotNull($preview);
}
}