mirror of
https://github.com/nextcloud/server.git
synced 2026-11-09 02:14:48 +01:00
The taint analysis job was forced to a single thread, which made it the slowest Psalm job (8-20 min) and the critical path of the workflow. The psalm:security composer script already passes --threads=$(nproc). Local measurements on master (Psalm 6.20, 4 CPUs) show identical results with 1, 4 and 8 threads, including cross-file taint flows, while the run time drops from ~345s to ~70s. Peak memory grows from ~4.5GB to ~8GB, which fits the 16GB runners. Assisted-by: ClaudeCode:claude-opus-5-5 Signed-off-by: Ferdinand Thiessen <opensource@fthiessen.de>
245 lines
7.7 KiB
YAML
245 lines
7.7 KiB
YAML
# SPDX-FileCopyrightText: 2020 Nextcloud GmbH and Nextcloud contributors
|
|
# SPDX-License-Identifier: MIT
|
|
name: Psalm static code analysis
|
|
|
|
on:
|
|
pull_request:
|
|
push:
|
|
branches:
|
|
- main
|
|
- master
|
|
- stable*
|
|
paths:
|
|
- '.github/workflows/static-code-analysis.yml'
|
|
- '**.php'
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
concurrency:
|
|
group: static-code-analysis-${{ github.head_ref || github.run_id }}
|
|
cancel-in-progress: true
|
|
|
|
jobs:
|
|
changes:
|
|
runs-on: ubuntu-latest-low
|
|
|
|
outputs:
|
|
src: ${{ steps.changes.outputs.src }}
|
|
|
|
steps:
|
|
- uses: dorny/paths-filter@ceb8a2b8f2d89434be7ff52d3de7ec3738c5cc9d # v4.0.3
|
|
id: changes
|
|
continue-on-error: true
|
|
with:
|
|
filters: |
|
|
src:
|
|
- '.github/workflows/**'
|
|
- '3rdparty/**'
|
|
- '**/appinfo/**'
|
|
- '**/lib/**'
|
|
- '**/templates/**'
|
|
- 'vendor/**'
|
|
- 'vendor-bin/**'
|
|
- 'composer.json'
|
|
- 'composer.lock'
|
|
- 'psalm*.xml'
|
|
- 'build/psalm-baseline*.xml'
|
|
- '**.php'
|
|
|
|
static-code-analysis:
|
|
runs-on: ubuntu-latest
|
|
|
|
needs: changes
|
|
if: ${{ needs.changes.outputs.src != 'false' && github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
|
|
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1
|
|
with:
|
|
persist-credentials: false
|
|
submodules: true
|
|
|
|
- name: Set up php
|
|
uses: shivammathur/setup-php@eb7c497e18156a6bbabfef1d3a82760b9eda3962 # 2.40.0
|
|
timeout-minutes: 5
|
|
with:
|
|
php-version: '8.3'
|
|
extensions: apcu,ctype,curl,dom,fileinfo,ftp,gd,imagick,intl,json,ldap,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
|
|
coverage: none
|
|
env:
|
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
|
|
- name: Composer install
|
|
run: composer i
|
|
|
|
- name: Psalm
|
|
run: composer run psalm -- --threads=1 --monochrome --no-progress --output-format=github --update-baseline
|
|
|
|
- name: Show potential changes in Psalm baseline
|
|
if: always()
|
|
run: git diff --exit-code -- . ':!lib/composer'
|
|
|
|
static-code-analysis-security:
|
|
runs-on: ubuntu-latest
|
|
|
|
needs: changes
|
|
if: ${{ needs.changes.outputs.src != 'false' && github.repository_owner != 'nextcloud-gmbh' }}
|
|
|
|
permissions:
|
|
security-events: write
|
|
|
|
steps:
|
|
- name: Checkout code
|
|
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1
|
|
with:
|
|
persist-credentials: false
|
|
submodules: true
|
|
|
|
- name: Set up php
|
|
uses: shivammathur/setup-php@eb7c497e18156a6bbabfef1d3a82760b9eda3962 # 2.40.0
|
|
timeout-minutes: 5
|
|
with:
|
|
php-version: '8.3'
|
|
extensions: ctype,curl,dom,fileinfo,ftp,gd,imagick,intl,json,ldap,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
|
|
coverage: none
|
|
|
|
- name: Composer install
|
|
run: composer i
|
|
|
|
# psalm:security already sets --threads=$(nproc); passing --threads again makes Psalm fall back to a single thread
|
|
- name: Psalm taint analysis
|
|
run: composer run psalm:security -- --monochrome --no-progress --output-format=github --update-baseline --report=results.sarif --report-show-info=false
|
|
|
|
# Psalm exits 0 on taint findings when a report file is generated
|
|
- name: Fail on taint analysis findings
|
|
run: |
|
|
count=$(jq '[.runs[].results[]] | length' results.sarif)
|
|
echo "Taint analysis findings: $count"
|
|
test "$count" -eq 0
|
|
|
|
- name: Show potential changes in Psalm baseline
|
|
if: always()
|
|
run: git diff --exit-code -- . ':!lib/composer'
|
|
|
|
- name: Upload Security Analysis results to GitHub
|
|
if: always()
|
|
uses: github/codeql-action/upload-sarif@1c5b675653bb5c22dbe9b12b556ec555138e09fd # v4.38.1
|
|
with:
|
|
sarif_file: results.sarif
|
|
|
|
static-code-analysis-ocp:
|
|
runs-on: ubuntu-latest
|
|
|
|
needs: changes
|
|
if: ${{ needs.changes.outputs.src != 'false' && github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
|
|
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1
|
|
with:
|
|
persist-credentials: false
|
|
submodules: true
|
|
|
|
- name: Set up php
|
|
uses: shivammathur/setup-php@eb7c497e18156a6bbabfef1d3a82760b9eda3962 # 2.40.0
|
|
timeout-minutes: 5
|
|
with:
|
|
php-version: '8.3'
|
|
extensions: ctype,curl,dom,fileinfo,gd,imagick,intl,json,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
|
|
coverage: none
|
|
env:
|
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
|
|
- name: Composer install
|
|
run: composer i
|
|
|
|
- name: Psalm
|
|
run: composer run psalm:ocp -- --threads=1 --monochrome --no-progress --output-format=github --update-baseline
|
|
|
|
- name: Show potential changes in Psalm baseline
|
|
if: always()
|
|
run: git diff --exit-code -- . ':!lib/composer'
|
|
|
|
static-code-analysis-ncu:
|
|
runs-on: ubuntu-latest
|
|
|
|
needs: changes
|
|
if: ${{ needs.changes.outputs.src != 'false' && github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
|
|
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1
|
|
with:
|
|
persist-credentials: false
|
|
submodules: true
|
|
|
|
- name: Set up php
|
|
uses: shivammathur/setup-php@eb7c497e18156a6bbabfef1d3a82760b9eda3962 # 2.40.0
|
|
timeout-minutes: 5
|
|
with:
|
|
php-version: '8.3'
|
|
extensions: ctype,curl,dom,fileinfo,gd,imagick,intl,json,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
|
|
coverage: none
|
|
env:
|
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
|
|
- name: Composer install
|
|
run: composer i
|
|
|
|
- name: Psalm
|
|
run: composer run psalm:ncu -- --threads=1 --monochrome --no-progress --output-format=github
|
|
|
|
static-code-analysis-strict:
|
|
runs-on: ubuntu-latest
|
|
|
|
needs: changes
|
|
if: ${{ needs.changes.outputs.src != 'false' && github.event_name != 'push' && github.repository_owner != 'nextcloud-gmbh' }}
|
|
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1
|
|
with:
|
|
persist-credentials: false
|
|
submodules: true
|
|
|
|
- name: Set up php
|
|
uses: shivammathur/setup-php@eb7c497e18156a6bbabfef1d3a82760b9eda3962 # 2.40.0
|
|
with:
|
|
php-version: '8.3'
|
|
extensions: ctype,curl,dom,fileinfo,gd,imagick,intl,json,mbstring,openssl,pdo_sqlite,posix,sqlite,xml,zip
|
|
coverage: none
|
|
env:
|
|
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
|
|
|
|
- name: Composer install
|
|
run: composer i
|
|
|
|
- name: Psalm
|
|
run: composer run psalm:strict -- --threads=1 --monochrome --no-progress --output-format=github
|
|
|
|
summary:
|
|
permissions:
|
|
contents: none
|
|
runs-on: ubuntu-latest-low
|
|
needs: [changes, static-code-analysis, static-code-analysis-security, static-code-analysis-ocp, static-code-analysis-ncu, static-code-analysis-strict]
|
|
|
|
if: always()
|
|
|
|
name: static-code-analysis-summary
|
|
|
|
steps:
|
|
- name: Summary status
|
|
run: |
|
|
if ${{ needs.changes.outputs.src != 'false' && (
|
|
needs.static-code-analysis-security.result != 'success' ||
|
|
(github.event_name != 'push' && (
|
|
needs.static-code-analysis.result != 'success' ||
|
|
needs.static-code-analysis-ocp.result != 'success' ||
|
|
needs.static-code-analysis-ncu.result != 'success' ||
|
|
needs.static-code-analysis-strict.result != 'success'
|
|
))
|
|
) }}; then
|
|
exit 1
|
|
fi
|