From ba3a698a6741ebfc05052b2add720f8000cd0949 Mon Sep 17 00:00:00 2001 From: Sebastian Spaeth Date: Sun, 5 Feb 2012 12:23:49 +0100 Subject: [PATCH] No need to test for types.StringType all we want to know is if we got some string'ish type and testing for isinstance 'basestring' is sufficient for that. Remove the import. Signed-off-by: Sebastian Spaeth --- offlineimap/repository/IMAP.py | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/offlineimap/repository/IMAP.py b/offlineimap/repository/IMAP.py index d4b6599..f008592 100644 --- a/offlineimap/repository/IMAP.py +++ b/offlineimap/repository/IMAP.py @@ -20,7 +20,6 @@ from offlineimap import folder, imaputil, imapserver, OfflineImapError from offlineimap.folder.UIDMaps import MappedIMAPFolder from offlineimap.threadutil import ExitNotifyThread from threading import Event -import types import os from sys import exc_info import netrc @@ -274,9 +273,9 @@ class IMAPRepository(BaseRepository): self.imapserver.releaseconnection(imapobj) for string in listresult: if string == None or \ - (type(string) == types.StringType and string == ''): + (isinstance(string, basestring) and string == ''): # Bug in imaplib: empty strings in results from - # literals. + # literals. TODO: still relevant? continue flags, delim, name = imaputil.imapsplit(string) flaglist = [x.lower() for x in imaputil.flagsplit(flags)]