averello/sourcekit-lsp
1
0
Fork 0
mirror of https://github.com/apple/sourcekit-lsp.git synced 2026-03-02 18:23:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

Shift responsibility for in-order message handling from Connection to SourceKitServer

Browse Source 
This generally seems like the cleaner design because `SourceKitServer` is actually able to semantically inspect the message and decide whether it can be handled concurrently with other requests.
This commit is contained in:
Alex Hoppen
2023-10-02 17:27:57 -07:00
parent edfda7d743
commit 1f02b95e55
6 changed files with 218 additions and 184 deletions
Download Patch File Download Diff File Expand all files Collapse all files

25
Sources/SKCore/BuildServerBuildSystem.swift
View File

@@ -51,6 +51,17 @@ public actor BuildServerBuildSystem: MessageHandler {
var buildServer: JSONRPCConnection?
/// The queue on which all messages that originate from the build server are
/// handled.
///
/// These are requests and notifications sent *from* the build server,
/// not replies from the build server.
///
/// This ensures that messages from the build server are handled in the order
/// they were received. Swift concurrency does not guarentee in-order
/// execution of tasks.
public let bspMessageHandlingQueue = AsyncQueue(.serial)
let searchPaths: [AbsolutePath]
public private(set) var indexDatabasePath: AbsolutePath?
@@ -167,18 +178,20 @@ public actor BuildServerBuildSystem: MessageHandler {
/// the build server has sent us a notification.
///
/// We need to notify the delegate about any updated build settings.
public func handle(_ params: some NotificationType, from clientID: ObjectIdentifier) async {
if let params = params as? BuildTargetsChangedNotification {
await self.handleBuildTargetsChanged(Notification(params, clientID: clientID))
} else if let params = params as? FileOptionsChangedNotification {
await self.handleFileOptionsChanged(Notification(params, clientID: clientID))
public nonisolated func handle(_ params: some NotificationType, from clientID: ObjectIdentifier) {
bspMessageHandlingQueue.async {
if let params = params as? BuildTargetsChangedNotification {
await self.handleBuildTargetsChanged(Notification(params, clientID: clientID))
} else if let params = params as? FileOptionsChangedNotification {
await self.handleFileOptionsChanged(Notification(params, clientID: clientID))
}
}
}
/// Handler for requests received **from** the build server.
///
/// We currently can't handle any requests sent from the build server to us.
public func handle<R: RequestType>(
public nonisolated func handle<R: RequestType>(
_ params: R,
id: RequestID,
from clientID: ObjectIdentifier,