From cd57429a8ba0574281e66d349516170b6e4691dd Mon Sep 17 00:00:00 2001 From: Alex Hoppen Date: Fri, 27 Oct 2023 13:04:51 -0700 Subject: [PATCH 1/2] Reduce the scope of one task --- Sources/SKCore/BuildServerBuildSystem.swift | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Sources/SKCore/BuildServerBuildSystem.swift b/Sources/SKCore/BuildServerBuildSystem.swift index 97176f08..1fa64517 100644 --- a/Sources/SKCore/BuildServerBuildSystem.swift +++ b/Sources/SKCore/BuildServerBuildSystem.swift @@ -259,10 +259,10 @@ extension BuildServerBuildSystem: BuildSystem { public func registerForChangeNotifications(for uri: DocumentURI, language: Language) { let request = RegisterForChanges(uri: uri, action: .register) _ = self.buildServer?.send(request) { result in - Task { - if let error = result.failure { - logger.error("error registering \(uri): \(error.forLogging)") + if let error = result.failure { + logger.error("error registering \(uri): \(error.forLogging)") + Task { // BuildServer registration failed, so tell our delegate that no build // settings are available. await self.buildSettingsChanged(for: uri, settings: nil) From 98d4fcfb5ff14f1431a8c7d6369ef77c576809bc Mon Sep 17 00:00:00 2001 From: Alex Hoppen Date: Fri, 6 Oct 2023 14:44:42 -0700 Subject: [PATCH 2/2] Add `WillSaveTextDocument` and `DidSaveTextDocument` to the known requests --- Sources/LanguageServerProtocol/Messages.swift | 2 ++ 1 file changed, 2 insertions(+) diff --git a/Sources/LanguageServerProtocol/Messages.swift b/Sources/LanguageServerProtocol/Messages.swift index 7870d43f..8776ebc2 100644 --- a/Sources/LanguageServerProtocol/Messages.swift +++ b/Sources/LanguageServerProtocol/Messages.swift @@ -105,6 +105,7 @@ public let builtinNotifications: [NotificationType.Type] = [ DidOpenTextDocumentNotification.self, DidRenameFilesNotification.self, DidSaveNotebookDocumentNotification.self, + DidSaveTextDocumentNotification.self, ExitNotification.self, InitializedNotification.self, LogMessageNotification.self, @@ -112,6 +113,7 @@ public let builtinNotifications: [NotificationType.Type] = [ PublishDiagnosticsNotification.self, SetTraceNotification.self, ShowMessageNotification.self, + WillSaveTextDocumentNotification.self, WorkDoneProgress.self, ]