Change FIXME and TODO comments to always have an associated issue

Do one of the following for every `FIXME` or `TODO` comment
- Add an issue that tracks the task
- Remove the comment if we are not planning to address it
This commit is contained in:
Alex Hoppen
2024-07-31 16:08:54 -07:00
parent ce85cf7fb5
commit 50a28bb86a
27 changed files with 61 additions and 83 deletions

View File

@@ -334,8 +334,9 @@ extension BuildServerBuildSystem: BuildSystem {
return .unhandled
}
// FIXME: We should not make any assumptions about which files the build server can handle.
// Instead we should query the build server which files it can handle (#492).
// TODO: We should not make any assumptions about which files the build server can handle.
// Instead we should query the build server which files it can handle
// (https://github.com/swiftlang/sourcekit-lsp/issues/492).
if projectRoot.isAncestorOfOrEqual(to: path) {
return .handled
@@ -399,8 +400,7 @@ private func makeJSONRPCBuildServer(
)
connection.start(receiveHandler: client) {
// FIXME: keep the pipes alive until we close the connection. This
// should be fixed systemically.
// Keep the pipes alive until we close the connection.
withExtendedLifetime((clientToServer, serverToClient)) {}
}
let process = Foundation.Process()