averello/sourcekit-lsp
1
0
Fork 0
mirror of https://github.com/apple/sourcekit-lsp.git synced 2026-03-02 18:23:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

Fix background indexing behavior if a source file is included in two targets via a symlink

Browse Source 
Consider the following scenario: A project has target A containing A.swift an target B containing B.swift. B.swift is a symlink to A.swift. When A.swift is modified, both the dependencies of A and B need to be marked as having an out-of-date preparation status, not just A.
This commit is contained in:
Alex Hoppen
2024-12-09 15:06:39 -08:00
parent 247acf6ae7
commit 5eb460f148
7 changed files with 132 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
Sources/BuildSystemIntegration/BuildSystemManager.swift
View File

@@ -1033,11 +1033,11 @@ package actor BuildSystemManager: QueueBasedMessageHandler {
return response.items
}
/// Returns all source files in the project that can be built.
/// Returns all source files in the project.
///
/// - SeeAlso: Comment in `sourceFilesAndDirectories` for a definition of what `buildable` means.
package func buildableSourceFiles() async throws -> [DocumentURI: SourceFileInfo] {
return try await sourceFilesAndDirectories(includeNonBuildableFiles: false).files
package func sourceFiles(includeNonBuildableFiles: Bool) async throws -> [DocumentURI: SourceFileInfo] {
return try await sourceFilesAndDirectories(includeNonBuildableFiles: includeNonBuildableFiles).files
}
/// Get all files and directories that are known to the build system, ie. that are returned by a `buildTarget/sources`
@@ -1093,7 +1093,7 @@ package actor BuildSystemManager: QueueBasedMessageHandler {
}
package func testFiles() async throws -> [DocumentURI] {
return try await buildableSourceFiles().compactMap { (uri, info) -> DocumentURI? in
return try await sourceFiles(includeNonBuildableFiles: false).compactMap { (uri, info) -> DocumentURI? in
guard info.isPartOfRootProject, info.mayContainTests else {
return nil
}

2
Sources/BuildSystemIntegration/SwiftPMBuildSystem.swift
View File

@@ -587,7 +587,7 @@ package actor SwiftPMBuildSystem: BuiltInBuildSystem {
SourceItem(
uri: DocumentURI($0),
kind: $0.isDirectory ? .directory : .file,
generated: false,
generated: false
)
}
result.append(SourcesItem(target: target, sources: sources))