averello/sourcekit-lsp
1
0
Fork 0
mirror of https://github.com/apple/sourcekit-lsp.git synced 2026-03-02 18:23:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use withUnsafeFileSystemRepresentation to get the path of a URL on disk

Browse Source 
`URL.path` returns forward slashes in the path on Windows (https://github.com/swiftlang/swift-foundation/issues/973) where we expect backslashes. Work around that by defining our own `filePath` property that is backed by `withUnsafeFileSystemRepresentation`, which produces backslashes.

rdar://137963660
This commit is contained in:
Alex Hoppen
2024-10-21 08:46:03 -07:00
parent fd279fc620
commit 951e923245
43 changed files with 284 additions and 174 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
Sources/BuildSystemIntegration/DetermineBuildSystem.swift
View File

@@ -14,6 +14,7 @@
package import LanguageServerProtocol
import SKLogging
package import SKOptions
import SwiftExtensions
import ToolchainRegistry
import struct TSCBasic.AbsolutePath
@@ -21,6 +22,7 @@ import struct TSCBasic.AbsolutePath
import LanguageServerProtocol
import SKLogging
import SKOptions
import SwiftExtensions
import ToolchainRegistry
import struct TSCBasic.AbsolutePath
@@ -42,7 +44,7 @@ package func determineBuildSystem(
buildSystemPreference.insert(defaultBuildSystem, at: 0)
}
guard let workspaceFolderUrl = workspaceFolder.fileURL,
let workspaceFolderPath = try? AbsolutePath(validating: workspaceFolderUrl.path)
let workspaceFolderPath = try? AbsolutePath(validating: workspaceFolderUrl.filePath)
else {
return nil
}
@@ -58,7 +60,7 @@ package func determineBuildSystem(
}
case .swiftPM:
if let projectRootURL = SwiftPMBuildSystem.projectRoot(for: workspaceFolderUrl, options: options),
let projectRoot = try? AbsolutePath(validating: projectRootURL.path)
let projectRoot = try? AbsolutePath(validating: projectRootURL.filePath)
{
return .swiftPM(projectRoot: projectRoot)
}