averello/sourcekit-lsp
1
0
Fork 0
mirror of https://github.com/apple/sourcekit-lsp.git synced 2026-03-02 18:23:24 +01:00
Code Issues Packages Projects Releases Wiki Activity

Use URL in many cases where we used AbsolutePath

Browse Source 
We made quite a few fixes recently to make sure that path handling works correctly using `URL` on Windows. Use `URL` in most places to have a single type that represents file paths instead of sometimes using `AbsolutePath`.

While doing so, also remove usages of `TSCBasic.FileSystem` an `InMemoryFileSystem`. The pattern of using `InMemoryFileSystem` for tests was never consistently used and it was a little confusing that some types took a `FileSystem` parameter while other always assumed to work on the local file system.
This commit is contained in:
Alex Hoppen
2024-11-18 13:10:01 -08:00
parent bce09932ed
commit be546308ca
52 changed files with 1211 additions and 1097 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
Sources/BuildSystemIntegration/BuiltInBuildSystem.swift
View File

@@ -12,22 +12,18 @@
#if compiler(>=6)
package import BuildServerProtocol
package import Foundation
package import LanguageServerProtocol
import SKLogging
import SKOptions
import ToolchainRegistry
package import struct TSCBasic.AbsolutePath
package import struct TSCBasic.RelativePath
#else
import BuildServerProtocol
import Foundation
import LanguageServerProtocol
import SKLogging
import SKOptions
import ToolchainRegistry
import struct TSCBasic.AbsolutePath
import struct TSCBasic.RelativePath
#endif
/// An error build systems can throw from `prepare` if they don't support preparation of targets.
@@ -42,16 +38,16 @@ package protocol BuiltInBuildSystem: AnyObject, Sendable {
/// The root of the project that this build system manages. For example, for SwiftPM packages, this is the folder
/// containing Package.swift. For compilation databases it is the root folder based on which the compilation database
/// was found.
var projectRoot: AbsolutePath { get async }
var projectRoot: URL { get async }
/// The files to watch for changes.
var fileWatchers: [FileSystemWatcher] { get async }
/// The path to the raw index store data, if any.
var indexStorePath: AbsolutePath? { get async }
var indexStorePath: URL? { get async }
/// The path to put the index database, if any.
var indexDatabasePath: AbsolutePath? { get async }
var indexDatabasePath: URL? { get async }
/// Whether the build system is capable of preparing a target for indexing, ie. if the `prepare` methods has been
/// implemented.