diff --git a/Sources/LSPTestSupport/CheckCoding.swift b/Sources/LSPTestSupport/CheckCoding.swift index 173f2fa8..e9d7dc3a 100644 --- a/Sources/LSPTestSupport/CheckCoding.swift +++ b/Sources/LSPTestSupport/CheckCoding.swift @@ -78,10 +78,3 @@ public func checkCoding(_ value: T, json: String, userInfo: [CodingUserInfoKe body(decodedValue) } - -extension String { - // This is fileprivate because the implementation is really slow; to use it outside a test it should be optimized. - fileprivate func trimmingTrailingWhitespace() -> String { - return self.replacingOccurrences(of: "[ ]+\\n", with: "\n", options: .regularExpression) - } -} diff --git a/Sources/LSPTestSupport/String+TrimTrailingWhitespace.swift b/Sources/LSPTestSupport/String+TrimTrailingWhitespace.swift new file mode 100644 index 00000000..6a162835 --- /dev/null +++ b/Sources/LSPTestSupport/String+TrimTrailingWhitespace.swift @@ -0,0 +1,19 @@ +//===----------------------------------------------------------------------===// +// +// This source file is part of the Swift.org open source project +// +// Copyright (c) 2014 - 2022 Apple Inc. and the Swift project authors +// Licensed under Apache License v2.0 with Runtime Library Exception +// +// See https://swift.org/LICENSE.txt for license information +// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors +// +//===----------------------------------------------------------------------===// + + +public extension String { + // This implementation is really slow; to use it outside a test it should be optimized. + func trimmingTrailingWhitespace() -> String { + return self.replacingOccurrences(of: "[ ]+\\n", with: "\n", options: .regularExpression) + } +} diff --git a/Sources/SourceKitLSP/Swift/Diagnostic.swift b/Sources/SourceKitLSP/Swift/Diagnostic.swift index a095bdf4..99b8f8d5 100644 --- a/Sources/SourceKitLSP/Swift/Diagnostic.swift +++ b/Sources/SourceKitLSP/Swift/Diagnostic.swift @@ -20,10 +20,10 @@ extension CodeAction { /// Creates a CodeAction from a list for sourcekit fixits. /// /// If this is from a note, the note's description should be passed as `fromNote`. - init?(fixits: SKDResponseArray, in snapshot: DocumentSnapshot, fromNote: String?, clientSupportsSnippets: Bool) { + init?(fixits: SKDResponseArray, in snapshot: DocumentSnapshot, fromNote: String?) { var edits: [TextEdit] = [] let editsMapped = fixits.forEach { (_, skfixit) -> Bool in - if let edit = TextEdit(fixit: skfixit, in: snapshot, clientSupportsSnippets: clientSupportsSnippets) { + if let edit = TextEdit(fixit: skfixit, in: snapshot) { edits.append(edit) return true } @@ -88,7 +88,7 @@ extension CodeAction { extension TextEdit { /// Creates a TextEdit from a sourcekitd fixit response dictionary. - init?(fixit: SKDResponseDictionary, in snapshot: DocumentSnapshot, clientSupportsSnippets: Bool) { + init?(fixit: SKDResponseDictionary, in snapshot: DocumentSnapshot) { let keys = fixit.sourcekitd.keys if let utf8Offset: Int = fixit[keys.offset], let length: Int = fixit[keys.length], @@ -97,8 +97,10 @@ extension TextEdit { let endPosition = snapshot.positionOf(utf8Offset: utf8Offset + length), length > 0 || !replacement.isEmpty { - let replacementWithSnippets = rewriteSourceKitPlaceholders(inString: replacement, clientSupportsSnippets: clientSupportsSnippets) - self.init(range: position.. Bool in - guard let note = DiagnosticRelatedInformation(sknote, in: snapshot, clientSupportsSnippets: clientSupportsSnippets) else { return true } + guard let note = DiagnosticRelatedInformation(sknote, in: snapshot) else { return true } notes?.append(note) return true } @@ -224,7 +225,7 @@ extension Diagnostic { extension DiagnosticRelatedInformation { /// Creates related information from a sourcekitd note response dictionary. - init?(_ diag: SKDResponseDictionary, in snapshot: DocumentSnapshot, clientSupportsSnippets: Bool) { + init?(_ diag: SKDResponseDictionary, in snapshot: DocumentSnapshot) { let keys = diag.sourcekitd.keys var position: Position? = nil @@ -245,7 +246,7 @@ extension DiagnosticRelatedInformation { var actions: [CodeAction]? = nil if let skfixits: SKDResponseArray = diag[keys.fixits], - let action = CodeAction(fixits: skfixits, in: snapshot, fromNote: message, clientSupportsSnippets: clientSupportsSnippets) { + let action = CodeAction(fixits: skfixits, in: snapshot, fromNote: message) { actions = [action] } @@ -279,13 +280,11 @@ struct CachedDiagnostic { extension CachedDiagnostic { init?(_ diag: SKDResponseDictionary, in snapshot: DocumentSnapshot, - useEducationalNoteAsCode: Bool, - clientSupportsSnippets: Bool) { + useEducationalNoteAsCode: Bool) { let sk = diag.sourcekitd guard let diagnostic = Diagnostic(diag, in: snapshot, - useEducationalNoteAsCode: useEducationalNoteAsCode, - clientSupportsSnippets: clientSupportsSnippets) else { + useEducationalNoteAsCode: useEducationalNoteAsCode) else { return nil } self.diagnostic = diagnostic diff --git a/Sources/SourceKitLSP/Swift/SemanticRefactoring.swift b/Sources/SourceKitLSP/Swift/SemanticRefactoring.swift index 02e10dfe..c3c1fcad 100644 --- a/Sources/SourceKitLSP/Swift/SemanticRefactoring.swift +++ b/Sources/SourceKitLSP/Swift/SemanticRefactoring.swift @@ -36,7 +36,7 @@ struct SemanticRefactoring { /// - dict: Response dictionary to extract information from. /// - url: The client URL that triggered the `semantic_refactoring` request. /// - keys: The sourcekitd key set to use for looking up into `dict`. - init?(_ title: String, _ dict: SKDResponseDictionary, _ snapshot: DocumentSnapshot, _ keys: sourcekitd_keys, clientSupportsSnippets: Bool) { + init?(_ title: String, _ dict: SKDResponseDictionary, _ snapshot: DocumentSnapshot, _ keys: sourcekitd_keys) { guard let categorizedEdits: SKDResponseArray = dict[keys.categorizededits] else { return nil } @@ -59,7 +59,9 @@ struct SemanticRefactoring { utf8Column: endColumn - 1), let text: String = value[keys.text] { - let textWithSnippets = rewriteSourceKitPlaceholders(inString: text, clientSupportsSnippets: clientSupportsSnippets) + // Snippets are only suppored in code completion. + // Remove SourceKit placeholders in refactoring actions because they can't be represented in the editor properly. + let textWithSnippets = rewriteSourceKitPlaceholders(inString: text, clientSupportsSnippets: false) let edit = TextEdit(range: startPosition..