Files
sourcekit-lsp/Sources/SKTestSupport/SwiftPMTestProject.swift
Alex Hoppen 219428328c Address my own review comments
Apply the following changes:
- Check for the presence of `#Playgrounds` textually before getting the module name in `SwiftPlaygroundsScanner`. This is important because getting the module name requires us to get build settings for the file, which can be expensive. Do the cheaper check first
- Make `syntacticTests` and `syntacticPlaygrounds` closures capture the workspace instead of passing the workspace from the `SwiftSyntacticIndex` back out. I like this better because now we can’t accidentally pass the wrong workspace to a `SwiftSyntacticIndex`, eg. to `buildTargetsChanges`.
- Capture the initialize result in `TestSourceKitLSPClient` instead of using `postInitialization` to capture the result
- Minor cleanup of unnecessary abstractions, likely artifacts of earlier iterations
- Restructure tests so that every test has its own list of source files, allowing for easier local reasoning – turns out some of these tests didn’t even need to open a workspace, just to check the initialize response
2025-12-08 15:16:36 -05:00

297 lines
10 KiB
Swift

//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2023 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
package import Foundation
@_spi(SourceKitLSP) package import LanguageServerProtocol
@_spi(SourceKitLSP) import SKLogging
package import SKOptions
package import SourceKitLSP
import SwiftExtensions
import TSCBasic
package import ToolchainRegistry
@_spi(SourceKitLSP) import ToolsProtocolsSwiftExtensions
import XCTest
package class SwiftPMTestProject: MultiFileTestProject {
enum Error: Swift.Error {
/// The `swift` executable could not be found.
case swiftNotFound
}
package static let defaultPackageManifest: String = """
// swift-tools-version: 5.7
import PackageDescription
let package = Package(
name: "MyLibrary",
targets: [.target(name: "MyLibrary")]
)
"""
/// A manifest that defines two targets:
/// - A macro target named `MyMacro`
/// - And executable target named `MyMacroClient`
///
/// It builds the macro using the swift-syntax that was already built as part of the SourceKit-LSP build.
/// Re-using the SwiftSyntax modules that are already built is significantly faster than building swift-syntax in
/// each test case run and does not require internet access.
package static var macroPackageManifest: String {
get async throws {
// Directories that we should search for the swift-syntax package.
// We prefer a checkout in the build folder. If that doesn't exist, we are probably using local dependencies
// (SWIFTCI_USE_LOCAL_DEPS), so search next to the sourcekit-lsp source repo
let swiftSyntaxSearchPaths = [
productsDirectory
.deletingLastPathComponent() // arm64-apple-macosx
.deletingLastPathComponent() // debug
.appending(component: "checkouts"),
URL(fileURLWithPath: #filePath)
.deletingLastPathComponent() // SwiftPMTestProject.swift
.deletingLastPathComponent() // SKTestSupport
.deletingLastPathComponent() // Sources
.deletingLastPathComponent(), // sourcekit-lsp
]
let swiftSyntaxCShimsModulemap =
swiftSyntaxSearchPaths.map { swiftSyntaxSearchPath in
swiftSyntaxSearchPath
.appending(components: "swift-syntax", "Sources", "_SwiftSyntaxCShims", "include", "module.modulemap")
}
.first { FileManager.default.fileExists(at: $0) }
guard let swiftSyntaxCShimsModulemap else {
struct SwiftSyntaxCShimsModulemapNotFoundError: Swift.Error {}
throw SwiftSyntaxCShimsModulemapNotFoundError()
}
// Only link against object files that are listed in the `Objects.LinkFileList`. Otherwise we can get a situation
// where a `.swift` file is removed from swift-syntax, its `.o` file is still in the build directory because the
// build folder wasn't cleaned and thus we would link against the stale `.o` file.
let linkFileListURL =
productsDirectory
.appending(components: "SourceKitLSPPackageTests.product", "Objects.LinkFileList")
let linkFileListContents = try? String(contentsOf: linkFileListURL, encoding: .utf8)
guard let linkFileListContents else {
struct LinkFileListNotFoundError: Swift.Error {
let url: URL
}
throw LinkFileListNotFoundError(url: linkFileListURL)
}
let linkFileList =
Set(
linkFileListContents
.split(separator: "\n")
.map {
// Files are wrapped in single quotes if the path contains spaces. Drop the quotes.
if $0.hasPrefix("'") && $0.hasSuffix("'") {
return String($0.dropFirst().dropLast())
} else {
return String($0)
}
}
)
let swiftSyntaxModulesToLink = [
"SwiftBasicFormat",
"SwiftCompilerPlugin",
"SwiftCompilerPluginMessageHandling",
"SwiftDiagnostics",
"SwiftIfConfig",
"SwiftOperators",
"SwiftParser",
"SwiftParserDiagnostics",
"SwiftSyntax",
"SwiftSyntaxBuilder",
"SwiftSyntaxMacroExpansion",
"SwiftSyntaxMacros",
"_SwiftSyntaxCShims",
]
var objectFiles: [String] = []
for moduleName in swiftSyntaxModulesToLink {
let dir = productsDirectory.appending(component: "\(moduleName).build")
let enumerator = FileManager.default.enumerator(at: dir, includingPropertiesForKeys: nil)
while let file = enumerator?.nextObject() as? URL {
if linkFileList.contains(try file.filePath) {
objectFiles.append(try file.filePath)
}
}
}
let linkerFlags = objectFiles.map {
"""
"\($0)",
"""
}.joined(separator: "\n")
let moduleSearchPath: String
if let toolchainVersion = try await ToolchainRegistry.forTesting.default?.swiftVersion,
toolchainVersion < SwiftVersion(6, 0)
{
moduleSearchPath = try productsDirectory.filePath
} else {
moduleSearchPath = "\(try productsDirectory.filePath)/Modules"
}
return """
// swift-tools-version: 5.10
import PackageDescription
import CompilerPluginSupport
let package = Package(
name: "MyMacro",
platforms: [.macOS(.v10_15)],
targets: [
.macro(
name: "MyMacros",
swiftSettings: [.unsafeFlags([
"-I", #"\(moduleSearchPath)"#,
"-Xcc", #"-fmodule-map-file=\(try swiftSyntaxCShimsModulemap.filePath)"#
])],
linkerSettings: [
.unsafeFlags([
\(linkerFlags)
])
]
),
.executableTarget(name: "MyMacroClient", dependencies: ["MyMacros"]),
]
)
"""
}
}
/// Create a new SwiftPM package with the given files.
///
/// If `index` is `true`, then the package will be built, indexing all modules within the package.
package init(
files: [RelativeFileLocation: String],
manifest: String = SwiftPMTestProject.defaultPackageManifest,
workspaces: (_ scratchDirectory: URL) async throws -> [WorkspaceFolder] = {
[WorkspaceFolder(uri: DocumentURI($0))]
},
initializationOptions: LSPAny? = nil,
capabilities: ClientCapabilities = ClientCapabilities(),
options: SourceKitLSPOptions? = nil,
toolchainRegistry: ToolchainRegistry = .forTesting,
hooks: Hooks = Hooks(),
enableBackgroundIndexing: Bool = false,
usePullDiagnostics: Bool = true,
pollIndex: Bool = true,
preInitialization: ((TestSourceKitLSPClient) -> Void)? = nil,
cleanUp: (@Sendable () -> Void)? = nil,
testName: String = #function
) async throws {
var filesByPath: [RelativeFileLocation: String] = [:]
for (fileLocation, contents) in files {
let directories =
switch fileLocation.directories.first {
case "Sources", "Tests", "Plugins", "":
fileLocation.directories
case nil:
["Sources", "MyLibrary"]
default:
["Sources"] + fileLocation.directories
}
filesByPath[RelativeFileLocation(directories: directories, fileLocation.fileName)] = contents
}
var manifest = manifest
if !manifest.contains("swift-tools-version") {
// Tests specify a shorthand package manifest that doesn't contain the tools version boilerplate.
manifest = """
// swift-tools-version: 5.10
import PackageDescription
\(manifest)
"""
}
filesByPath["Package.swift"] = manifest
try await super.init(
files: filesByPath,
workspaces: workspaces,
initializationOptions: initializationOptions,
capabilities: capabilities,
options: options,
toolchainRegistry: toolchainRegistry,
hooks: hooks,
enableBackgroundIndexing: enableBackgroundIndexing,
usePullDiagnostics: usePullDiagnostics,
preInitialization: preInitialization,
cleanUp: cleanUp,
testName: testName
)
if pollIndex {
// Wait for the indexstore-db to finish indexing
try await testClient.send(SynchronizeRequest(index: true))
}
}
/// Build a SwiftPM package package manifest is located in the directory at `path`.
package static func build(at path: URL, extraArguments: [String] = []) async throws {
guard let swift = await ToolchainRegistry.forTesting.default?.swift else {
throw Error.swiftNotFound
}
var arguments =
[
try swift.filePath,
"build",
"--package-path", try path.filePath,
"--build-tests",
"-Xswiftc", "-index-ignore-system-modules",
"-Xcc", "-index-ignore-system-symbols",
] + extraArguments
if let globalModuleCache = try globalModuleCache {
arguments += [
"-Xswiftc", "-module-cache-path", "-Xswiftc", try globalModuleCache.filePath,
]
}
let argumentsCopy = arguments
let output = try await withTimeout(defaultTimeoutDuration) {
try await Process.checkNonZeroExit(arguments: argumentsCopy)
}
logger.debug(
"""
'swift build' output:
\(output)
"""
)
}
/// Resolve package dependencies for the package at `path`.
package static func resolvePackageDependencies(at path: URL) async throws {
guard let swift = await ToolchainRegistry.forTesting.default?.swift else {
throw Error.swiftNotFound
}
let arguments = [
try swift.filePath,
"package",
"resolve",
"--package-path", try path.filePath,
]
let output = try await withTimeout(defaultTimeoutDuration) {
try await Process.checkNonZeroExit(arguments: arguments)
}
logger.debug(
"""
'swift package resolve' output:
\(output)
"""
)
}
}