mirror of
https://github.com/apple/sourcekit-lsp.git
synced 2026-03-02 18:23:24 +01:00
26c1451887
Some SourceKit properties are weak references. Several test cases assign weak references assuming they will outlive subsequent checks without any subsequent use keeping the reference alive. The SIL optimizer shortens object lifetimes, breaking the test at -O. This may even happen at -Onone in the future. The optimizer has always done this sort of optimization, but enabling OSSA makes it much more likely to happen in practice. Fixes rdar://73044531 ([CanonicalOSSA] sourcekit-lsp tests; fix weak reference lifetimes)
110 lines
3.3 KiB
Swift
110 lines
3.3 KiB
Swift
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This source file is part of the Swift.org open source project
|
|
//
|
|
// Copyright (c) 2014 - 2020 Apple Inc. and the Swift project authors
|
|
// Licensed under Apache License v2.0 with Runtime Library Exception
|
|
//
|
|
// See https://swift.org/LICENSE.txt for license information
|
|
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
import SourceKitD
|
|
import SKCore
|
|
import TSCBasic
|
|
import TSCUtility
|
|
import ISDBTibs
|
|
import ISDBTestSupport
|
|
import XCTest
|
|
|
|
final class SourceKitDTests: XCTestCase {
|
|
static var sourcekitdPath: AbsolutePath! = nil
|
|
static var sdkpath: String? = nil
|
|
|
|
override class func setUp() {
|
|
sourcekitdPath = ToolchainRegistry.shared.default!.sourcekitd!
|
|
if case .darwin? = Platform.currentPlatform,
|
|
let str = try? Process.checkNonZeroExit(
|
|
args: "/usr/bin/xcrun", "--show-sdk-path", "--sdk", "macosx")
|
|
{
|
|
sdkpath = str.spm_chomp()
|
|
}
|
|
}
|
|
|
|
func testMultipleNotificationHandlers() {
|
|
let ws = try! mutableTibsTestWorkspace(name: "proj1")!
|
|
let sourcekitd = try! SourceKitDImpl.getOrCreate(dylibPath: SourceKitDTests.sourcekitdPath)
|
|
let keys = sourcekitd.keys
|
|
let path: String = ws.testLoc("c").url.path
|
|
|
|
let isExpectedNotification = { (response: SKDResponse) -> Bool in
|
|
if let notification: sourcekitd_uid_t = response.value?[keys.notification],
|
|
let name: String = response.value?[keys.name]
|
|
{
|
|
return name == path && notification == sourcekitd.values.notification_documentupdate
|
|
}
|
|
return false
|
|
}
|
|
|
|
let expectation1 = expectation(description: "handler 1")
|
|
let handler1 = ClosureNotificationHandler { response in
|
|
if isExpectedNotification(response) {
|
|
expectation1.fulfill()
|
|
}
|
|
}
|
|
// SourceKitDImpl weakly references handlers
|
|
defer {
|
|
_fixLifetime(handler1)
|
|
}
|
|
sourcekitd.addNotificationHandler(handler1)
|
|
|
|
let expectation2 = expectation(description: "handler 2")
|
|
let handler2 = ClosureNotificationHandler { response in
|
|
if isExpectedNotification(response) {
|
|
expectation2.fulfill()
|
|
}
|
|
}
|
|
// SourceKitDImpl weakly references handlers
|
|
defer {
|
|
_fixLifetime(handler2)
|
|
}
|
|
sourcekitd.addNotificationHandler(handler2)
|
|
|
|
let req = SKDRequestDictionary(sourcekitd: sourcekitd)
|
|
req[keys.request] = sourcekitd.requests.editor_open
|
|
req[keys.name] = path
|
|
req[keys.sourcetext] = """
|
|
func foo() {}
|
|
"""
|
|
let args = SKDRequestArray(sourcekitd: sourcekitd)
|
|
if let sdkpath = SourceKitDTests.sdkpath {
|
|
args.append("-sdk")
|
|
args.append(sdkpath)
|
|
}
|
|
args.append(path)
|
|
req[keys.compilerargs] = args
|
|
|
|
_ = try! sourcekitd.sendSync(req)
|
|
|
|
waitForExpectations(timeout: 15)
|
|
|
|
let close = SKDRequestDictionary(sourcekitd: sourcekitd)
|
|
close[keys.request] = sourcekitd.requests.editor_close
|
|
close[keys.name] = path
|
|
_ = try! sourcekitd.sendSync(close)
|
|
}
|
|
}
|
|
|
|
private class ClosureNotificationHandler: SKDNotificationHandler {
|
|
let f: (SKDResponse) -> Void
|
|
|
|
init(_ f: @escaping (SKDResponse) -> Void) {
|
|
self.f = f
|
|
}
|
|
|
|
func notification(_ response: SKDResponse) {
|
|
f(response)
|
|
}
|
|
}
|