Files
sourcekit-lsp/Tests/SourceKitLSPTests/SyntaxRefactorTests.swift
Alex Hoppen 449d2a9b39 Fix a bug that caused documentation to be added at the start of the declaration’s trivia
This meant that if there were two newlines before the declaration, the documentation would be separated to the declaration by one newline and if the declaration was at the start of a line, the declaration would be on the same line as the doc comment, effectively making the documentation part of a comment.
2024-05-08 14:56:09 -07:00

471 lines
13 KiB
Swift
Raw Permalink Blame History

This file contains invisible Unicode characters
This file contains invisible Unicode characters that are indistinguishable to humans but may be processed differently by a computer. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
This file contains Unicode characters that might be confused with other characters. If you think that this is intentional, you can safely ignore this warning. Use the Escape button to reveal them.
//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2019 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
import SKTestSupport
@_spi(Testing) import SourceKitLSP
import SwiftParser
import SwiftRefactor
import SwiftSyntax
import XCTest
final class SyntaxRefactorTests: XCTestCase {
func testAddDocumentationRefactor() throws {
try assertRefactor(
"""
1⃣func 2⃣refactor(syntax: DeclSyntax, in context: Void) -> DeclSyntax? { }
""",
context: (),
provider: AddDocumentation.self,
expected: [
SourceEdit(
range: AbsolutePosition(utf8Offset: 2)..<AbsolutePosition(utf8Offset: 2),
replacement: """
/// A description
/// - Parameters:
/// - syntax:
/// - context:
///
/// - Returns:
\("")
"""
)
]
)
}
func testAddDocumentationRefactorSingleParameter() throws {
try assertRefactor(
"""
1⃣func 2⃣refactor(syntax: DeclSyntax) { }
""",
context: (),
provider: AddDocumentation.self,
expected: [
SourceEdit(
range: AbsolutePosition(utf8Offset: 2)..<AbsolutePosition(utf8Offset: 2),
replacement: """
/// A description
/// - Parameter syntax:
\("")
"""
)
]
)
}
func testConvertJSONToCodableStructClosure() throws {
try assertRefactor(
"""
4⃣{1
2"name": "Produce",
"shelves": [
{
"name": "Discount Produce",
"product": {
"name": "Banana",
"points": 200,
"description": "A banana that's perfectly ripe."
}
}
]
}
""",
context: (),
provider: ConvertJSONToCodableStruct.self,
expected: [
SourceEdit(
range: AbsolutePosition(utf8Offset: 0)..<AbsolutePosition(utf8Offset: 267),
replacement: """
struct JSONValue: Codable {
var name: String
var shelves: [Shelves]
struct Shelves: Codable {
var name: String
var product: Product
struct Product: Codable {
var description: String
var name: String
var points: Double
}
}
}
"""
)
]
)
}
func testConvertJSONToCodableStructLiteral() throws {
try assertRefactor(
#"""
"""
{
"name": "Produce",
"shelves": [
{
"name": "Discount Produce",
"product": {
"name": "Banana",
"points": 200,
"description": "A banana that's perfectly ripe."
}
}
]
}
"""
"""#,
context: (),
provider: ConvertJSONToCodableStruct.self,
expected: [
SourceEdit(
range: AbsolutePosition(utf8Offset: 303)..<AbsolutePosition(utf8Offset: 303),
replacement: """
struct JSONValue: Codable {
var name: String
var shelves: [Shelves]
struct Shelves: Codable {
var name: String
var product: Product
struct Product: Codable {
var description: String
var name: String
var points: Double
}
}
}
"""
)
]
)
}
func testConvertJSONToCodableStructClosureMerging() throws {
try assertRefactor(
"""
{
"name": "Store",
"shelves": [
{
"name": "Discount Produce",
"product": {
"name": "Banana",
"points": 200,
"description": "A banana that's perfectly ripe.",
"healthy": "true",
"delicious": "true",
"categories": [ "fruit", "yellow" ]
}
},
{
"name": "Meat",
"product": {
"name": "steak",
"points": 200,
"healthy": "false",
"delicious": "true",
"categories": [ ]
}
},
{
"name": "Cereal aisle",
"product": {
"name": "Sugarydoos",
"points": 0.5,
"healthy": "false",
"delicious": "maybe",
"description": "More sugar than you can imagine."
}
}
]
}
""",
context: (),
provider: ConvertJSONToCodableStruct.self,
expected: [
SourceEdit(
range: AbsolutePosition(utf8Offset: 0)..<AbsolutePosition(utf8Offset: 931),
replacement: """
struct JSONValue: Codable {
var name: String
var shelves: [Shelves]
struct Shelves: Codable {
var name: String
var product: Product
struct Product: Codable {
var categories: [String]
var delicious: String
var description: String?
var healthy: Bool
var name: String
var points: Double
}
}
}
"""
)
]
)
}
}
func assertRefactor<R: EditRefactoringProvider>(
_ input: String,
context: R.Context,
provider: R.Type,
expected: [SourceEdit],
file: StaticString = #filePath,
line: UInt = #line
) throws {
let (markers, textWithoutMarkers) = extractMarkers(input)
var parser = Parser(textWithoutMarkers)
let sourceFile = SourceFileSyntax.parse(from: &parser)
let markersToCheck = markers.isEmpty ? [("1", 0)] : markers.sorted { $0.key < $1.key }
for (marker, location) in markersToCheck {
guard let token = sourceFile.token(at: AbsolutePosition(utf8Offset: location)) else {
XCTFail("Could not find token at location \(marker)")
continue
}
let input: R.Input
if let parentMatch = token.parent?.as(R.Input.self) {
input = parentMatch
} else {
XCTFail("token at \(marker) did not match expected input: \(token)")
continue
}
try assertRefactor(
input,
context: context,
provider: provider,
expected: expected,
at: marker,
file: file,
line: line
)
}
}
// Borrowed from the swift-syntax library's SwiftRefactor tests.
func assertRefactor<R: EditRefactoringProvider>(
_ input: R.Input,
context: R.Context,
provider: R.Type,
expected: [SourceEdit],
at marker: String,
file: StaticString = #filePath,
line: UInt = #line
) throws {
let edits = R.textRefactor(syntax: input, in: context)
guard !edits.isEmpty else {
if !expected.isEmpty {
XCTFail(
"""
Refactoring at \(marker) produced empty result, expected:
\(expected)
""",
file: file,
line: line
)
}
return
}
if edits.count != expected.count {
XCTFail(
"""
Refactoring at \(marker) produced incorrect number of edits, expected \(expected.count) not \(edits.count).
Actual:
\(edits.map({ $0.debugDescription }).joined(separator: "\n"))
Expected:
\(expected.map({ $0.debugDescription }).joined(separator: "\n"))
""",
file: file,
line: line
)
return
}
for (actualEdit, expectedEdit) in zip(edits, expected) {
XCTAssertEqual(
actualEdit,
expectedEdit,
"Incorrect edit, expected \(expectedEdit.debugDescription) but actual was \(actualEdit.debugDescription)",
file: file,
line: line
)
assertStringsEqualWithDiff(
actualEdit.replacement,
expectedEdit.replacement,
file: file,
line: line
)
}
}
/// Asserts that the two strings are equal, providing Unix `diff`-style output if they are not.
///
/// - Parameters:
/// - actual: The actual string.
/// - expected: The expected string.
/// - message: An optional description of the failure.
/// - additionalInfo: Additional information about the failed test case that will be printed after the diff
/// - file: The file in which failure occurred. Defaults to the file name of the test case in
/// which this function was called.
/// - line: The line number on which failure occurred. Defaults to the line number on which this
/// function was called.
public func assertStringsEqualWithDiff(
_ actual: String,
_ expected: String,
_ message: String = "",
additionalInfo: @autoclosure () -> String? = nil,
file: StaticString = #filePath,
line: UInt = #line
) {
if actual == expected {
return
}
failStringsEqualWithDiff(
actual,
expected,
message,
additionalInfo: additionalInfo(),
file: file,
line: line
)
}
/// Asserts that the two data are equal, providing Unix `diff`-style output if they are not.
///
/// - Parameters:
/// - actual: The actual string.
/// - expected: The expected string.
/// - message: An optional description of the failure.
/// - additionalInfo: Additional information about the failed test case that will be printed after the diff
/// - file: The file in which failure occurred. Defaults to the file name of the test case in
/// which this function was called.
/// - line: The line number on which failure occurred. Defaults to the line number on which this
/// function was called.
public func assertDataEqualWithDiff(
_ actual: Data,
_ expected: Data,
_ message: String = "",
additionalInfo: @autoclosure () -> String? = nil,
file: StaticString = #filePath,
line: UInt = #line
) {
if actual == expected {
return
}
// NOTE: Converting to `Stirng` here looses invalid UTF8 sequence difference,
// but at least we can see something is different.
failStringsEqualWithDiff(
String(decoding: actual, as: UTF8.self),
String(decoding: expected, as: UTF8.self),
message,
additionalInfo: additionalInfo(),
file: file,
line: line
)
}
/// `XCTFail` with `diff`-style output.
public func failStringsEqualWithDiff(
_ actual: String,
_ expected: String,
_ message: String = "",
additionalInfo: @autoclosure () -> String? = nil,
file: StaticString = #filePath,
line: UInt = #line
) {
let stringComparison: String
// Use `CollectionDifference` on supported platforms to get `diff`-like line-based output. On
// older platforms, fall back to simple string comparison.
if #available(macOS 10.15, *) {
let actualLines = actual.components(separatedBy: .newlines)
let expectedLines = expected.components(separatedBy: .newlines)
let difference = actualLines.difference(from: expectedLines)
var result = ""
var insertions = [Int: String]()
var removals = [Int: String]()
for change in difference {
switch change {
case .insert(let offset, let element, _):
insertions[offset] = element
case .remove(let offset, let element, _):
removals[offset] = element
}
}
var expectedLine = 0
var actualLine = 0
while expectedLine < expectedLines.count || actualLine < actualLines.count {
if let removal = removals[expectedLine] {
result += "\(removal)\n"
expectedLine += 1
} else if let insertion = insertions[actualLine] {
result += "+\(insertion)\n"
actualLine += 1
} else {
result += " \(expectedLines[expectedLine])\n"
expectedLine += 1
actualLine += 1
}
}
stringComparison = result
} else {
// Fall back to simple message on platforms that don't support CollectionDifference.
stringComparison = """
Expected:
\(expected)
Actual:
\(actual)
"""
}
var fullMessage = """
\(message.isEmpty ? "Actual output does not match the expected" : message)
\(stringComparison)
"""
if let additional = additionalInfo() {
fullMessage = """
\(fullMessage)
\(additional)
"""
}
XCTFail(fullMessage, file: file, line: line)
}