Files
sourcekit-lsp/Tests/LanguageServerProtocolJSONRPCTests/ConnectionTests.swift
Ben Langmuir fae2fe85a7 [JSONRPC] Do not exit until outstanding I/O has finished
Specifically, we care that all outstanding **writes** are finished
before we call the close handler, because otherwise we may (a) send
corrupted output during shutdown, or (b) drop notifications and replies
sent during the shutdown process.  The former is a potential issue for
clients that are not robust about parse failures, and the latter is an
issue for reproducibility and robustness during testing/debugging - in
particular, we have some integration tests that send data without
waiting for individual replies and they need to finish outstanding
replies before exiting.

rdar://60159448
2020-03-10 11:16:34 -07:00

252 lines
8.0 KiB
Swift

//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2018 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
import LanguageServerProtocol
import LanguageServerProtocolJSONRPC
import LSPTestSupport
import XCTest
// Workaround ambiguity with Foundation.
typealias Notification = LanguageServerProtocol.Notification
class ConnectionTests: XCTestCase {
var connection: TestJSONRPCConnection! = nil
override func setUp() {
connection = TestJSONRPCConnection()
connection.client.allowUnexpectedNotification = false
}
override func tearDown() {
connection.close()
}
func testRound() {
let enc = try! JSONEncoder().encode(EchoRequest(string: "a/b"))
let dec = try! JSONDecoder().decode(EchoRequest.self, from: enc)
XCTAssertEqual("a/b", dec.string)
}
func testEcho() {
let client = connection.client
let expectation = self.expectation(description: "response received")
_ = client.send(EchoRequest(string: "hello!")) { resp in
XCTAssertEqual(try! resp.get(), "hello!")
expectation.fulfill()
}
waitForExpectations(timeout: 10)
}
func testMessageBuffer() {
let client = connection.client
let clientConnection = connection.clientConnection
let expectation = self.expectation(description: "note received")
client.handleNextNotification { (note: Notification<EchoNotification>) in
XCTAssertEqual(note.params.string, "hello!")
expectation.fulfill()
}
let note1 = try! JSONEncoder().encode(JSONRPCMessage.notification(EchoNotification(string: "hello!")))
let note2 = try! JSONEncoder().encode(JSONRPCMessage.notification(EchoNotification(string: "no way!")))
let note1Str: String = "Content-Length: \(note1.count)\r\n\r\n\(String(data: note1, encoding: .utf8)!)"
let note2Str: String = "Content-Length: \(note2.count)\r\n\r\n\(String(data: note2, encoding: .utf8)!)"
for b in note1Str.utf8.dropLast() {
clientConnection.send(_rawData: [b].withUnsafeBytes { DispatchData(bytes: $0) })
}
clientConnection.send(_rawData: [note1Str.utf8.last!, note2Str.utf8.first!].withUnsafeBytes { DispatchData(bytes: $0) })
waitForExpectations(timeout: 10)
let expectation2 = self.expectation(description: "note received")
client.handleNextNotification { (note: Notification<EchoNotification>) in
XCTAssertEqual(note.params.string, "no way!")
expectation2.fulfill()
}
for b in note2Str.utf8.dropFirst() {
clientConnection.send(_rawData: [b].withUnsafeBytes { DispatchData(bytes: $0) })
}
waitForExpectations(timeout: 10)
// Close the connection before accessing _requestBuffer, which ensures we don't race.
connection.serverConnection.close()
XCTAssertEqual(connection.serverConnection._requestBuffer, [])
}
func testEchoError() {
let client = connection.client
let expectation = self.expectation(description: "response received 1")
let expectation2 = self.expectation(description: "response received 2")
_ = client.send(EchoError(code: nil)) { resp in
XCTAssertEqual(try! resp.get(), VoidResponse())
expectation.fulfill()
}
_ = client.send(EchoError(code: .unknownErrorCode, message: "hey!")) { resp in
XCTAssertEqual(resp, LSPResult<VoidResponse>.failure(ResponseError(code: .unknownErrorCode, message: "hey!")))
expectation2.fulfill()
}
waitForExpectations(timeout: 10)
}
func testEchoNote() {
let client = connection.client
let expectation = self.expectation(description: "note received")
client.handleNextNotification { (note: Notification<EchoNotification>) in
XCTAssertEqual(note.params.string, "hello!")
expectation.fulfill()
}
client.send(EchoNotification(string: "hello!"))
waitForExpectations(timeout: 10)
}
func testUnknownRequest() {
let client = connection.client
let expectation = self.expectation(description: "response received")
struct UnknownRequest: RequestType {
static let method: String = "unknown"
typealias Response = VoidResponse
}
_ = client.send(UnknownRequest()) { result in
XCTAssertEqual(result, .failure(ResponseError.methodNotFound("unknown")))
expectation.fulfill()
}
waitForExpectations(timeout: 10)
}
func testUnknownNotification() {
let client = connection.client
let expectation = self.expectation(description: "note received")
struct UnknownNote: NotificationType {
static let method: String = "unknown"
}
_ = client.send(UnknownNote())
// Nothing bad should happen; check that the next request works.
_ = client.send(EchoRequest(string: "hello!")) { resp in
XCTAssertEqual(try! resp.get(), "hello!")
expectation.fulfill()
}
waitForExpectations(timeout: 10)
}
func testUnexpectedResponse() {
let client = connection.client
let expectation = self.expectation(description: "response received")
// response to unknown request
connection.clientConnection.sendReply(.success(VoidResponse()), id: .string("unknown"))
// Nothing bad should happen; check that the next request works.
_ = client.send(EchoRequest(string: "hello!")) { resp in
XCTAssertEqual(try! resp.get(), "hello!")
expectation.fulfill()
}
waitForExpectations(timeout: 10)
}
func testSendAfterClose() {
let client = connection.client
let expectation = self.expectation(description: "note received")
connection.clientConnection.close()
client.send(EchoNotification(string: "hi"))
_ = client.send(EchoRequest(string: "yo")) { result in
XCTAssertEqual(result, .failure(ResponseError.cancelled))
expectation.fulfill()
}
connection.clientConnection.sendReply(.success(VoidResponse()), id: .number(1))
connection.clientConnection.close()
connection.clientConnection.close()
waitForExpectations(timeout: 10)
}
func testSendBeforeClose() {
let client = connection.client
let server = connection.server
let expectation = self.expectation(description: "received notification")
client.handleNextNotification { (note: Notification<EchoNotification>) in
expectation.fulfill()
}
server.client.send(EchoNotification(string: "about to close!"))
connection.serverConnection.close()
waitForExpectations(timeout: 10)
}
/// We can explicitly close a connection, but the connection also
/// automatically closes itself if the pipe is closed (or has an error).
/// DispatchIO can make its callback at any time, so this test is to try to
/// provoke a race between those things and ensure the closeHandler is called
/// exactly once.
func testCloseRace() {
for _ in 0...100 {
let to = Pipe()
let from = Pipe()
let expectation = self.expectation(description: "closed")
expectation.assertForOverFulfill = true
let conn = JSONRPCConnection(
protocol: MessageRegistry(requests: [], notifications: []),
inFD: to.fileHandleForReading.fileDescriptor,
outFD: from.fileHandleForWriting.fileDescriptor)
final class DummyHandler: MessageHandler {
func handle<N: NotificationType>(_: N, from: ObjectIdentifier) {}
func handle<R: RequestType>(_: R, id: RequestID, from: ObjectIdentifier, reply: @escaping (LSPResult<R.Response>) -> Void) {}
}
conn.start(receiveHandler: DummyHandler(), closeHandler: {
// We get an error from XCTest if this is fulfilled more than once.
expectation.fulfill()
})
close(to.fileHandleForWriting.fileDescriptor)
// 100 us was chosen empirically to encourage races.
usleep(100)
conn.close()
waitForExpectations(timeout: 10)
}
}
}