Files
sourcekit-lsp/Sources/SourceKitD/SourceKitD.swift
Alex Hoppen 37e6a8a65a Wait for cancellation to propagate in testDontReturnEmptyDiagnosticsIfDiagnosticRequestIsCancelled
I saw a few non-deterministic test failures. I think the issue was that handling of the `CancelRequestNotification` is done asynchronously, which left a short window in which the sourcekitd diagnostics request could run and return results instead of being cancelled. Wait for the diagnostic request to actually be cancelled before running it for real.

While doing this, also introduce proper sourcekitd test hooks instead of relying on the preparation test hooks, which just got run as a side effect.
2024-06-04 11:34:11 -07:00

135 lines
4.6 KiB
Swift

//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2020 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
@_exported import Csourcekitd
import Dispatch
import Foundation
import SKSupport
#if compiler(>=6)
extension sourcekitd_api_request_handle_t: @retroactive @unchecked Sendable {}
#else
extension sourcekitd_api_request_handle_t: @unchecked Sendable {}
#endif
/// Access to sourcekitd API, taking care of initialization, shutdown, and notification handler
/// multiplexing.
///
/// *Users* of this protocol should not call the api functions `initialize`, `shutdown`, or
/// `set_notification_handler`, which are global state managed internally by this class.
///
/// *Implementors* are expected to handle initialization and shutdown, e.g. during `init` and
/// `deinit` or by wrapping an existing sourcekitd session that outlives this object.
public protocol SourceKitD: AnyObject, Sendable {
var testHooks: SourceKitDTestHooks { get }
/// The sourcekitd API functions.
var api: sourcekitd_api_functions_t { get }
/// Convenience for accessing known keys.
var keys: sourcekitd_api_keys { get }
/// Convenience for accessing known keys.
var requests: sourcekitd_api_requests { get }
/// Convenience for accessing known keys.
var values: sourcekitd_api_values { get }
/// Adds a new notification handler, which will be weakly referenced.
func addNotificationHandler(_ handler: SKDNotificationHandler) async
/// Removes a previously registered notification handler.
func removeNotificationHandler(_ handler: SKDNotificationHandler) async
/// Log the given request.
///
/// This log call is issued during normal operation. It is acceptable for the logger to truncate the log message
/// to achieve good performance.
func log(request: SKDRequestDictionary)
/// Log the given request and file contents, ensuring they do not get truncated.
///
/// This log call is used when a request has crashed. In this case we want the log to contain the entire request to be
/// able to reproduce it.
func log(crashedRequest: SKDRequestDictionary, fileContents: String?)
/// Log the given response.
///
/// This log call is issued during normal operation. It is acceptable for the logger to truncate the log message
/// to achieve good performance.
func log(response: SKDResponse)
/// Log that the given request has been cancelled.
func logRequestCancellation(request: SKDRequestDictionary)
}
public enum SKDError: Error, Equatable {
/// The service has crashed.
case connectionInterrupted
/// The request was unknown or had an invalid or missing parameter.
case requestInvalid(String)
/// The request failed.
case requestFailed(String)
/// The request was cancelled.
case requestCancelled
/// Loading a required symbol from the sourcekitd library failed.
case missingRequiredSymbol(String)
}
extension SourceKitD {
// MARK: - Convenience API for requests.
/// - Parameters:
/// - req: The request to send to sourcekitd.
/// - fileContents: The contents of the file that the request operates on. If sourcekitd crashes, the file contents
/// will be logged.
public func send(_ request: SKDRequestDictionary, fileContents: String?) async throws -> SKDResponseDictionary {
log(request: request)
testHooks.sourcekitdRequestDidStart?(request)
let sourcekitdResponse: SKDResponse = try await withCancellableCheckedThrowingContinuation { continuation in
var handle: sourcekitd_api_request_handle_t? = nil
api.send_request(request.dict, &handle) { response in
continuation.resume(returning: SKDResponse(response!, sourcekitd: self))
}
return handle
} cancel: { handle in
if let handle {
logRequestCancellation(request: request)
api.cancel_request(handle)
}
}
log(response: sourcekitdResponse)
guard let dict = sourcekitdResponse.value else {
if sourcekitdResponse.error == .connectionInterrupted {
log(crashedRequest: request, fileContents: fileContents)
}
throw sourcekitdResponse.error!
}
return dict
}
}
/// A sourcekitd notification handler in a class to allow it to be uniquely referenced.
public protocol SKDNotificationHandler: AnyObject, Sendable {
func notification(_: SKDResponse) -> Void
}