Files
sourcekit-lsp/Sources/LanguageServerProtocolJSONRPC/JSONRPCConnection.swift
Alex Hoppen 7c0a910358 Handle messages on a serial queue in Connection
When we switch `SourceKitServer`, `SwiftLanguageServer` etc. to be actors, we can’t rely on them to provide ordering guarantees anymore because Swift concurrency doesn’t provide any ordering guarantees.

What we should thus do, is to handle all messages on a serial queue on the `Connection` level. This queue will be blocked from handling any new messages until a message has been sufficiently handled to avoid out-of-order handling of messages. For sourcekitd, this means that
a request has been sent to sourcekitd and for clangd, this means that we have forwarded the request to clangd.

Note that this serial queue is not the main thread, so we will continue accepting data over stdin, just the handling of those messages is blocked.
2023-09-27 09:47:51 -07:00

462 lines
15 KiB
Swift

//===----------------------------------------------------------------------===//
//
// This source file is part of the Swift.org open source project
//
// Copyright (c) 2014 - 2018 Apple Inc. and the Swift project authors
// Licensed under Apache License v2.0 with Runtime Library Exception
//
// See https://swift.org/LICENSE.txt for license information
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
//
//===----------------------------------------------------------------------===//
#if canImport(CDispatch)
import struct CDispatch.dispatch_fd_t
#endif
import Dispatch
import Foundation
import LanguageServerProtocol
import LSPLogging
/// A connection between a message handler (e.g. language server) in the same process as the connection object and a remote message handler (e.g. language client) that may run in another process using JSON RPC messages sent over a pair of in/out file descriptors.
///
/// For example, inside a language server, the `JSONRPCConnection` takes the language service implemenation as its `receiveHandler` and itself provides the client connection for sending notifications and callbacks.
public final class JSONRPCConnection {
var receiveHandler: MessageHandler? = nil
/// The queue on which we read the data
let queue: DispatchQueue = DispatchQueue(label: "jsonrpc-queue", qos: .userInitiated)
/// The queue on which we send data.
let sendQueue: DispatchQueue = DispatchQueue(label: "jsonrpc-send-queue", qos: .userInitiated)
/// The queue on which all messages (notifications, requests, responses) are
/// handled.
///
/// The queue is blocked until the message has been sufficiently handled to
/// avoid out-of-order handling of messages. For sourcekitd, this means that
/// a request has been sent to sourcekitd and for clangd, this means that we
/// have forwarded the request to clangd.
///
/// The actual semantic handling of the message happens off this queue.
let messageHandlingQueue: AsyncQueue = AsyncQueue()
let receiveIO: DispatchIO
let sendIO: DispatchIO
let messageRegistry: MessageRegistry
/// *For Testing* Whether to wait for requests to finish before handling the next message.
let syncRequests: Bool
enum State {
case created, running, closed
}
/// Current state of the connection, used to ensure correct usage.
var state: State
/// *Public for testing* Buffer of received bytes that haven't been parsed.
public var _requestBuffer: [UInt8] = []
private var _nextRequestID: Int = 0
struct OutstandingRequest {
var requestType: _RequestType.Type
var responseType: ResponseType.Type
var queue: DispatchQueue
var replyHandler: (LSPResult<Any>) -> Void
}
/// The set of currently outstanding outgoing requests along with information about how to decode and handle their responses.
var outstandingRequests: [RequestID: OutstandingRequest] = [:]
var closeHandler: (() -> Void)! = nil
public init(
protocol messageRegistry: MessageRegistry,
inFD: FileHandle,
outFD: FileHandle,
syncRequests: Bool = false)
{
#if os(Linux) || os(Android)
// We receive a `SIGPIPE` if we write to a pipe that points to a crashed process. This in particular happens if the target of a `JSONRPCConnection` has crashed and we try to send it a message.
// On Darwin, `DispatchIO` ignores `SIGPIPE` for the pipes handled by it, but that features is not available on Linux.
// Instead, globally ignore `SIGPIPE` on Linux to prevent us from crashing if the `JSONRPCConnection`'s target crashes.
globallyDisableSigpipe()
#endif
state = .created
self.messageRegistry = messageRegistry
self.syncRequests = syncRequests
let ioGroup = DispatchGroup()
#if os(Windows)
let rawInFD = dispatch_fd_t(bitPattern: inFD._handle)
#else
let rawInFD = inFD.fileDescriptor
#endif
ioGroup.enter()
receiveIO = DispatchIO(type: .stream, fileDescriptor: rawInFD, queue: queue) { (error: Int32) in
if error != 0 {
log("IO error \(error)", level: .error)
}
ioGroup.leave()
}
#if os(Windows)
let rawOutFD = dispatch_fd_t(bitPattern: outFD._handle)
#else
let rawOutFD = outFD.fileDescriptor
#endif
ioGroup.enter()
sendIO = DispatchIO(type: .stream, fileDescriptor: rawOutFD, queue: sendQueue) { (error: Int32) in
if error != 0 {
log("IO error \(error)", level: .error)
}
ioGroup.leave()
}
ioGroup.notify(queue: queue) { [weak self] in
guard let self = self else { return }
self.closeHandler()
self.receiveHandler = nil // break retain cycle
}
// We cannot assume the client will send us bytes in packets of any particular size, so set the lower limit to 1.
receiveIO.setLimit(lowWater: 1)
receiveIO.setLimit(highWater: Int.max)
sendIO.setLimit(lowWater: 1)
sendIO.setLimit(highWater: Int.max)
}
deinit {
assert(state == .closed)
}
/// Start processing `inFD` and send messages to `receiveHandler`.
///
/// - parameter receiveHandler: The message handler to invoke for requests received on the `inFD`.
public func start(receiveHandler: MessageHandler, closeHandler: @escaping () -> Void = {}) {
precondition(state == .created)
state = .running
self.receiveHandler = receiveHandler
self.closeHandler = closeHandler
receiveIO.read(offset: 0, length: Int.max, queue: queue) { done, data, errorCode in
guard errorCode == 0 else {
#if !os(Windows)
if errorCode != POSIXError.ECANCELED.rawValue {
log("IO error reading \(errorCode)", level: .error)
}
#endif
if done { self._close() }
return
}
if done {
self._close()
return
}
guard let data = data, !data.isEmpty else {
return
}
// Parse and handle any messages in `buffer + data`, leaving any remaining unparsed bytes in `buffer`.
if self._requestBuffer.isEmpty {
data.withUnsafeBytes { (pointer: UnsafePointer<UInt8>) in
let rest = self.parseAndHandleMessages(from: UnsafeBufferPointer(start: pointer, count: data.count))
self._requestBuffer.append(contentsOf: rest)
}
} else {
self._requestBuffer.append(contentsOf: data)
var unused = 0
self._requestBuffer.withUnsafeBufferPointer { buffer in
let rest = self.parseAndHandleMessages(from: buffer)
unused = rest.count
}
self._requestBuffer.removeFirst(self._requestBuffer.count - unused)
}
}
}
/// Whether we can send messages in the current state.
///
/// - parameter shouldLog: Whether to log an info message if not ready.
func readyToSend(shouldLog: Bool = true) -> Bool {
precondition(state != .created, "tried to send message before calling start(messageHandler:)")
let ready = state == .running
if shouldLog && !ready {
log("ignoring message; state = \(state)")
}
return ready
}
/// *Public for testing*
public func _send(_ message: JSONRPCMessage, async: Bool = true) {
send(async: async) { encoder in
try encoder.encode(message)
}
}
/// Parse and handle all messages in `bytes`, returning a slice containing any remaining incomplete data.
func parseAndHandleMessages(from bytes: UnsafeBufferPointer<UInt8>) -> UnsafeBufferPointer<UInt8>.SubSequence {
let decoder = JSONDecoder()
// Set message registry to use for model decoding.
decoder.userInfo[.messageRegistryKey] = messageRegistry
// Setup callback for response type.
decoder.userInfo[.responseTypeCallbackKey] = { id in
guard let outstanding = self.outstandingRequests[id] else {
log("Unknown request for \(id)", level: .error)
return nil
}
return outstanding.responseType
} as JSONRPCMessage.ResponseTypeCallback
var bytes = bytes[...]
MESSAGE_LOOP: while true {
do {
guard let ((messageBytes, _), rest) = try bytes.jsonrpcSplitMessage() else {
return bytes
}
bytes = rest
let pointer = UnsafeMutableRawPointer(mutating: UnsafeBufferPointer(rebasing: messageBytes).baseAddress!)
let message = try decoder.decode(JSONRPCMessage.self, from: Data(bytesNoCopy: pointer, count: messageBytes.count, deallocator: .none))
handle(message)
} catch let error as MessageDecodingError {
switch error.messageKind {
case .request:
if let id = error.id {
_send(.errorResponse(ResponseError(error), id: id))
continue MESSAGE_LOOP
}
case .response:
if let id = error.id {
if let outstanding = self.outstandingRequests.removeValue(forKey: id) {
outstanding.replyHandler(.failure(ResponseError(error)))
} else {
log("error in response to unknown request \(id) \(error)", level: .error)
}
continue MESSAGE_LOOP
}
case .notification:
if error.code == .methodNotFound {
log("ignoring unknown notification \(error)")
continue MESSAGE_LOOP
}
case .unknown:
_send(.errorResponse(ResponseError(error), id: nil),
async: false) // synchronous because the following fatalError
break
}
// FIXME: graceful shutdown?
fatalError("fatal error encountered decoding message \(error)")
} catch {
let responseError = ResponseError(code: .parseError,
message: "Failed to decode message. \(error.localizedDescription)")
_send(.errorResponse(responseError, id: nil),
async: false) // synchronous because the following fatalError
// FIXME: graceful shutdown?
fatalError("fatal error encountered decoding message \(error)")
}
}
}
/// Handle a single message by dispatching it to `receiveHandler` or an appropriate reply handler.
func handle(_ message: JSONRPCMessage) {
switch message {
case .notification(let notification):
messageHandlingQueue.async {
notification._handle(self.receiveHandler!, connection: self)
}
case .request(let request, id: let id):
let semaphore: DispatchSemaphore? = syncRequests ? .init(value: 0) : nil
messageHandlingQueue.async {
request._handle(self.receiveHandler!, id: id, connection: self) { (response, id) in
self.sendReply(response, id: id)
}
semaphore?.signal()
}
semaphore?.wait()
case .response(let response, id: let id):
guard let outstanding = outstandingRequests.removeValue(forKey: id) else {
log("Unknown request for \(id)", level: .error)
return
}
outstanding.replyHandler(.success(response))
case .errorResponse(let error, id: let id):
guard let id = id else {
log("Received error response for unknown request: \(error.message)", level: .error)
return
}
guard let outstanding = outstandingRequests.removeValue(forKey: id) else {
log("No outstanding requests for request ID \(id)", level: .error)
return
}
outstanding.replyHandler(.failure(error))
}
}
/// *Public for testing*.
public func send(_rawData dispatchData: DispatchData,
handleCompletion: (() -> Void)? = nil) {
guard readyToSend() else { return }
sendIO.write(offset: 0, data: dispatchData, queue: sendQueue) { [weak self] done, _, errorCode in
if errorCode != 0 {
log("IO error sending message \(errorCode)", level: .error)
if done {
self?.queue.async {
self?._close()
handleCompletion?()
}
}
} else if done {
handleCompletion?()
}
}
}
func send(messageData: Data, handleCompletion: (() -> Void)? = nil) {
var dispatchData = DispatchData.empty
let header = "Content-Length: \(messageData.count)\r\n\r\n"
header.utf8.map{$0}.withUnsafeBytes { buffer in
dispatchData.append(buffer)
}
messageData.withUnsafeBytes { rawBufferPointer in
dispatchData.append(rawBufferPointer)
}
send(_rawData: dispatchData, handleCompletion: handleCompletion)
}
private func sendMessageSynchronously(_ messageData: Data,
timeoutInSeconds seconds: Int) {
let synchronizationSemaphore = DispatchSemaphore(value: 0)
send(messageData: messageData) {
synchronizationSemaphore.signal()
}
// blocks until timeout expires or message sending completes
_ = synchronizationSemaphore.wait(timeout: .now() + .seconds(seconds))
}
func send(async: Bool = true, encoding: (JSONEncoder) throws -> Data) {
guard readyToSend() else { return }
let encoder = JSONEncoder()
let data: Data
do {
data = try encoding(encoder)
} catch {
// FIXME: attempt recovery?
fatalError("unexpected error while encoding response: \(error)")
}
if async {
send(messageData: data)
} else {
sendMessageSynchronously(data, timeoutInSeconds: 3)
}
}
/// Close the connection.
///
/// The user-provided close handler will be called *asynchronously* when all outstanding I/O
/// operations have completed. No new I/O will be accepted after `close` returns.
public func close() {
queue.sync { _close() }
}
/// Close the connection. *Must be called on `queue`.*
func _close() {
sendQueue.sync {
guard state == .running else { return }
state = .closed
log("\(JSONRPCConnection.self): closing...")
// Attempt to close the reader immediately; we do not need to accept remaining inputs.
receiveIO.close(flags: .stop)
// Close the writer after it finishes outstanding work.
sendIO.close()
}
}
/// Request id for the next outgoing request.
func nextRequestID() -> RequestID {
_nextRequestID += 1
return .number(_nextRequestID)
}
}
extension JSONRPCConnection: Connection {
// MARK: Connection interface
public func send<Notification>(_ notification: Notification) where Notification: NotificationType {
guard readyToSend() else { return }
send { encoder in
return try encoder.encode(JSONRPCMessage.notification(notification))
}
}
public func send<Request>(_ request: Request, queue: DispatchQueue, reply: @escaping (LSPResult<Request.Response>) -> Void) -> RequestID where Request: RequestType {
let id: RequestID = self.queue.sync {
let id = nextRequestID()
guard readyToSend() else {
reply(.failure(.serverCancelled))
return id
}
outstandingRequests[id] = OutstandingRequest(
requestType: Request.self,
responseType: Request.Response.self,
queue: queue,
replyHandler: { anyResult in
queue.async {
reply(anyResult.map { $0 as! Request.Response })
}
})
return id
}
send { encoder in
return try encoder.encode(JSONRPCMessage.request(request, id: id))
}
return id
}
public func sendReply(_ response: LSPResult<ResponseType>, id: RequestID) {
guard readyToSend() else { return }
send { encoder in
switch response {
case .success(let result):
return try encoder.encode(JSONRPCMessage.response(result, id: id))
case .failure(let error):
return try encoder.encode(JSONRPCMessage.errorResponse(error, id: id))
}
}
}
}