mirror of
https://github.com/apple/sourcekit-lsp.git
synced 2026-03-02 18:23:24 +01:00
1286407762
Turns out that sourcekitd test hooks were a bad idea because of the following comment that I wrote: ``` `testHooks` are only considered when an instance is being created. If a sourcekitd instance at the given path already exists, its test hooks will be used. ``` During test execution in Xcode, we generate a bunch of `SourceKitServer` instances in the same process that all call `DynamicallyLoadedSourceKitD.getOrCreate`. Now, if `testDontReturnEmptyDiagnosticsIfDiagnosticRequestIsCancelled` is not the first test being executed in the process (which usually it is not), the test hooks in it won’t get used. Switch back to using the preparation hooks, essentially reverting https://github.com/apple/sourcekit-lsp/pull/1412 and keeping the following snippet to fix the underlying issue ```swift // Poll until the `CancelRequestNotification` has been propagated to the request handling. for _ in 0..<Int(defaultTimeout * 100) { if Task.isCancelled { break } usleep(10_000) } ```
79 lines
3.1 KiB
Swift
79 lines
3.1 KiB
Swift
//===----------------------------------------------------------------------===//
|
|
//
|
|
// This source file is part of the Swift.org open source project
|
|
//
|
|
// Copyright (c) 2014 - 2020 Apple Inc. and the Swift project authors
|
|
// Licensed under Apache License v2.0 with Runtime Library Exception
|
|
//
|
|
// See https://swift.org/LICENSE.txt for license information
|
|
// See https://swift.org/CONTRIBUTORS.txt for the list of Swift project authors
|
|
//
|
|
//===----------------------------------------------------------------------===//
|
|
|
|
import Foundation
|
|
import LanguageServerProtocol
|
|
import SKCore
|
|
import SKSupport
|
|
import SemanticIndex
|
|
|
|
import struct TSCBasic.AbsolutePath
|
|
import struct TSCBasic.RelativePath
|
|
|
|
extension SourceKitLSPServer {
|
|
/// Configuration options for the SourceKitServer.
|
|
public struct Options: Sendable {
|
|
/// Additional compiler flags (e.g. `-Xswiftc` for SwiftPM projects) and other build-related
|
|
/// configuration.
|
|
public var buildSetup: BuildSetup
|
|
|
|
/// Additional arguments to pass to `clangd` on the command-line.
|
|
public var clangdOptions: [String]
|
|
|
|
/// Additional paths to search for a compilation database, relative to a workspace root.
|
|
public var compilationDatabaseSearchPaths: [RelativePath]
|
|
|
|
/// Additional options for the index.
|
|
public var indexOptions: IndexOptions
|
|
|
|
/// Options for code-completion.
|
|
public var completionOptions: SKCompletionOptions
|
|
|
|
/// Override the default directory where generated interfaces will be stored
|
|
public var generatedInterfacesPath: AbsolutePath
|
|
|
|
/// The time that `SwiftLanguageService` should wait after an edit before starting to compute diagnostics and
|
|
/// sending a `PublishDiagnosticsNotification`.
|
|
///
|
|
/// This is mostly intended for testing purposes so we don't need to wait the debouncing time to get a diagnostics
|
|
/// notification when running unit tests.
|
|
public var swiftPublishDiagnosticsDebounceDuration: TimeInterval
|
|
|
|
/// Experimental features that are enabled.
|
|
public var experimentalFeatures: Set<ExperimentalFeature>
|
|
|
|
public var indexTestHooks: IndexTestHooks
|
|
|
|
public init(
|
|
buildSetup: BuildSetup = .default,
|
|
clangdOptions: [String] = [],
|
|
compilationDatabaseSearchPaths: [RelativePath] = [],
|
|
indexOptions: IndexOptions = .init(),
|
|
completionOptions: SKCompletionOptions = .init(),
|
|
generatedInterfacesPath: AbsolutePath = defaultDirectoryForGeneratedInterfaces,
|
|
swiftPublishDiagnosticsDebounceDuration: TimeInterval = 2, /* 2s */
|
|
experimentalFeatures: Set<ExperimentalFeature> = [],
|
|
indexTestHooks: IndexTestHooks = IndexTestHooks()
|
|
) {
|
|
self.buildSetup = buildSetup
|
|
self.clangdOptions = clangdOptions
|
|
self.compilationDatabaseSearchPaths = compilationDatabaseSearchPaths
|
|
self.indexOptions = indexOptions
|
|
self.completionOptions = completionOptions
|
|
self.generatedInterfacesPath = generatedInterfacesPath
|
|
self.swiftPublishDiagnosticsDebounceDuration = swiftPublishDiagnosticsDebounceDuration
|
|
self.experimentalFeatures = experimentalFeatures
|
|
self.indexTestHooks = indexTestHooks
|
|
}
|
|
}
|
|
}
|