Commit Graph

6 Commits

Author SHA1 Message Date
Pat Brown
5660c58164 Remove subscriptions from CurrentValueRelay when cancelled (#2699)
* Remove subscription on cancel

* Slight refactor

* Small refactor

Subscription keeps strong reference of `CurrentValueRelay` similar to `CurrentValueSubject`

* Add subscription lifetime tests

* Use weak subscriptions and remove inside send

* Change relay implementation

* For loop better

* Move tests to StoreTests.swift

* A few more locks and a Shared test.

---------

Co-authored-by: Brandon Williams <mbrandonw@hey.com>
2024-09-05 17:04:54 -04:00
Stephen Celis
bc8f27b1d0 Swift Language Support: Drop <5.9 (#3185)
* Swift Language Support: Drop <5.9

* wip

* wip

* wip

* wip

* wip
2024-06-19 07:40:15 -07:00
Brandon Williams
16b47009b9 Use @_spi to test more internals in release. (#1456) 2022-10-11 13:10:16 -04:00
Stephen Celis
d2d994dff5 Cancellation Fixes (#169)
* Failing test when reusing cancellation id.

* wip

* Clean up

* update test

* Update Tests/ComposableArchitectureTests/TimerTests.swift

* move methods around

* wip

* more

* wip

Co-authored-by: Brandon Williams <mbw234@gmail.com>
2020-06-04 13:38:20 -04:00
Stephen Celis
bf24a8cce0 Avoid simultaneous access crash on double-cancel (#137)
* Avoid simultaneous access crash on double-cancel

* fixes

* fix
2020-05-26 19:14:51 -04:00
Brandon Williams
d2240d0e76 The Composable Architecture
Co-authored-by: Stephen Celis <stephen.celis@gmail.com>
2020-05-03 22:26:28 -07:00