Commit Graph

976 Commits

Author SHA1 Message Date
Mason Kim
8821d58ea1 [DOCS] fix minor typo in FileStorageKey (#3305) 2024-08-26 08:47:38 -04:00
MaraMincho
07e5b3340a Edit Effect.swift annotations (#3299) 2024-08-23 08:41:45 -07:00
Hyunjin
7d6feb385a Add missing isActive parameter (#3296) 2024-08-22 16:14:57 -07:00
Brandon Williams
121b608069 Bring back 'observe' for non-UIKit targets. (#3295) 2024-08-22 09:35:20 -07:00
mbrandonw
b432441cbc Run swift-format 2024-08-15 17:43:58 +00:00
Brandon Williams
3a02c5e9fe Fix a bunch of DocC references. (#3287)
* Fix a bunch of DocC references.

* wip

* doc fix

* issue message fix

* swift-navigation 2.0.5
2024-08-15 13:02:49 -04:00
larryonoff
833792ec0f Fix: Crash when writing to user defaults in background thread (#3285)
* Fix: Crash when writing to user defaults in background thread

* Update tests

* Update Tests/ComposableArchitectureTests/AppStorageTests.swift

---------

Co-authored-by: Brandon Williams <135203+mbrandonw@users.noreply.github.com>
2024-08-15 12:59:31 -04:00
Stephen Celis
2c17a936ef Fix ephemeral dismissal (#3286)
* Fix ephemeral dismissal

This regression was introduced to fix a UIKit warning, but it causes
state to not be `nil`'d out in SwiftUI. Luckily we caught it before a
release.

* wip
2024-08-15 09:53:00 -07:00
mbrandonw
27adbdc1e6 Run swift-format 2024-08-13 20:16:24 +00:00
Stephen Celis
dae1b9aafb Leverage UIKitNavigation (#3180)
* wip

* wip

* wip

* Update

* Remove duplicate UIAlertAction convenience initializers (#3188)

* wip

* wip

* wip

* fixes

* wip

* Add nav stack helper

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* watch fix

---------

Co-authored-by: Cosmic Flamingo <67525430+acosmicflamingo@users.noreply.github.com>
Co-authored-by: Brandon Williams <mbrandonw@hey.com>
2024-08-13 16:01:24 -04:00
stephencelis
b5c2a3d7c8 Run swift-format 2024-08-12 15:26:08 +00:00
Stephen Celis
e1f07facd9 Fix some warnings (#3279)
We have a few warnings, mostly in the test suite, that have cropped up
with deprecations and Xcode 16 strict concurrency, so let's address
them.
2024-08-12 08:24:30 -07:00
Stephen Celis
85415973b2 Fix typo 2024-08-05 09:59:28 -07:00
Malte Bünz
3f16c6c927 fix typo (#3268) 2024-08-02 09:31:29 -04:00
hmhv
4864af029d fix some fypo (#3267) 2024-08-02 09:31:06 -04:00
Stephen Celis
8343030d8d Shared: Update XCTFail to reportIssue (#3258) 2024-07-24 16:33:32 -07:00
Stephen Celis
5b6fbc50ba Reference IssueReporting symbols instead of XCTestDynamicOverlay (#3256)
While we should get both dependencies picked up from
swift-dependencies' exports, we've heard reports from folks that they're
getting linker/symbol errors here. We should update these uses
regardless!
2024-07-24 12:37:46 -07:00
Stephen Celis
37241eaf00 Add 1.12 migration guide (#3251)
* Add 1.12 migration guide

* Update MigratingTo1.12.md
2024-07-23 13:25:32 -07:00
aladdin
dc8638af06 docs: fix minor typo (#3252) 2024-07-23 07:19:55 -05:00
Yasuhiro Hatta
379e5f6302 Fix a typo in Tutorial (#3250) 2024-07-23 07:19:36 -05:00
stephencelis
d65f3c1b93 Run swift-format 2024-07-23 00:53:08 +00:00
Stephen Celis
3e830b575a Swift Testing support (#3229)
* wip

* wip

* Update Testing.md

* wip

* wip

* wip

* wip

* wip:

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* disable library evolution

* bump

* wip

---------

Co-authored-by: Brandon Williams <mbrandonw@hey.com>
2024-07-22 17:52:04 -07:00
Oskar Ek
1b627dcdaa Add support for custom decoding/encoding to fileStorage (#3225)
* Add support for custom decoding/encoding to `fileStorage`

* Update FileStorageKey.swift

---------

Co-authored-by: Stephen Celis <stephen.celis@gmail.com>
2024-07-22 08:41:01 -07:00
Brandon Williams
54eb417336 Make 'didSet' main actor. (#3206)
* Make 'didSet' main actor.

* tests for AppStorageKey

* wip

* tests

* clean up

* Update Sources/ComposableArchitecture/SharedState/PersistenceKey/AppStorageKey.swift

* Update Sources/ComposableArchitecture/SharedState/PersistenceKey/AppStorageKeyPathKey.swift

* try working around CI problem

* Added NB

* wip

* Update MigratingTo1.11.md

---------

Co-authored-by: Stephen Celis <stephen@stephencelis.com>
2024-07-17 08:57:43 -07:00
aladdin
ce15c88f42 Fixed minor typos in Shared State documentation (#3237)
* docs: fix typo in Explicit shared state documentation

* docs: fix minor typo
2024-07-14 10:51:42 -04:00
Daichi Hayashi
a996565d22 Fix variable naming in StackBasedNavigation.md (#3210) 2024-07-12 14:59:03 -07:00
aladdin
d4757e3ce2 docs: fix typo in ifCaseLet documentation (#3216) 2024-07-02 09:21:35 -04:00
aladdin
4bbed368b0 docs: fix typo in Scope documentation (#3217) 2024-07-02 09:21:00 -04:00
larryonoff
b5828b231e Fix Shared publisher docs (#3201) 2024-06-24 15:22:23 -04:00
Brandon Williams
4f06955ffa Fix some Docc references. (#3200) 2024-06-24 15:10:22 -04:00
mbrandonw
15d2b12c84 Run swift-format 2024-06-21 19:23:42 +00:00
Brandon Williams
3d343f1fce Some improvements to throttling (#3079)
* Improvements to throttling.

* wip
2024-06-21 15:19:17 -04:00
Brandon Williams
476050cba2 Convert all ActorIsolated to LockIsolated. (#3198) 2024-06-21 15:18:47 -04:00
Ikko Eltociear Ashimine
c0d3ba84e4 Update PersistenceKeyDefault.swift (#3194)
deafult -> default
2024-06-21 10:06:58 -04:00
B Tirumala Rao
309e185d14 Fix typos in the Meet the Composable Architecture tutorial (#3193) 2024-06-21 10:06:33 -04:00
Stephen Celis
1f952d8c69 Update MigratingTo1.11.md 2024-06-19 13:02:55 -07:00
Brandon Williams
662fee0304 Restrict Shared.elements to IdentifiedArray only. (#3187)
* Restrict Shared.elements to IdentifiedArray only.

* wip

* wip

* wip

* fix test

---------

Co-authored-by: Stephen Celis <stephen@stephencelis.com>
2024-06-19 12:26:55 -07:00
Stephen Celis
bc8f27b1d0 Swift Language Support: Drop <5.9 (#3185)
* Swift Language Support: Drop <5.9

* wip

* wip

* wip

* wip

* wip
2024-06-19 07:40:15 -07:00
stephencelis
53bc869b08 Run swift-format 2024-06-19 05:23:17 +00:00
Brandon Williams
32dadd496b Remove duplicates in app storage key. (#3186) 2024-06-18 22:08:25 -07:00
Stephen Celis
31a7045b49 Disfavor shared optional dynamic member lookup (#3170)
* Disfavor shared optional dynamic member lookup

This makes the default work as expected, avoiding the issue brought up
in #3169.

Technically this breaks the following invocation:

```swift
if let wrapped = $shared.optional { /* ... */ }
```

And limits the warning to:

```swift
func share<T>(_: Shared<T>?) {}
share($shared.optional)
```

We consider this lookup to be a bug, though, which is already deprecated
in 1.11.0.

Since we encourage folks to migrate by one minor version at a time, we
should only merge this when we plan on releasing 1.12.0.

* wip
2024-06-18 16:01:46 -07:00
larryonoff
995888141b Update MigratingTo1.11.md (#3184)
Remove unnecessary await
2024-06-18 13:37:38 -04:00
Brandon Williams
ba82946434 Make withLock main actor. (#3178)
* Make withLock main actor.

* Correct backwards compat article.
2024-06-18 12:17:54 -04:00
Sergio Fernández
964c9aa983 Share state appstorage nullable (#3174)
* failing AppStorageKey stored value and set to nil

* setting SharedAppStorageLocals when removing

* Clean up

---------

Co-authored-by: Brandon Williams <mbrandonw@hey.com>
2024-06-17 13:25:12 -07:00
Stephen Celis
fd9ef56bb8 Don't pass embed functions directly to AnyCasePath.init (#3167)
`AnyCasePath` closures will be required to be `@Sendable` for Swift 6
data race checking, but `Enum.case` functions are not `@Sendable`
implicitly. As such we cannot pass `Enum.case` directly to functions
that expect sendable closures. Instead, we must explicitly write:

```swift
{ .case($0) }
```
2024-06-14 13:32:05 -07:00
Seokwoo Jang
3bc77de591 Fixed extension typos in the Building SyncUps tutorial (#3161) 2024-06-12 23:25:10 -07:00
Stephen Celis
7ac630fe4c Support swift-syntax from 600.0.0-latest (#3160)
* Support swift-syntax from 600.0.0-latest

The Xcode 16 beta generates macro projects using these swift-syntax
snapshots. Luckily things seem to be backwards compatible, so we can
expand our supported range.

* wip
2024-06-12 16:02:02 -07:00
Stephen Celis
889c27bc0f Note Swift bug in documentation (#3157)
It'd be good to have a place to point folks to when encountering the
issue.
2024-06-12 15:14:44 -07:00
Rui Peres
aa56697b63 state is not defined (#3159) 2024-06-11 17:11:16 -04:00
David Furman
8631b5fbcc SyncUp tutorial fixes (#3139)
* Fixes for TestingSyncUpForm

* Typo, heirarchy -> hierarchy

* Typo: recursive -> recursively

* Typo: comes -> combines

* Further fixes for TestingSyncUpForm

* Typo: is -> to be

* Typo: add -> we added

* Typo: 3 -> 2

* Adding a note to avoid confusion

* Add more detail to step

* Remove stray whitespace causing a diff to incorrectly display

* Removed step documentation for unused code

* Typo: apart -> a part

* Fix App.Path Equatable conformance

* App -> AppReducer to avoid conflict with SwiftUI.App

* Fix code file link

* Typo: reducer -> reducers

* Add missing mock

* AppReducer -> AppFeature

* Standardize tutorial on `@Shared(.syncUps)`

* Fix mainactor placement

* Fix transcript param not compiling

* Add durationPerAttendee to be usable

* Add a minimal dismiss override to fit with the docs

* Fix commenting out of Tagged discussion

* Fix commenting out of TestingSyncUpDetail discussion

* Undo a whitespace change

* Partial revert of TestingSyncUpForm-02-code-0004.swift

* Undo unintentionally committed code

* Revert "Add missing mock"

This reverts commit 9672ecbd20.

* Revert "Fixes for TestingSyncUpForm"

This reverts commit 5bece14c2a.

* wip

---------

Co-authored-by: Stephen Celis <stephen@stephencelis.com>
2024-06-07 11:35:19 -07:00