Stephen Celis
c432a76b5b
Navigation ( #1945 )
...
* wip
* fix
* wip
* wip
* move
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* Fix
* wip
* wip
* Renamed action to onTap in NavigationLinkStore (#2043 )
Renamed the `action` parameter to mirror other inits and differentiate itself from `action fromDestinationAction`
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* Tie view identity to stack element identity
* Tie item identity to case
* wip
* wip
* cleanup
* fix
* fix
* Add warning to nav link
* wip
* wip
* Rename FullscreenCover.swift to FullScreenCover.swift (#2062 )
* wip
* fix isDetailLink on non-iOS platforms
* Correct some comments in Effect.swift (#2081 )
* add integration tests for showing alert/dialog from alert/dialog.
* copy StackElementIDGenerator dependency before running TestStore receive closure.
* Removed some unneeded delegate actions.
* wip
* clean up
* lots of clean up
* Converted voice memos back to identified array
* update deps
* update docs for DismissEffect
* wip
* Add Sendable conformance to PresentationState (#2086 )
* wip
* swift-format
* wip
* wip
* docs
* wip
* wip
* Catch some typos in Articles (#2088 )
* wip
* wip
* wip
* wip
* wip
* docs
* wip
* wip
* docs
* wip
* wip
* wip
* wip
* docs
* docs
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* Fix invalid states count for 3 optionals and typos (#2094 )
* wip
* wip
* more dismisseffect docs
* fixed some references
* navigation doc corrections
* more nav docs
* fix cancellation tests in release mode
* wrap some tests in #if DEBUG since they are testing expected failures
* update UUIDs in tests to use shorter initializer
* fixed a todo
* wip
* fix merge errors
* wip
* fix
* wip
* wip
* fixing a bunch of todos
* get rid of rawvalue in StackElementID
* more todos
* NavLinkStore docs
* fix swift 5.6 stuff
* fix some standups tests
* fix
* clean up
* docs fix
* fixes
* wip
* 5.6 fix
* wip
* wip
* dont parallelize tests
* updated demo readmes
* wip
* Use ObservedObject instead of StateObject for alert/dialog modifiers.
* integration tests for bad dismissal behavior
* check for runtime warnings in every integration test
* wip
* wip
* fix
* wip
* wip
* wip
* wip
* wip
* Drop a bunch of Hashables.
* some nav bug fixes
* wip
* wip
* wip
* fix
* fix
* wip
* wip
* Simplify recording test.
* add concurrent async test
* fix
* wip
* Refact how detail dismisses itself.
* fix
* 5.6 fix
* wip
* wip
* Add TestStore.assert.
* Revert "Add TestStore.assert."
This reverts commit a892cccc66#2121 )
* Add TestStore.assert. (#2123 )
* Add TestStore.assert.
* wip
* Update Sources/ComposableArchitecture/TestStore.swift
Co-authored-by: Stephen Celis <stephen@stephencelis.com >
* Update Sources/ComposableArchitecture/Documentation.docc/Extensions/TestStore.md
Co-authored-by: Stephen Celis <stephen@stephencelis.com >
* fix tests
---------
Co-authored-by: Stephen Celis <stephen@stephencelis.com >
* Run swift-format
* push for store.finish and presentation
* move docs around
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* Add case subscripts
* wip
* wip
* 5.7-only
* wip
* wip
* wip
* wip
* revert store.finish task cancellation
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* add test for presentation scope
* wip
* wip
* wip
* wip
* wip
* cleanup
* updated presentation scope test
* sytnax update
* clean up
* fix test
* wip
* wip
* wip
* wip
* wip
---------
Co-authored-by: Brandon Williams <mbrandonw@hey.com >
Co-authored-by: Martin Václavík <mvaclavik96@icloud.com >
Co-authored-by: 유재호 <y73447jh@gmail.com >
Co-authored-by: Jackson Utsch <jutechs@gmail.com >
Co-authored-by: Dmytro <barabashdmyto@gmail.com >
Co-authored-by: Brandon Williams <135203+mbrandonw@users.noreply.github.com >
Co-authored-by: mbrandonw <mbrandonw@users.noreply.github.com >
2023-05-30 12:22:00 -04:00
Stephen Celis
14c11ade59
Don't pass file and line to runtime warnings ( #2059 )
...
Runtime warnings are not test helpers that should propagate XCTest
failures to the original file/line, so we should always omit that
information. This leads to better test failures that show up alongside
the test, not buried in application code.
2023-04-25 11:40:02 -07:00
Stephen Celis
0087051b99
Fix some Xcode 14.3 warnings ( #1920 )
2023-02-17 10:26:33 -08:00
Stephen Celis
2d943dadae
Loosen platform requirements for Dependencies library ( #1466 )
...
* Loosen platform requirements for Dependencies
Dependencies depends on runtime warning functionality, which is brought
in via the "os" module. If we check for availability we can allow the
Dependencies module to be used from multiplatform libraries, as we have
in isowords.
* More agnostic
* wip
* Update RuntimeWarnings.swift
* Update RuntimeWarnings.swift
2022-10-11 15:14:37 -07:00
Brandon Williams
b8294b89d5
ReducerProtocol ( #1283 )
...
* Add previewValue to DependencyKey, and fixed build errors on Xcode 13.
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* Add Xcode 14 to CI (#1266 )
* Add Xcode 14 to CI
* Update ci.yml
* wip
* wip
* Update Makefile
* Update Makefile
* wip
* runtime warning when no live dependency available for live app
* bring back live
* wip
* soft deprecate Reducer
* fusion test
* ternary clean up
* wip
* add some todos
* typealias Reducer inside AnyReducer
* Add `now` convenience property to date dependency (#1286 )
* Remove type alias
* LiveDependencyKey: DependencyKey -> DependencyKey: TestDependencyKey (#1288 )
* LiveDependencyKey: DependencyKey -> DependencyKey: TestDependencyKey
* wip
* wip
* wip
* wip
* wip
* fix
* wip
* fix navigate case studies
* wip
* fixes and docs
* more migration
* wip
* wip
* thread deps through ifLet and forEach examples.
* update
* clean up
* wip
* wip
* Update MigratingToReducerProtocols.md
* wip
* wip
* docs
* docs
* fix some docs
* Fix for CombineReducers compiler bug
* wip
* wip
* wip
* wip
* todos for docs
* Don't warn for overridden test dependencies (#1324 )
* Don't warn while setting test dependencies
* wip
* fix conflict
* wip
* Docs and deprecations
* add binding info
* wip
* Add URL session
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* Don't run debug reducer in tests
* wip
* updated reducer debugging
* Update UUID.swift (#1374 )
* wip
* optional
* added Self as default associatedtype value for TestDependencyKey.value (#1395 )
* added Self as default associatedtype value for TestDependencyKey.value
* Update Tests/ComposableArchitectureTests/DependencyKeyTests.swift
Co-authored-by: Brandon Williams <135203+mbrandonw@users.noreply.github.com >
* Update example to set badge to the unread count (#1391 )
* Add store.finish().
* Fix warnings introduced in Xcode 14.1 (#1388 )
* Fix warnings introduced in Xcode 14.1
* wip
* Conform dependency values to DependencyKey where convenient
* fix
* Fail if testValue is invoked without providing implementation (#1399 )
* Update example to set badge to the unread count (#1391 )
* Add store.finish().
* Fix the CaseStudies (UIKit) (#1392 )
* Fix warnings introduced in Xcode 14.1 (#1388 )
* Fix warnings introduced in Xcode 14.1
* wip
* Fail when accessing testValue when one hasn't been provided.
* wip
* wip
* wip
* test
Co-authored-by: Mark Adams <hyperspacemark@users.noreply.github.com >
Co-authored-by: Maciek Czarnik <Czajnikowski@users.noreply.github.com >
Co-authored-by: Stephen Celis <stephen@stephencelis.com >
* Add DateGenerator.init(_ generate:)
* Start running some tests in release config. (#1405 )
* Start running some tests in release config.
* wip
* wip
* wip
* wip
* wip
* Update Sources/ComposableArchitecture/Store.swift
Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com >
* wip
* wip
Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com >
* added test that dependencies are transferred to effects
* wip
* self
* clean up
* simplify
* fix
* doc fixes
* wip
* fix
* wip
* wip
* wip
* fix
* Run dependencies tests on CI. (#1408 )
* Run dependencies tests on CI.
* wip
* update makefile
* wtf
* more docs
* more docs
* wip
* docs
* wip
* docs
* wip
* message tweaks
* wip
* docs and clean up
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* typo fix
* docs clean up
* doc fixes
* cancel in progress
* cancel in progress
* no need to make recope release-only, and make more use of XCTAssert to get better release tests
* fix test
* Remove ActorIsolated from tests where it's not needed
* fix test
* wip
* wip
* Add a benchmark for dependency key writing.
* fix test
* make benchmark 5.7 compatible
* iflet docs
* more docs
* dependency docs
* rearrange
* @Dependency docs
* docs
* fix benchmark in 5.6
* doc fix
* wip
* wip
* wip
* wip
* more docs
* clean up
* fix
* wip
* Fixes compilation on watchOS (#1423 )
Co-authored-by: Gunnar Herzog <gunnar.herzog@kf-interactive.com >
* move deprecation
* format
* wip
* Fix openURL
* wip
* wip
* wip
* wip
* fix
* Keep simple
* Reducer.debug -> Reducer._printChanges
We want to revisit some of these debugging APIs in the future, so let's
keep them around, but underscore them to allow for more flexible
evolution.
* `ReducerProtocol.debug` -> `ReducerProtocol._printChanges` (#1426 )
* Reducer.debug -> Reducer._printChanges
We want to revisit some of these debugging APIs in the future, so let's
keep them around, but underscore them to allow for more flexible
evolution.
* Update DebugTests.swift
* OpenURL fix for macCatalyst (#1429 )
* OpenURL fix for macCatalyst
Fixes #1428 .
* Update Makefile
* Correct typo in "Designing dependencies" chapter (#1430 )
protocol AudioPlayerClient should be a struct
* fix
* fix
* protocol docc
* docs
* Typos (#1439 )
* remove unneeded internals
* wip
* Fix missing parameter in code sample (#1450 )
* typo fix
* more docs for DependencyKeyWritingReducer
* wip
* wip
* update readme
* wip
* update image
* main actor
* Added withValue, added docs and tests
* public properties
* cleaned up overload
* changed reducer->feature in a bunch of spots of dependencies docs
* add articles to readme
* 6
* fix tests for swift 5.6
* tweak
* tweak
* Update ReducerProtocol.swift
* wip
* wip
* docs update
* docs for conforming dependency directly to DependencyKey
* typo fix
* performance article update
* fixes
* deprecate another effect timer API
* link to migration doc in deprecation messages
* make some tests that deal with line numbers less fragile
* package.swift clean up
* tweak to echos
* remove docs at root, not in docs-out
* remove todo
* update WithViewStore.init deprecation message to explain and link to performance doc
* Add back ReducerProtocolOf for 5.7.1 (#1444 )
* Add back ReducerProtocolOf for 5.7.1
* wip
* Move scheme tests to matrix
* streamline
* try this
* store.finish
* wip
* dependencies -> transformDependency
* wip
* wip
* Compat
* fix
* preserve deps for combine publishers
* Remove dump calls (#1460 )
* Fix compiler errors for library evolution. (#1443 )
* Fix compiler errors for library evolution.
* wip
* wip
* work around ambiguous init
* Revert "work around ambiguous init"
This reverts commit 002a199d59stephen@stephencelis.com >
Co-authored-by: Ken Grigsby <kgrigsby@mac.com >
Co-authored-by: Petr Sima <ptea.sima@gmail.com >
Co-authored-by: Mark Adams <hyperspacemark@users.noreply.github.com >
Co-authored-by: Maciek Czarnik <Czajnikowski@users.noreply.github.com >
Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com >
Co-authored-by: Gunnar Herzog <github@trispo.de >
Co-authored-by: Gunnar Herzog <gunnar.herzog@kf-interactive.com >
Co-authored-by: Guttorm Aase <guttormaase@gmail.com >
Co-authored-by: Julien Sagot <contact@juliensagot.fr >
Co-authored-by: Jaanus Siim <jaanussiim+github@gmail.com >
2022-10-10 11:37:50 -04:00
Brandon Williams
108e3a536f
Concurrency Beta ( #1189 )
...
* more main actor audit
* wip
* wip
* fix
* better task result ==
* task result tests
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* fix merge conflicts
* wip
* wip
* lots of doc fixes and modernizations
* lots more docs and better hashable conformance for TaskResult
* more docs
* clean up
* more tests and docs
* clean up
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* small clean up
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* explicit
* wip
* fix bug in TestStore.receive
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* fixes
* wip
* tools for non-deterministic TestStore.receive
* fix
* wip
* wip
* remove inAnyOrder stuff
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* convert download case study to use async/await
* animations
* fix tests
* remove executor experiment
* wip
* wip
* wip
* wip
* wip
* speech simplification
* wip
* wip
* wip
* wip
* wip
* wip
* add a few todos
* wrote some tests
* simplify speech recognizer
* fix tests
* update some docs about error throwing behavior
* wip
* wip
* fix
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* wip
* Swift 5.5.2 fixes
* wip
* Bump timeout
* wip
* wip
* Finesse
* proper way to detect main queue
* extra guard
* revert main queue check
* move stuff around
* docs
* fixed a bunch of warnings
* Fix references
* clean up
* clean up
* fix a bunch of warnings
* clean up
* un-soft deprecate concatenate
* async teststore.send
* fix uikit tests
* drop sendable
* wip
* wip
* wip
* wip
* wip
* clean up
* clean up
* reorganize, remove extra task cancellation handler
* wip
* wip
* wip
* wip
* wip
* wip
* Make TestStore.send async (#1190 )
* async teststore.send
* fix uikit tests
* Converted all tests to async
* clean up
* added docs
* Update Sources/ComposableArchitecture/TestStore.swift
Co-authored-by: Stephen Celis <stephen@stephencelis.com >
* Update Sources/ComposableArchitecture/TestStore.swift
Co-authored-by: Stephen Celis <stephen@stephencelis.com >
* docs and readme update
* Update README.md
* Update Tests/ComposableArchitectureTests/StoreTests.swift
Co-authored-by: Stephen Celis <stephen@stephencelis.com >
* fix
* Update Sources/ComposableArchitecture/TestStore.swift
Co-authored-by: Stephen Celis <stephen@stephencelis.com >
* Update Sources/ComposableArchitecture/TestStore.swift
Co-authored-by: Stephen Celis <stephen@stephencelis.com >
* Update Sources/ComposableArchitecture/TestStore.swift
Co-authored-by: Stephen Celis <stephen@stephencelis.com >
* clean up
Co-authored-by: Stephen Celis <stephen@stephencelis.com >
* wip
* wip
* wip
* make fetchNumber throwing and fix tests
* effect basics clean up
* use local state for isLoading in refreshable case study
* clean up
* fix test
* wip
* wip
* wip
* wip
* wip
* wip
* fixes
* clean up
* clean up
* Simplify
* wip
* clean up
* wip
* AsyncStream.finished()
* give Send a public initializer
* make send public
* temporarily make box public
* remove concurrency flag
* wip
* wip
* wip
* wip
* wip
* docs
* speech
* simplify
* clean up;
* unchecked sendable
* clean up
* clean up
* wip
* docs
* docs
* more docs
* lots of docs
* wip
* wip
* wip
* more docs for streamWithContinuation
* wip
* wip
* wip
* Make internal, too
* wip
* Remove sendability detection
It breaks things, like:
let request = UncheckedSendable(
SKProductsRequest(productIdentifiers: []
)
// UncheckedSendable<NSObject> // *not* _<SKProductsRequest>
* wip
* doc clean up;
* fixed some todos
* docs
* wip
* remove thread safety FAQ from readme
* fix test
* wip
* docs clean up
* docs clean up
* added a testing article and fixed some docs
* rearrange
* docs clean up
* wip
* Update Sources/ComposableArchitecture/Documentation.docc/Articles/Testing.md
Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com >
* Update Sources/ComposableArchitecture/Effects/ConcurrencySupport.swift
Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com >
* Update Sources/ComposableArchitecture/Effects/ConcurrencySupport.swift
Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com >
* Update Sources/ComposableArchitecture/Effects/ConcurrencySupport.swift
Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com >
* Update Sources/ComposableArchitecture/Effects/ConcurrencySupport.swift
Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com >
* Update Sources/ComposableArchitecture/Documentation.docc/Articles/Testing.md
Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com >
* Update Sources/ComposableArchitecture/Documentation.docc/Articles/Testing.md
Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com >
* Update Sources/ComposableArchitecture/Documentation.docc/Articles/Testing.md
Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com >
* Update Sources/ComposableArchitecture/Documentation.docc/Articles/Testing.md
Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com >
* Update Sources/ComposableArchitecture/Documentation.docc/Articles/Testing.md
Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com >
* Update Sources/ComposableArchitecture/Documentation.docc/Articles/Testing.md
Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com >
* Update Sources/ComposableArchitecture/Documentation.docc/Articles/Testing.md
Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com >
* wip
* wip
* wip
Co-authored-by: Stephen Celis <stephen@stephencelis.com >
Co-authored-by: Thomas Grapperon <35562418+tgrapperon@users.noreply.github.com >
2022-08-08 01:04:16 -04:00
Stephen Celis
43e891d641
Fail if testing, runtime warn otherwise ( #1185 )
...
* Fail if testing, runtime warn otherwise
Doing both at once is noisy in tests.
* wip
2022-07-05 12:29:35 -04:00
mbrandonw
96f47fbe85
Run swift-format
2022-04-08 16:57:56 +00:00
Brandon Williams
c8482eb61b
Move DEBUG check to runtimeWarning function. ( #1056 )
...
* Move DEBUG check to runtimeWarning function.
* wip
2022-04-08 09:48:35 -07:00
Pat Brown
02ac00d4ed
Add transparent attribute to runtimeWarning ( #1024 )
2022-03-15 20:18:17 -04:00
Stephen Celis
2828dc44f6
Runtime Warning Finesse ( #1023 )
2022-03-15 16:21:13 -04:00
mcfans
ba9c626ab1
Improved way to get SwiftUI image handle ( #945 )
...
* Improved way to get SwiftUI image handle
* Use #dsohandle instead of fatalerror
* Search /SwiftUI instead and use dyld image header pointer instead of convert it
Previous approch will crash on mac platform but ok with iOS simulator
2022-01-11 10:04:27 -05:00
Stephen Celis
313dd217dc
Improving developer experience with runtime warnings ( #943 )
...
* Perform thread check only when store is created on main thread.
* clean up
* Update Sources/ComposableArchitecture/Store.swift
* clean up
* Update Sources/ComposableArchitecture/Store.swift
* clean up
* execute setSpecific only once.
* logic fix
* added a test
* typo
* wip
* wip
* wip
* clean up
* language
* wip
* note
* wip
* wip
* wip
* wip
* wip
* fix closing quote
* wip
* fix merge
* Deprecations
* Fix docs
* wip
Co-authored-by: Brandon Williams <mbrandonw@hey.com >
2022-01-03 10:55:13 -06:00
