Commit Graph

20 Commits

Author SHA1 Message Date
Stephen Celis
f0098d8232 Add cancel overloads that take types (#1078)
* Add cancel overloads that take types

* wip
2022-05-03 21:00:24 -04:00
Stephen Celis
bf521e9e5d Improve performance of type-safe effect cancel token lookup (#1077)
* Add type discriminator to effect cancel id hashing

* wip
2022-05-03 17:35:09 -04:00
Pat Brown
5da277f16f Effect.cancel(ids:) prefer array of ids and deprecate variadic overload (#1041)
* Use array of ids and deprecate variadic overload

* Update Sources/ComposableArchitecture/Internal/Deprecations.swift

Co-authored-by: Stephen Celis <stephen.celis@gmail.com>
2022-03-29 17:09:22 -04:00
Pat Brown
e828aeb496 Effect.cancel(ids:) prefer sequence of ids over variadic list. (#1009)
* Disfavor variadic cancellation

* Changed ids paramter from array to sequence

* Small typo
2022-02-24 10:23:26 -08:00
Pat Brown
ed4c236973 Send completion for cancellation subject (#997) 2022-02-07 09:34:19 -05:00
Stephen Celis
3cbc9d7daf Don't consider an effect in-flight till it's kicked off (#977) 2022-01-21 16:20:35 -05:00
stephencelis
1ab5bb151a Run swift-format 2022-01-21 18:30:06 +00:00
iampatbrown
a9265d435a Cancel in flight effects inline instead of returning concatenated effect (#976) 2022-01-21 13:11:14 -05:00
stephencelis
2975d410d6 Run swift-format 2022-01-07 21:19:35 +00:00
iampatbrown
e5e10d8e87 Update .cancellable implementation to fix #946 (#949)
* Subscribe to upstream publisher instead of PassthroughSubject

* Fixed operator order

* Replaced RunLoop.immediate with RunLoop.test
2022-01-07 16:10:42 -05:00
Brandon Williams
c9653cf57b Cancel multiple effects with a variadic list. (#676)
* Cancel multiple effects with a variadic list.

* genericize

* doc fix

* use array
2021-07-26 16:05:50 -04:00
Stephen Celis
d30336ca13 Clean-up pass for DocC (#599) 2021-06-16 08:48:14 -05:00
Wendy Liga
1a8bccc62e Support DocC Xcode 13 (#591)
* wip

* finish

* revert back code snippet identation to 5

* Update Sources/ComposableArchitecture/Effect.swift

Co-authored-by: Brandon Williams <135203+mbrandonw@users.noreply.github.com>

Co-authored-by: Brandon Williams <135203+mbrandonw@users.noreply.github.com>
2021-06-14 14:10:08 -04:00
Stephen Celis
af1dcf09cf Restore original cancellation logic (#245)
* Revert "Run swift-format"

This reverts commit 6a5b8f276f.

* Revert "Fix iOS 14 Cancellation Crash (#244)"

This reverts commit 2bf1be6bcf.

* Xcode 12 CI

* Update ci.yml
2020-08-06 10:04:02 -04:00
stephencelis
6a5b8f276f Run swift-format 2020-08-03 17:57:32 +00:00
Stephen Celis
2bf1be6bcf Fix iOS 14 Cancellation Crash (#244)
* wip

* wip

Co-authored-by: Brandon Williams <mbw234@gmail.com>
2020-08-03 13:56:24 -04:00
stephencelis
dd707b7bd6 Run swift-format 2020-06-04 17:44:38 +00:00
Stephen Celis
d2d994dff5 Cancellation Fixes (#169)
* Failing test when reusing cancellation id.

* wip

* Clean up

* update test

* Update Tests/ComposableArchitectureTests/TimerTests.swift

* move methods around

* wip

* more

* wip

Co-authored-by: Brandon Williams <mbw234@gmail.com>
2020-06-04 13:38:20 -04:00
Stephen Celis
bf24a8cce0 Avoid simultaneous access crash on double-cancel (#137)
* Avoid simultaneous access crash on double-cancel

* fixes

* fix
2020-05-26 19:14:51 -04:00
Brandon Williams
d2240d0e76 The Composable Architecture
Co-authored-by: Stephen Celis <stephen.celis@gmail.com>
2020-05-03 22:26:28 -07:00