Commit Graph

67 Commits

Author SHA1 Message Date
Stephen Celis
c8a2e9490a Test Store documentation updates (#1129) 2022-06-03 17:02:38 -04:00
Stephen Celis
c232a9f353 Swift 5.7 fixes (#1089)
* Fix Swift 5.7 warnings

* Fix Swift 5.7 threading issue
2022-05-12 13:07:37 -04:00
mbrandonw
96f47fbe85 Run swift-format 2022-04-08 16:57:56 +00:00
Brandon Williams
c8482eb61b Move DEBUG check to runtimeWarning function. (#1056)
* Move DEBUG check to runtimeWarning function.

* wip
2022-04-08 09:48:35 -07:00
stephencelis
ea07f63f3d Run swift-format 2022-03-29 21:17:14 +00:00
Pat Brown
5da277f16f Effect.cancel(ids:) prefer array of ids and deprecate variadic overload (#1041)
* Use array of ids and deprecate variadic overload

* Update Sources/ComposableArchitecture/Internal/Deprecations.swift

Co-authored-by: Stephen Celis <stephen.celis@gmail.com>
2022-03-29 17:09:22 -04:00
Pat Brown
02ac00d4ed Add transparent attribute to runtimeWarning (#1024) 2022-03-15 20:18:17 -04:00
Stephen Celis
2828dc44f6 Runtime Warning Finesse (#1023) 2022-03-15 16:21:13 -04:00
mcfans
ba9c626ab1 Improved way to get SwiftUI image handle (#945)
* Improved way to get SwiftUI image handle

* Use #dsohandle instead of fatalerror

* Search /SwiftUI instead and use dyld image header pointer instead of convert it

Previous approch will crash on mac platform but ok with iOS simulator
2022-01-11 10:04:27 -05:00
Stephen Celis
313dd217dc Improving developer experience with runtime warnings (#943)
* Perform thread check only when store is created on main thread.

* clean up

* Update Sources/ComposableArchitecture/Store.swift

* clean up

* Update Sources/ComposableArchitecture/Store.swift

* clean up

* execute setSpecific only once.

* logic fix

* added a test

* typo

* wip

* wip

* wip

* clean up

* language

* wip

* note

* wip

* wip

* wip

* wip

* wip

* fix closing quote

* wip

* fix merge

* Deprecations

* Fix docs

* wip

Co-authored-by: Brandon Williams <mbrandonw@hey.com>
2022-01-03 10:55:13 -06:00
Stephen Celis
25f943cf3c Deprecate TestStore.assert (#912) 2021-12-07 21:10:02 -05:00
stephencelis
f92c2aec78 Run swift-format 2021-09-20 15:03:19 +00:00
Stephen Celis
0cd0c3ecce Update AlertState to use new APIs (#794)
* Update AlertState to use new APIs

* fix

* Feedback

* wip

* Fix

* wip

* wip

* wip

* wip
2021-09-20 10:42:17 -04:00
Stephen Celis
8260a1ab8d Fix bindable deprecations (#815)
* Fix Bindable Deprecations

* More CI

* wip

* wip

* wip

* wip
2021-09-20 10:03:43 -04:00
stephencelis
71421c6e39 Run swift-format 2021-09-17 20:41:42 +00:00
iampatbrown
4b8db86edb Alternative to CurrentValueSubject in ViewStore (#755)
* Replaced CurrentValueSubject with CurrentValueRelay

* Added final to DemandBuffer

Co-authored-by: Brandon Williams <mbrandonw@hey.com>
2021-09-17 16:33:13 -04:00
stephencelis
e80da5cb0f Run swift-format 2021-09-17 17:35:06 +00:00
Stephen Celis
4bdcaafcd0 Deprecate Store.publisherScope (#758)
* Deprecate Store.publisherScope

* wip

* fix

* wip
2021-09-17 13:12:52 -04:00
Stephen Celis
c0c95c5bab Deprecate dynamic member lookup on view stores in favor of ViewStore.binding (#810)
* wip

* wip
2021-09-17 12:33:38 -04:00
Stephen Celis
a554b00ff4 Remove old deprecations (#795)
* Remove old deprecations

* wip
2021-09-14 22:30:38 -04:00
Stephen Celis
7ede19f9b5 Improve deprecation warnings for old binding helpers (#774)
* Improve deprecation warnings for old binding helpers

* wip

* wip

* wip

* esc

* wip
2021-09-07 11:38:57 -04:00
stephencelis
60dc806718 Run swift-format 2021-09-06 15:19:19 +00:00
Stephen Celis
af88fe4c79 Safer, Conciser Bindings (#765)
* Better binding tools.

* make everything public

* deprecate

* update

* clean up

* wip

* dml

* wip

* wip

* Fix a redundant conformance constraint warning in ForEachStore (#738)

The warning was:

    Sources/ComposableArchitecture/SwiftUI/ForEachStore.swift:141:28: warning: redundant conformance constraint 'EachContent' : 'View'
      public init<EachContent: View>(
                               ^
    Sources/ComposableArchitecture/SwiftUI/ForEachStore.swift:146:16: note: conformance constraint 'EachContent' : 'View' implied here
        EachContent: View,
                   ^

I fixed the warning by removing the redundant constraint from the type
parameter.

* wip

* wip

* wip

* wip

* wip

* wip

* wip

Co-authored-by: Brandon Williams <mbrandonw@hey.com>
Co-authored-by: Adam Roben <aroben@apple.com>
2021-09-06 11:10:47 -04:00
Brandon Williams
1f2f6124be Update Exports.swift (#749) 2021-08-25 10:45:57 -04:00
Stephen Celis
575d7c0d59 Use Custom Dump (#736)
* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* fix

* wip

* wip

* Model Tic-Tac-Toe board using proper type

* wip

* wip

* wip

* wip

Co-authored-by: Brandon Williams <mbrandonw@hey.com>
2021-08-22 22:45:27 -04:00
Stephen Celis
b73f74f68d Make file/line parameters explicit (#729) 2021-08-20 09:00:16 -04:00
Stephen Celis
2d1e21b5aa Convert #file to #fileID for debug purposes (#708) 2021-08-11 11:54:36 -04:00
Stephen Celis
5209f47b03 Update AlertState.Button APIs for animation (#681)
* Update AlertState.Button APIs for animation

* fix

* wip

* deprecate
2021-07-28 12:10:15 -04:00
konomae
60fbb66016 Fix minor typo (#671)
* Fix typo: iff → if

* Add missing `>`
2021-07-26 08:17:31 -04:00
Stephen Celis
e7dda73c35 Fix Effect.throttle (#654)
* Fix Effect.throttle

Fixes #540.

* Simplify

* Publicize
2021-07-13 11:06:51 -04:00
Stephen Celis
ac7ea43ff2 Merge remote-tracking branch 'origin/main' into ia 2021-07-09 15:41:49 -04:00
Stephen Celis
50a16e072e Deprecate array-based forEach/ForEachStore (#641)
* Deprecate array-based forEach/ForEachStore

* Update tests
2021-07-08 10:49:13 -04:00
mbrandonw
fd770f93a6 Run swift-format 2021-07-08 13:56:53 +00:00
Brandon Williams
96a4654767 Bring back deprecated IfLetStore initializer. (#638) 2021-07-08 09:47:38 -04:00
Brandon Williams
5f6d8a2538 Don't use CasePath in .binding (#632)
* Don't use CasePath in .binding

* wip

* wip

* wip
2021-07-07 18:05:43 -04:00
Brandon Williams
e32172b268 Remove some old deprecated code. (#629) 2021-07-05 13:21:13 -04:00
Stephen Celis
e1c7077cd1 wip 2021-06-25 16:42:22 -04:00
Stephen Celis
fab3510d54 wip 2021-06-25 13:06:45 -04:00
Brandon Williams
3d8db944c7 Add SwitchStore and CaseLet (#594)
* wip

* ttt

* simplfiy

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* fix

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* wip

* docs

* wip

* wip

* wip

* wip

* wip

* updates

* revert ttt stuff'

* xcode 11 fixes

Co-authored-by: Stephen Celis <stephen@stephencelis.com>
2021-06-14 10:46:36 -04:00
stephencelis
155e031dd7 Run swift-format 2021-06-01 17:02:26 +00:00
Stephen Celis
dc3576bbd8 Only breakpoint when debugger is attached (#579)
* Only breakpoint when debugger is attached

* Update Breakpoint.swift

* Add breakpoint instruction
2021-06-01 09:46:31 -07:00
Brandon Williams
6146345c18 Add a few more store tests. (#516)
* Add a few more store tests.

* wip

* wip

* tweaks

* wip
2021-04-28 17:06:55 -05:00
Stephen Celis
c53a961920 Add @ViewBuilder to ForEachStore and IfLetStore (#501)
* Add @ViewBuilder to ForEachStore and IfLetStore

* Update IfLetStore else branch to take view builder
2021-04-20 11:10:30 -04:00
Stephen Celis
5bdf0bc904 FormAction → BindingAction (#372)
* Rename FormAction to BindingAction

* Deprecations

* Fix test

* Update 01-GettingStarted-Bindings-Forms.swift
2021-02-01 16:41:36 -05:00
Stephen Celis
4449bc2e24 Add TextState (for AlertState, ActionSheetState, etc.) (#359)
* Use SwiftUI.Text with {Alert,ActionSheet}State

Fix #293, #318.

* Use public interface

* Availability

* TextState

* Note

* Simplify

* Update LocalizedStringTests.swift

* Fix warnings

* Fix docs
2021-01-21 17:50:34 -05:00
Stephen Celis
5ddbcdd21a Rename publisher-transforming scope (#314)
* Rename publisher-transforming scope

* feedback
2020-10-29 17:29:52 -04:00
Stephen Celis
c4f225b825 Extract supplemental libraries (#315)
* Extract supplemental libraries

* Fix
2020-10-29 16:10:02 -04:00
Brandon Williams
584a1384e4 Remove some CustomDebugOutputConvertible conformances. (#312)
* Remove some CustomDebugOutputConvertible conformances.

* fix tests
2020-10-19 12:46:21 -04:00
Michael Brown
d06e4302a4 Don't depend on Equatable conformance of DispatchQueue (#311) 2020-10-19 12:03:24 -04:00
Michael Brown
74017427ed Fixes bug with LocalizedStringKeyTests (#299)
* * Fix locale issues with LocalizedStringKeyTests
* Use the locale parameter in LocalizedStringKey.formatted()

* Changed test locale to "en_US_POSIX"
2020-09-30 12:06:51 -04:00