Commit Graph

305 Commits

Author SHA1 Message Date
Stephen Celis
fbd893407c Update TestStore.swift (#317) 2020-10-30 17:25:24 -04:00
stephencelis
0190f032c1 Run swift-format 2020-10-29 21:43:17 +00:00
Stephen Celis
5ddbcdd21a Rename publisher-transforming scope (#314)
* Rename publisher-transforming scope

* feedback
2020-10-29 17:29:52 -04:00
Stephen Celis
c4f225b825 Extract supplemental libraries (#315)
* Extract supplemental libraries

* Fix
2020-10-29 16:10:02 -04:00
Jeffrey Macko
1caaff5765 Add support for AccuracyAuthorization (#307)
* Add AccuracyAuthorization for iOS 13/14

* Remove Header

* Improve implementation still not working on osx

* Re-Format

* Re-Format

* [feat] Add Swift 5.3 ifdef

* Exclude CLAccuracyAuthorization reference from compilers below 5.3.1

Fixes compilation issues on macOS and macCatalyst with Xcode 12.1

* Fix compilation for macCatalyst

* Exclude from compilation on Xcode 11

* Update Sources/ComposableCoreLocation/Interface.swift

Co-authored-by: Andrey Zhukov <git@andrey.se>
Co-authored-by: Stephen Celis <stephen.celis@gmail.com>
2020-10-29 10:37:31 -04:00
Brandon Williams
584a1384e4 Remove some CustomDebugOutputConvertible conformances. (#312)
* Remove some CustomDebugOutputConvertible conformances.

* fix tests
2020-10-19 12:46:21 -04:00
Michael Brown
d06e4302a4 Don't depend on Equatable conformance of DispatchQueue (#311) 2020-10-19 12:03:24 -04:00
Michael Brown
74017427ed Fixes bug with LocalizedStringKeyTests (#299)
* * Fix locale issues with LocalizedStringKeyTests
* Use the locale parameter in LocalizedStringKey.formatted()

* Changed test locale to "en_US_POSIX"
2020-09-30 12:06:51 -04:00
mbrandonw
43a122a34b Run swift-format 2020-09-14 23:02:48 +00:00
Brandon Williams
7e526ba503 Buffer actions when sent recursively (#287)
* wip

* wip

* explicit test store

* test

* test

* clean up

Co-authored-by: Stephen Celis <stephen@stephencelis.com>
2020-09-14 18:58:56 -04:00
Stephen Celis
31f2556c7c Test Store Ergonomics (#285)
* Test Store Ergonomics

* fix merge

* fix
2020-09-10 17:24:27 -04:00
Stephen Celis
3a63b83d30 Drive Test Store with a real Store (#278)
* Failing test

* Drive Test Store using Store

* Update TestStore.swift

* format

* Track state after send

* Use proper snapshot

* Fix?

* fix
2020-09-04 09:20:35 -04:00
Jefferson Setiawan
59216205cf add reverse implementation (#276) 2020-09-03 19:28:23 -04:00
stephencelis
281b07abd1 Run swift-format 2020-08-31 20:32:38 +00:00
Stephen Celis
5171335620 Localizable Alerts and Action Sheets (#275)
* Localizable Alerts and Action Sheets

Fixes #237.

* Tests/fixes

* Update LocalizedStringKey.swift

* Fix
2020-08-31 16:31:34 -04:00
Stephen Celis
13cb3c3165 Update CI to include Xcode 12 (#266)
* Update CI to include Xcode 12

* Use CurrentValueSubject
2020-08-27 12:23:12 -04:00
Brandon Williams
0bf4b25a2e Better error messages for uncompleted effects. (#270) 2020-08-27 10:48:22 -04:00
Stephen Celis
32acc6a859 Document ScrollViewReader problem (#268) 2020-08-26 13:02:59 -04:00
stephencelis
083a4a8cec Run swift-format 2020-08-13 23:53:57 +00:00
Jefferson Setiawan
fffefb9c22 Add implementation of shuffle on IdentifiedArray (#254)
* add shuffle

* Update Tests/ComposableArchitectureTests/IdentifiedArrayTests.swift

* Update IdentifiedArrayTests.swift

Co-authored-by: Stephen Celis <stephen.celis@gmail.com>
2020-08-13 19:52:14 -04:00
Stephen Celis
7f482acbf4 Alert bug exploration (#249)
* wip

* Fix

* revert

* Fix tests

* Better debug output

* organize

* alphabetize

* Fix mac

Co-authored-by: Brandon Williams <mbw234@gmail.com>
2020-08-10 12:47:36 -04:00
Stephen Celis
af1dcf09cf Restore original cancellation logic (#245)
* Revert "Run swift-format"

This reverts commit 6a5b8f276f.

* Revert "Fix iOS 14 Cancellation Crash (#244)"

This reverts commit 2bf1be6bcf.

* Xcode 12 CI

* Update ci.yml
2020-08-06 10:04:02 -04:00
stephencelis
6a5b8f276f Run swift-format 2020-08-03 17:57:32 +00:00
Stephen Celis
2bf1be6bcf Fix iOS 14 Cancellation Crash (#244)
* wip

* wip

Co-authored-by: Brandon Williams <mbw234@gmail.com>
2020-08-03 13:56:24 -04:00
Stephen Celis
e75904c180 Store can use @Published again (#239)
* Store can use @Published again

As of the third beta, assign(to:) takes an `inout Publisher.Publisher`,
so it no longer surfaces an escape hatch through which one could mutate
a store's state.

Fixes #238.

* Fix tests.

* Update ci.yml
2020-07-29 13:48:57 -04:00
Brandon Williams
ea55ef174e Fix fireAndForget on iOS 13.2 (#240)
* Fix fireAndForget on iOS 13.2

* Drop Xcode 11.2.1, too flakey
2020-07-29 13:06:20 -04:00
mbrandonw
724adfdd0e Run swift-format 2020-07-13 14:23:19 +00:00
Michael Brown
12ee278ef4 Fix issue with ifLet where else was being called too often (#225)
* Fixes issue with ifLet where `else` was being called too often.

* Remove debug printing.

* Attempt to fix compile issue on Xcode 11.3
2020-07-13 10:11:03 -04:00
Stephen Celis
b4fb8a2f4d More docs around Reducer.combine and ordering (#215)
* More docs around Reducer.combine and ordering

* typo

* Update Sources/ComposableArchitecture/Reducer.swift

Co-authored-by: Brandon Williams <135203+mbrandonw@users.noreply.github.com>

* more

* Update Reducer.swift

* more

Co-authored-by: Brandon Williams <135203+mbrandonw@users.noreply.github.com>
2020-07-09 11:23:23 -04:00
Brandon Williams
c2f64aa874 Update docs for Effect.timer and TestStore. (#220)
* Update docs for Effect.timer and TestStore.

* format

* update

* Update Sources/ComposableArchitecture/Effects/Timer.swift

Co-authored-by: Stephen Celis <stephen@stephencelis.com>

* Update Sources/ComposableArchitecture/TestSupport/TestStore.swift

Co-authored-by: Stephen Celis <stephen@stephencelis.com>

* wip

* Update TestStore.swift

Co-authored-by: Stephen Celis <stephen@stephencelis.com>
2020-07-09 10:25:06 -04:00
Stephen Celis
3deb9a01bf Make deprecated interfaces unavailable (#219) 2020-07-09 09:24:28 -04:00
Alejandro Martínez
f40942fa08 Added file and line to optional assert (#218)
* Added file and line to optional assert

* Apply suggestions from code review

Co-authored-by: Stephen Celis <stephen.celis@gmail.com>

* Deprecate old optional property and migrated TicTacToe example

* Migrated other examples to optional() and added file/line to forEach

* Update Deprecations.swift

Co-authored-by: Stephen Celis <stephen.celis@gmail.com>
2020-07-08 17:18:48 -04:00
Stephen Celis
a8a7c40029 Xcode 11.6/12 CI (#206)
* Run CI against Xcode 12

* Also run against 11.6

* CurrentValueSubject

* Fix

* Update ci.yml
2020-07-07 11:09:51 -04:00
Bernhard Loibl
d39022f32b Uses scope overload. (#210) 2020-07-06 09:28:19 -04:00
Jasdev Singh
576d0f9b0d Fixes small viewStoreself.store typo in AlertState’s docs. (#208) 2020-07-03 18:16:42 -04:00
Brandon Williams
a905fbf5ec Generic alerts and action sheets (#201)
* alerts

* wip

* wip

* wip

* clean up

* wip

* wip

* wip

* wip

* format

* clean up

* clean up

* docs

* wip

* tests

* API tweaks

* Fix

* More API changes

* More API changes

* More

* Fix

* Fix docs

* Generic alerts optionality (#202)

* Use Optional to model generic alerts

* Xcode 12

* Refinement

* update docs

* Fix

* Fix

* doc fixes

* rename

* fixes

* fixes

Co-authored-by: Stephen Celis <stephen@stephencelis.com>
2020-06-30 09:48:36 -05:00
Stephen Celis
2ce84cce79 Don't use @Published for ViewStore state (#199)
* Don't use @Published for ViewStore state

* Update ci.yml

* Update format.yml
2020-06-25 12:51:02 -04:00
Stephen Celis
21f2dd52ae Merge debug reducer to avoid Combine leak (#195) 2020-06-22 10:43:18 -04:00
Danny Hertz
fc42693ac3 Move ViewStore into root ComposableArchitecture directory (#189) 2020-06-18 07:07:33 -05:00
Olli Tapaninen
1677b2d500 Print offending action on Store.send assertion (#188)
* Print offending action on Store.send assertion

* Reword Store.send assert

Co-authored-by: Brandon Williams <mbw234@gmail.com>

Co-authored-by: Brandon Williams <mbw234@gmail.com>
2020-06-16 07:59:12 -05:00
mbrandonw
e4447bfac8 Run swift-format 2020-06-15 16:44:22 +00:00
Brandon Williams
2f92610ceb Specify action formatting when using .debug (#187)
* Customize action formatting when debugging reducers.

* wip

* wip

* include type

* wip

* tests

* docs

* fix tests

Co-authored-by: Stephen Celis <stephen@stephencelis.com>
2020-06-15 11:41:45 -05:00
nmccann
2e2f46696d Aligned documentation with the implementation (#186)
Co-authored-by: Noah McCann <>
2020-06-15 10:33:05 -04:00
Brandon Williams
207fdfe1dc Remove schedulers in favor of using combine-schedulers (#184)
* Start using combine-schedulers.

* fixes

* wip
2020-06-15 09:10:28 -05:00
Stephen Celis
882e13ffe5 Update Naming of Navigation Case Studies (#177) 2020-06-08 17:40:46 -04:00
Stephen Celis
c41ae19eb8 Update assertion messaging (#170)
* Update assertion messaging

* updated some docs

Co-authored-by: Brandon Williams <mbw234@gmail.com>
2020-06-07 18:08:37 -04:00
stephencelis
aaed2b181a Run swift-format 2020-06-04 18:00:32 +00:00
Stephen Celis
3d89482da6 Add assertion to Reducer.optional (#157)
* Add assertion to Reducer.optional

* Another bug

* Another potential bug

* best practice?

* WIP

* Clean up language and add more language to index-based forEach

* Re-wrap

* Update Sources/ComposableArchitecture/Reducer.swift

Co-authored-by: Brandon Williams <mbw234@gmail.com>

* Update Sources/ComposableArchitecture/Reducer.swift

Co-authored-by: Brandon Williams <mbw234@gmail.com>

* wording

Co-authored-by: Brandon Williams <mbw234@gmail.com>
2020-06-04 13:57:25 -04:00
stephencelis
dd707b7bd6 Run swift-format 2020-06-04 17:44:38 +00:00
Peter Kovacs
8e3804a64e Make forEach explictly check that the ID is present in the IdentifiedArray. (#154) 2020-06-04 13:40:27 -04:00